fix: issues flaged by gemini

Author: Lukasz Kawka

tests/e2e/push_notifications/agent_app.py

@@ -41,7 +41,7 @@ def test_agent_card(url: str) -> AgentCard:
             AgentSkill(
                 id='greeting',
                 name='Greeting Agent',
-                description='just greats the user',
+                description='just greets the user',
                 tags=['greeting'],
                 examples=['Hello Agent!', 'How are you?'],
             )
@@ -64,7 +64,7 @@ async def invoke(
         ):
             await updater.failed(
                 new_agent_text_message(
-                    'Unsupported mesesage.', task.context_id, task.id
+                    'Unsupported message.', task.context_id, task.id
                 )
             )
             return
@@ -122,7 +122,7 @@ async def execute(
     async def cancel(
         self, context: RequestContext, event_queue: EventQueue
     ) -> None:
-        raise Exception('cancel not supported')
+        raise NotImplementedError('cancel not supported')
 
 
 def create_agent_app(

tests/e2e/push_notifications/notifications_app.py

@@ -2,24 +2,31 @@
 
 from typing import Annotated
 
-from fastapi import FastAPI, Path, Request
+from fastapi import FastAPI, Path, Request, HTTPException
 
 
 def create_notifications_app() -> FastAPI:
     """Creates a simple push notification injesting HTTP+REST application."""
     app = FastAPI()
     store_lock = asyncio.Lock()
-    store = {}
+    store: dict[str, list] = {}
 
     @app.post('/notifications')
     async def add_notification(request: Request):
         """Endpoint for injesting notifications from agents. It receives a JSON
         payload and stores it in-memory.
         """
         if not request.headers.get('x-a2a-notification-token'):
-            raise ValueError('Missing x-a2a-notification-token header.')
+            raise HTTPException(
+                status_code=400,
+                detail='Missing "x-a2a-notification-token" header.',
+            )
         payload = await request.json()
-        task_id = payload['id']
+        task_id = payload.get('id')
+        if not task_id:
+            raise HTTPException(
+                status_code=400, detail='Missing "id" in notification payload.'
+            )
         async with store_lock:
             if task_id not in store:
                 store[task_id] = []

tests/e2e/push_notifications/test_default_push_notification_support.py

@@ -215,6 +215,6 @@ async def wait_for_n_notifications(
             return notifications
         if time.time() - start_time > timeout:
             raise TimeoutError(
-                f'Notification retrival timed out. Got {len(notifications)} notifications, want {n}.'
+                f'Notification retrieval timed out. Got {len(notifications)} notifications, want {n}.'
             )
         await asyncio.sleep(0.1)