Fix lint errors

Author: holtskinner

.github/linters/.ruff.toml

@@ -28,6 +28,7 @@ ignore = [
     "E501",   # Ignore line length (handled by Ruff's dynamic line length)
     "ANN002",
     "ANN003",
+    "ANN401",
 ]
 
 select = [

src/a2a/auth/user.py

@@ -22,8 +22,10 @@ class UnauthenticatedUser(User):
 
     @property
     def is_authenticated(self) -> bool:
+        """Returns whether the current user is authenticated."""
         return False
 
     @property
     def user_name(self) -> str:
+        """Returns the user name of the current user."""
         return ''

src/a2a/server/agent_execution/agent_executor.py

@@ -12,7 +12,9 @@ class AgentExecutor(ABC):
     """
 
     @abstractmethod
-    async def execute(self, context: RequestContext, event_queue: EventQueue):
+    async def execute(
+        self, context: RequestContext, event_queue: EventQueue
+    ) -> None:
         """Execute the agent's logic for a given request context.
 
         The agent should read necessary information from the `context` and
@@ -27,7 +29,9 @@ async def execute(self, context: RequestContext, event_queue: EventQueue):
         """
 
     @abstractmethod
-    async def cancel(self, context: RequestContext, event_queue: EventQueue):
+    async def cancel(
+        self, context: RequestContext, event_queue: EventQueue
+    ) -> None:
         """Request the agent to cancel an ongoing task.
 
         The agent should attempt to stop the task identified by the task_id

src/a2a/server/agent_execution/context.py

@@ -20,7 +20,7 @@ class RequestContext:
     tasks.
     """
 
-    def __init__(
+    def __init__(  # noqa: PLR0913
         self,
         request: MessageSendParams | None = None,
         task_id: str | None = None,
@@ -37,6 +37,7 @@ def __init__(
             context_id: The ID of the context explicitly provided in the request or path.
             task: The existing `Task` object retrieved from the store, if any.
             related_tasks: A list of other tasks related to the current request (e.g., for tool use).
+            call_context: The server call context associated with this request.
         """
         if related_tasks is None:
             related_tasks = []
@@ -64,7 +65,7 @@ def __init__(
             else:
                 self._check_or_generate_context_id()
 
-    def get_user_input(self, delimiter='\n') -> str:
+    def get_user_input(self, delimiter: str = '\n') -> str:
         """Extracts text content from the user's message parts.
 
         Args:

src/a2a/server/agent_execution/simple_request_context_builder.py

@@ -14,6 +14,19 @@ def __init__(
         should_populate_referred_tasks: bool = False,
         task_store: TaskStore | None = None,
     ) -> None:
+        """Initializes the SimpleRequestContextBuilder.
+
+        Args:
+            should_populate_referred_tasks: If True, the builder will fetch tasks
+                referenced in `params.message.referenceTaskIds` and populate the
+                `related_tasks` field in the RequestContext. Defaults to False.
+            task_store: The TaskStore instance to use for fetching referred tasks.
+                Required if `should_populate_referred_tasks` is True.
+        """
+        if should_populate_referred_tasks and not task_store:
+            raise ValueError(
+                'task_store is required when should_populate_referred_tasks is True'
+            )
         self._task_store = task_store
         self._should_populate_referred_tasks = should_populate_referred_tasks
 
@@ -25,6 +38,23 @@ async def build(
         task: Task | None = None,
         context: ServerCallContext | None = None,
     ) -> RequestContext:
+        """Builds the request context for an agent execution.
+
+        This method assembles the RequestContext object. If the builder was
+        initialized with `should_populate_referred_tasks=True`, it fetches all tasks
+        referenced in `params.message.referenceTaskIds` from the `task_store`.
+
+        Args:
+            params: The parameters of the incoming message send request.
+            task_id: The ID of the task being executed.
+            context_id: The ID of the current execution context.
+            task: The primary task object associated with the request.
+            context: The server call context, containing metadata about the call.
+
+        Returns:
+            An instance of RequestContext populated with the provided information
+            and potentially a list of related tasks.
+        """
         related_tasks: list[Task] | None = None
 
         if (

src/a2a/server/apps/jsonrpc/fastapi_app.py

@@ -2,7 +2,7 @@
 
 from typing import Any
 
-from fastapi import FastAPI, Request
+from fastapi import FastAPI, Request, Response
 
 from a2a.server.apps.jsonrpc.jsonrpc_app import (
     CallContextBuilder,
@@ -70,17 +70,17 @@ def build(
         app = FastAPI(**kwargs)
 
         @app.post(rpc_url)
-        async def handle_a2a_request(request: Request):
+        async def handle_a2a_request(request: Request) -> Response:
             return await self._handle_requests(request)
 
         @app.get(agent_card_url)
-        async def get_agent_card(request: Request):
+        async def get_agent_card(request: Request) -> Response:
             return await self._handle_get_agent_card(request)
 
         if self.agent_card.supportsAuthenticatedExtendedCard:
 
             @app.get(extended_agent_card_url)
-            async def get_extended_agent_card(request: Request):
+            async def get_extended_agent_card(request: Request) -> Response:
                 return await self._handle_get_authenticated_extended_agent_card(
                     request
                 )

src/a2a/server/apps/jsonrpc/jsonrpc_app.py

@@ -53,11 +53,13 @@ def __init__(self, user: BaseUser):
         self._user = user
 
     @property
-    def is_authenticated(self):
+    def is_authenticated(self) -> bool:
+        """Returns whether the current user is authenticated."""
         return self._user.is_authenticated
 
     @property
-    def user_name(self):
+    def user_name(self) -> str:
+        """Returns the user name of the current user."""
         return self._user.display_name
 
 
@@ -73,7 +75,16 @@ class DefaultCallContextBuilder(CallContextBuilder):
     """A default implementation of CallContextBuilder."""
 
     def build(self, request: Request) -> ServerCallContext:
-        user = UnauthenticatedUser()
+        """Builds a ServerCallContext from a Starlette Request.
+
+        Args:
+            request: The incoming Starlette Request object.
+
+        Returns:
+            A ServerCallContext instance populated with user and state
+            information from the request.
+        """
+        user: A2AUser = UnauthenticatedUser()
         state = {}
         with contextlib.suppress(Exception):
             user = StarletteUserProxy(request.user)
@@ -232,6 +243,7 @@ async def _process_streaming_request(
         Args:
             request_id: The ID of the request.
             a2a_request: The validated A2ARequest object.
+            context: The ServerCallContext for the request.
 
         Returns:
             An `EventSourceResponse` object to stream results to the client.
@@ -263,6 +275,7 @@ async def _process_non_streaming_request(
         Args:
             request_id: The ID of the request.
             a2a_request: The validated A2ARequest object.
+            context: The ServerCallContext for the request.
 
         Returns:
             A `JSONResponse` object containing the result or error.

src/a2a/server/events/queue_manager.py

@@ -7,7 +7,7 @@ class QueueManager(ABC):
     """Interface for managing the event queue lifecycles per task."""
 
     @abstractmethod
-    async def add(self, task_id: str, queue: EventQueue):
+    async def add(self, task_id: str, queue: EventQueue) -> None:
         """Adds a new event queue associated with a task ID."""
 
     @abstractmethod
@@ -19,17 +19,17 @@ async def tap(self, task_id: str) -> EventQueue | None:
         """Creates a child event queue (tap) for an existing task ID."""
 
     @abstractmethod
-    async def close(self, task_id: str):
+    async def close(self, task_id: str) -> None:
         """Closes and removes the event queue for a task ID."""
 
     @abstractmethod
     async def create_or_tap(self, task_id: str) -> EventQueue:
         """Creates a queue if one doesn't exist, otherwise taps the existing one."""
 
 
-class TaskQueueExists(Exception):
+class TaskQueueExists(Exception):  # noqa: N818
     """Exception raised when attempting to add a queue for a task ID that already exists."""
 
 
-class NoTaskQueue(Exception):
+class NoTaskQueue(Exception):  # noqa: N818
     """Exception raised when attempting to access or close a queue for a task ID that does not exist."""

src/a2a/server/request_handlers/default_request_handler.py

@@ -235,7 +235,7 @@ async def on_message_send(
         finally:
             if interrupted:
                 # TODO: Track this disconnected cleanup task.
-                asyncio.create_task(
+                asyncio.create_task(  # noqa: RUF006
                     self._cleanup_producer(producer_task, task_id)
                 )
             else:
@@ -427,6 +427,7 @@ async def on_resubscribe_to_task(
             yield event
 
     def should_add_push_info(self, params: MessageSendParams) -> bool:
+        """Determines if push notification info should be set for a task."""
         return bool(
             self._push_notifier
             and params.configuration

src/a2a/server/tasks/push_notifier.py

@@ -9,17 +9,17 @@ class PushNotifier(ABC):
     @abstractmethod
     async def set_info(
         self, task_id: str, notification_config: PushNotificationConfig
-    ):
+    ) -> None:
         """Sets or updates the push notification configuration for a task."""
 
     @abstractmethod
     async def get_info(self, task_id: str) -> PushNotificationConfig | None:
         """Retrieves the push notification configuration for a task."""
 
     @abstractmethod
-    async def delete_info(self, task_id: str):
+    async def delete_info(self, task_id: str) -> None:
         """Deletes the push notification configuration for a task."""
 
     @abstractmethod
-    async def send_notification(self, task: Task):
+    async def send_notification(self, task: Task) -> None:
         """Sends a push notification containing the latest task state."""