Skip to content

Commit 6afdbcd

Browse files
committed
test: improve naming and readability in BaseClient send_message configuration tests
1 parent bb135cb commit 6afdbcd

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

tests/client/test_base_client.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ async def test_send_message_non_streaming_agent_capability_false(
119119

120120

121121
@pytest.mark.asyncio
122-
async def test_send_message_uses_callsite_configuration_partial_override_non_streaming(
122+
async def test_send_message_callsite_config_overrides_history_length_non_streaming(
123123
base_client: BaseClient, mock_transport: MagicMock, sample_message: Message
124124
):
125125
base_client._config.streaming = False
@@ -131,8 +131,7 @@ async def test_send_message_uses_callsite_configuration_partial_override_non_str
131131

132132
cfg = MessageSendConfiguration(history_length=2)
133133
events = [
134-
ev
135-
async for ev in base_client.send_message(
134+
event async for event in base_client.send_message(
136135
sample_message, configuration=cfg
137136
)
138137
]
@@ -165,8 +164,7 @@ async def test_send_message_ignores_none_fields_in_callsite_configuration_non_st
165164

166165
cfg = MessageSendConfiguration(history_length=None, blocking=None)
167166
events = [
168-
ev
169-
async for ev in base_client.send_message(
167+
event async for event in base_client.send_message(
170168
sample_message, configuration=cfg
171169
)
172170
]
@@ -186,7 +184,7 @@ async def test_send_message_ignores_none_fields_in_callsite_configuration_non_st
186184

187185

188186
@pytest.mark.asyncio
189-
async def test_send_message_uses_callsite_configuration_partial_override_streaming(
187+
async def test_send_message_callsite_config_overrides_history_length_streaming(
190188
base_client: BaseClient, mock_transport: MagicMock, sample_message: Message
191189
):
192190
base_client._config.streaming = True
@@ -203,8 +201,7 @@ async def create_stream(*args, **kwargs):
203201

204202
cfg = MessageSendConfiguration(history_length=0)
205203
events = [
206-
ev
207-
async for ev in base_client.send_message(
204+
event async for event in base_client.send_message(
208205
sample_message, configuration=cfg
209206
)
210207
]

0 commit comments

Comments
 (0)