Skip to content

Commit 77863b6

Browse files
author
long.qul
committed
refactor(server/events): improve event parsing and update test assertions
- Add type annotation for parsed event in RedisQueueManager - Update test assertions to check tap call count in queue manager tests
1 parent 84c6bef commit 77863b6

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/a2a/server/events/redis_queue_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ async def _relay_remote_events(self, subscription_event: dict[str, Any]) -> None
132132

133133
try:
134134
logger.debug(f"Received event for task_id {task_id} in QM {self}: {data_string}")
135-
event = TypeAdapter(Event).validate_json(data_string)
135+
event: Event = TypeAdapter(Event).validate_json(data_string)
136136
except Exception as e:
137137
logger.warning(f"Failed to parse event from subscription event: {subscription_event}: {e}")
138138
return

tests/server/events/test_redis_queue_manager.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ async def test_get_nonexistent_queue(self, queue_manager):
6464
async def test_tap_existing_queue(self, queue_manager, event_queue):
6565
task_id = 'test_task_id'
6666
await queue_manager.add(task_id, event_queue)
67+
event_queue.tap.assert_called_once()
6768

6869
result = await queue_manager.tap(task_id)
6970
assert result == event_queue
70-
event_queue.tap.assert_called_once()
71+
assert event_queue.tap.call_count == 2
7172

7273
@pytest.mark.asyncio
7374
async def test_tap_nonexistent_queue(self, queue_manager):
@@ -88,11 +89,12 @@ async def test_create_or_tap_existing_queue(
8889
):
8990
task_id = 'test_task_id'
9091
await queue_manager.add(task_id, event_queue)
92+
event_queue.tap.assert_called_once()
9193

9294
result = await queue_manager.create_or_tap(task_id)
9395

9496
assert result == event_queue
95-
event_queue.tap.assert_called_once()
97+
assert event_queue.tap.call_count == 2
9698

9799
@pytest.mark.asyncio
98100
async def test_concurrency(self, queue_manager):

0 commit comments

Comments
 (0)