Skip to content

Commit aa34a65

Browse files
committed
address more comments
1 parent 3c7eca5 commit aa34a65

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/server/request_handlers/test_default_request_handler.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import asyncio
22
import time
3+
import logging
34

45
from unittest.mock import (
56
AsyncMock,
@@ -595,9 +596,9 @@ async def execute(self, context: RequestContext, event_queue: EventQueue):
595596
TaskState.working,
596597
message=updater.new_agent_message(parts),
597598
)
598-
except RuntimeError as e:
599+
except Exception as e:
599600
# Stop processing when the event loop is closed
600-
print("Runtim error", e)
601+
logging.warning("Error: %s", e)
601602
return
602603
await updater.add_artifact(
603604
[Part(root=TextPart(text="Hello world!"))],
@@ -635,7 +636,7 @@ async def test_on_message_send_non_blocking():
635636
)
636637

637638
assert result is not None
638-
assert type(result) == Task
639+
assert isinstance(result, Task)
639640
assert result.status.state == TaskState.submitted
640641

641642
# Polling for 500ms until task is completed.

0 commit comments

Comments
 (0)