Merge branch 'main' into make-fastapi-package-optional

Author: holtskinner

.github/workflows/linter.yaml

@@ -26,6 +26,8 @@ jobs:
         run: uv sync --dev
       - name: Run Ruff Linter
         run: uv run ruff check .
+      - name: Run Ruff Format Check
+        run: uv run ruff format --check .
       - name: Run MyPy Type Checker
         run: uv run mypy src
       - name: Run Pyright (Pylance equivalent)

pyproject.toml

@@ -42,10 +42,10 @@ sql = ["sqlalchemy[asyncio,postgresql-asyncpg,aiomysql,aiosqlite]>=2.0.0"]
 encryption = ["cryptography>=43.0.0"]
 
 [project.urls]
-homepage = "https://a2aproject.github.io/A2A/"
+homepage = "https://a2a-protocol.org/"
 repository = "https://github.com/a2aproject/a2a-python"
 changelog = "https://github.com/a2aproject/a2a-python/blob/main/CHANGELOG.md"
-documentation = "https://a2aproject.github.io/A2A/sdk/python/"
+documentation = "https://a2a-protocol.org/latest/sdk/python/"
 
 [tool.hatch.build.targets.wheel]
 packages = ["src/a2a"]

src/a2a/server/request_handlers/jsonrpc_handler.py

@@ -347,10 +347,8 @@ async def list_push_notification_config(
             A `ListTaskPushNotificationConfigResponse` object containing the config or a JSON-RPC error.
         """
         try:
-            config = (
-                await self.request_handler.on_list_task_push_notification_config(
-                    request.params, context
-                )
+            config = await self.request_handler.on_list_task_push_notification_config(
+                request.params, context
             )
             return prepare_response_object(
                 request.id,

src/a2a/server/request_handlers/response_helpers.py

@@ -41,7 +41,7 @@
     GetTaskPushNotificationConfigResponse,
     SendStreamingMessageResponse,
     ListTaskPushNotificationConfigResponse,
-    DeleteTaskPushNotificationConfigResponse
+    DeleteTaskPushNotificationConfigResponse,
 )
 """Type variable for RootModel response types."""
 
@@ -55,7 +55,7 @@
     GetTaskPushNotificationConfigSuccessResponse,
     SendStreamingMessageSuccessResponse,
     ListTaskPushNotificationConfigSuccessResponse,
-    DeleteTaskPushNotificationConfigSuccessResponse
+    DeleteTaskPushNotificationConfigSuccessResponse,
 )
 """Type variable for SuccessResponse types."""
 

src/a2a/server/tasks/push_notification_config_store.py

@@ -7,13 +7,17 @@ class PushNotificationConfigStore(ABC):
     """Interface for storing and retrieving push notification configurations for tasks."""
 
     @abstractmethod
-    async def set_info(self, task_id: str, notification_config: PushNotificationConfig) -> None:
+    async def set_info(
+        self, task_id: str, notification_config: PushNotificationConfig
+    ) -> None:
         """Sets or updates the push notification configuration for a task."""
 
     @abstractmethod
     async def get_info(self, task_id: str) -> list[PushNotificationConfig]:
         """Retrieves the push notification configuration for a task."""
 
     @abstractmethod
-    async def delete_info(self, task_id: str, config_id: str | None = None) -> None:
+    async def delete_info(
+        self, task_id: str, config_id: str | None = None
+    ) -> None:
         """Deletes the push notification configuration for a task."""

src/a2a/server/tasks/task_manager.py

@@ -41,6 +41,9 @@ def __init__(
             initial_message: The `Message` that initiated the task, if any.
                              Used when creating a new task object.
         """
+        if task_id is not None and not (isinstance(task_id, str) and task_id):
+            raise ValueError('Task ID must be a non-empty string')
+
         self.task_id = task_id
         self.context_id = context_id
         self.task_store = task_store

src/a2a/server/tasks/task_updater.py

@@ -60,12 +60,18 @@ async def update_status(
         """
         async with self._lock:
             if self._terminal_state_reached:
-                raise RuntimeError(f"Task {self.task_id} is already in a terminal state.")
+                raise RuntimeError(
+                    f'Task {self.task_id} is already in a terminal state.'
+                )
             if state in self._terminal_states:
                 self._terminal_state_reached = True
                 final = True
 
-            current_timestamp = timestamp if timestamp else datetime.now(timezone.utc).isoformat()
+            current_timestamp = (
+                timestamp
+                if timestamp
+                else datetime.now(timezone.utc).isoformat()
+            )
             await self.event_queue.enqueue_event(
                 TaskStatusUpdateEvent(
                     taskId=self.task_id,
@@ -112,7 +118,7 @@ async def add_artifact(  # noqa: PLR0913
                     metadata=metadata,
                 ),
                 append=append,
-                lastChunk=last_chunk
+                lastChunk=last_chunk,
             )
         )
 

src/a2a/utils/task.py

@@ -55,6 +55,11 @@ def completed_task(
     Returns:
         A `Task` object with status set to 'completed'.
     """
+    if not artifacts or not all(isinstance(a, Artifact) for a in artifacts):
+        raise ValueError(
+            'artifacts must be a non-empty list of Artifact objects'
+        )
+
     if history is None:
         history = []
     return Task(

tests/server/request_handlers/test_default_request_handler.py

@@ -435,13 +435,7 @@ async def test_on_message_send_with_push_notification_no_existing_Task():
         acceptedOutputModes=['text/plain'],  # Added required field
     )
     params = MessageSendParams(
-        message=Message(
-            role=Role.user,
-            messageId='msg_push',
-            parts=[],
-            taskId=task_id,
-            contextId=context_id,
-        ),
+        message=Message(role=Role.user, messageId='msg_push', parts=[]),
         configuration=message_config,
     )