Skip to content

Commit d168b85

Browse files
committed
Convert test strings to uuid
1 parent 13bce87 commit d168b85

13 files changed

+104
-85
lines changed

tests/client/test_base_client.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ async def test_send_message_streaming(
6565
):
6666
async def create_stream(*args, **kwargs):
6767
yield Task(
68-
id='task-123',
69-
context_id='ctx-456',
68+
id='536ab032-6915-47d1-9909-4172dbee4aa0',
69+
context_id='9f18b6e9-63c4-4d44-a8b8-f4648003b6b8',
7070
status=TaskStatus(state=TaskState.completed),
7171
)
7272

@@ -77,7 +77,7 @@ async def create_stream(*args, **kwargs):
7777
mock_transport.send_message_streaming.assert_called_once()
7878
assert not mock_transport.send_message.called
7979
assert len(events) == 1
80-
assert events[0][0].id == 'task-123'
80+
assert str(events[0][0].id) == '536ab032-6915-47d1-9909-4172dbee4aa0'
8181

8282

8383
@pytest.mark.asyncio
@@ -86,8 +86,8 @@ async def test_send_message_non_streaming(
8686
):
8787
base_client._config.streaming = False
8888
mock_transport.send_message.return_value = Task(
89-
id='task-456',
90-
context_id='ctx-789',
89+
id='9368e3b5-c796-46cf-9318-6c73e1a37e58',
90+
context_id='0a934875-fa22-4af0-8b40-79b13d46e4a6',
9191
status=TaskStatus(state=TaskState.completed),
9292
)
9393

@@ -96,7 +96,7 @@ async def test_send_message_non_streaming(
9696
mock_transport.send_message.assert_called_once()
9797
assert not mock_transport.send_message_streaming.called
9898
assert len(events) == 1
99-
assert events[0][0].id == 'task-456'
99+
assert str(events[0][0].id) == '9368e3b5-c796-46cf-9318-6c73e1a37e58'
100100

101101

102102
@pytest.mark.asyncio
@@ -105,7 +105,7 @@ async def test_send_message_non_streaming_agent_capability_false(
105105
):
106106
base_client._card.capabilities.streaming = False
107107
mock_transport.send_message.return_value = Task(
108-
id='task-789',
108+
id='d7541723-0796-4231-8849-f6f137ea3bf8',
109109
context_id='dab80cd1-224d-47cd-abd8-cc53101fb273',
110110
status=TaskStatus(state=TaskState.completed),
111111
)
@@ -115,4 +115,4 @@ async def test_send_message_non_streaming_agent_capability_false(
115115
mock_transport.send_message.assert_called_once()
116116
assert not mock_transport.send_message_streaming.called
117117
assert len(events) == 1
118-
assert events[0][0].id == 'task-789'
118+
assert str(events[0][0].id) == 'd7541723-0796-4231-8849-f6f137ea3bf8'

tests/client/test_client_task_manager.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ async def test_save_task_event_with_artifact_update(
9999
):
100100
await task_manager.save_task_event(sample_task)
101101
artifact = Artifact(
102-
artifact_id='art1', parts=[Part(root=TextPart(text='artifact content'))]
102+
artifact_id='c9aa91c0-7f03-44dd-8ffe-6d168b48d3d5',
103+
parts=[Part(root=TextPart(text='artifact content'))],
103104
)
104105
artifact_update = TaskArtifactUpdateEvent(
105106
task_id=sample_task.id,
@@ -119,14 +120,14 @@ async def test_save_task_event_creates_task_if_not_exists(
119120
task_manager: ClientTaskManager,
120121
):
121122
status_update = TaskStatusUpdateEvent(
122-
task_id='new_task',
123-
context_id='new_context',
123+
task_id='b3cd0887-5074-4534-8f02-172a36f304a0',
124+
context_id='7f1ee76a-85ee-406d-856d-b9128ff7bb98',
124125
status=TaskStatus(state=TaskState.working),
125126
final=False,
126127
)
127128
updated_task = await task_manager.save_task_event(status_update)
128129
assert updated_task is not None
129-
assert updated_task.id == 'new_task'
130+
assert str(updated_task.id) == 'b3cd0887-5074-4534-8f02-172a36f304a0'
130131
assert updated_task.status.state == TaskState.working
131132

132133

@@ -162,7 +163,7 @@ def test_update_with_message_moves_status_message(
162163
task_manager: ClientTaskManager, sample_task: Task, sample_message: Message
163164
):
164165
status_message = Message(
165-
message_id='status_msg',
166+
message_id='f82da050-9487-40eb-ae60-a9eda5dc20fc',
166167
role=Role.agent,
167168
parts=[Part(root=TextPart(text='Status'))],
168169
)

tests/client/test_grpc_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def sample_message_send_params() -> MessageSendParams:
7777
def sample_task() -> Task:
7878
"""Provides a sample Task object."""
7979
return Task(
80-
id='task-1',
80+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
8181
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
8282
status=TaskStatus(state=TaskState.completed),
8383
)

tests/client/test_legacy_client.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ async def test_a2a_client_send_message(
7474

7575
# Mock the underlying transport's send_message method
7676
mock_response_task = Task(
77-
id='task-123',
78-
context_id='ctx-456',
77+
id='536ab032-6915-47d1-9909-4172dbee4aa0',
78+
context_id='9f18b6e9-63c4-4d44-a8b8-f4648003b6b8',
7979
status=TaskStatus(state=TaskState.completed),
8080
)
8181

@@ -91,7 +91,7 @@ async def test_a2a_client_send_message(
9191
)
9292
response = await client.send_message(request)
9393

94-
assert response.root.result.id == 'task-123'
94+
assert str(response.root.result.id) == '536ab032-6915-47d1-9909-4172dbee4aa0'
9595

9696

9797
@pytest.mark.asyncio
@@ -101,15 +101,15 @@ async def test_a2a_grpc_client_get_task(
101101
client = A2AGrpcClient(grpc_stub=mock_grpc_stub, agent_card=grpc_agent_card)
102102

103103
mock_response_task = Task(
104-
id='task-456',
105-
context_id='ctx-789',
104+
id='9368e3b5-c796-46cf-9318-6c73e1a37e58',
105+
context_id='0a934875-fa22-4af0-8b40-79b13d46e4a6',
106106
status=TaskStatus(state=TaskState.working),
107107
)
108108

109109
client.get_task = AsyncMock(return_value=mock_response_task)
110110

111-
params = TaskQueryParams(id='task-456')
111+
params = TaskQueryParams(id='9368e3b5-c796-46cf-9318-6c73e1a37e58')
112112
response = await client.get_task(params)
113113

114-
assert response.id == 'task-456'
114+
assert str(response.id) == '9368e3b5-c796-46cf-9318-6c73e1a37e58'
115115
client.get_task.assert_awaited_once_with(params)

tests/integration/test_client_server_integration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ async def test_http_transport_sends_message_streaming(
232232

233233
message_to_send = Message(
234234
role=Role.user,
235-
message_id='msg-integration-test',
235+
message_id='11aec17b-882d-4c14-a1c3-629e04041bb5',
236236
parts=[Part(root=TextPart(text='Hello, integration test!'))],
237237
)
238238
params = MessageSendParams(message=message_to_send)
@@ -276,7 +276,7 @@ def channel_factory(address: str) -> Channel:
276276

277277
message_to_send = Message(
278278
role=Role.user,
279-
message_id='msg-grpc-integration-test',
279+
message_id='11aec17b-882d-4c14-a1c3-629e04041bb5',
280280
parts=[Part(root=TextPart(text='Hello, gRPC integration test!'))],
281281
)
282282
params = MessageSendParams(message=message_to_send)
@@ -322,7 +322,7 @@ async def test_http_transport_sends_message_blocking(
322322

323323
message_to_send = Message(
324324
role=Role.user,
325-
message_id='msg-integration-test-blocking',
325+
message_id='11aec17b-882d-4c14-a1c3-629e04041bb5',
326326
parts=[Part(root=TextPart(text='Hello, blocking test!'))],
327327
)
328328
params = MessageSendParams(message=message_to_send)
@@ -365,7 +365,7 @@ def channel_factory(address: str) -> Channel:
365365

366366
message_to_send = Message(
367367
role=Role.user,
368-
message_id='msg-grpc-integration-test-blocking',
368+
message_id='11aec17b-882d-4c14-a1c3-629e04041bb5',
369369
parts=[Part(root=TextPart(text='Hello, gRPC blocking test!'))],
370370
)
371371
params = MessageSendParams(message=message_to_send)

tests/server/agent_execution/test_context.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ def mock_params(self, mock_message):
3030
@pytest.fixture
3131
def mock_task(self):
3232
"""Fixture for a mock Task."""
33-
return Mock(spec=Task, id='task-123', context_id='context-456')
33+
return Mock(
34+
spec=Task,
35+
id='536ab032-6915-47d1-9909-4172dbee4aa0',
36+
context_id='context-456',
37+
)
3438

3539
def test_init_without_params(self):
3640
"""Test initialization without parameters."""
@@ -66,7 +70,7 @@ def test_init_with_params_no_ids(self, mock_params):
6670

6771
def test_init_with_task_id(self, mock_params):
6872
"""Test initialization with task ID provided."""
69-
task_id = 'task-123'
73+
task_id = '536ab032-6915-47d1-9909-4172dbee4aa0'
7074
context = RequestContext(request=mock_params, task_id=task_id)
7175

7276
assert context.task_id == task_id
@@ -82,7 +86,7 @@ def test_init_with_context_id(self, mock_params):
8286

8387
def test_init_with_both_ids(self, mock_params):
8488
"""Test initialization with both task and context IDs provided."""
85-
task_id = 'task-123'
89+
task_id = '536ab032-6915-47d1-9909-4172dbee4aa0'
8690
context_id = 'context-456'
8791
context = RequestContext(
8892
request=mock_params, task_id=task_id, context_id=context_id

tests/server/request_handlers/test_grpc_handler.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async def test_send_message_success(
6969
)
7070
)
7171
response_model = types.Task(
72-
id='task-1',
72+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
7373
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
7474
status=types.TaskStatus(state=types.TaskState.completed),
7575
)
@@ -80,7 +80,7 @@ async def test_send_message_success(
8080
mock_request_handler.on_message_send.assert_awaited_once()
8181
assert isinstance(response, a2a_pb2.SendMessageResponse)
8282
assert response.HasField('task')
83-
assert response.task.id == 'task-1'
83+
assert response.task.id == '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
8484

8585

8686
@pytest.mark.asyncio
@@ -110,7 +110,7 @@ async def test_get_task_success(
110110
"""Test successful GetTask call."""
111111
request_proto = a2a_pb2.GetTaskRequest(name='tasks/task-1')
112112
response_model = types.Task(
113-
id='task-1',
113+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
114114
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
115115
status=types.TaskStatus(state=types.TaskState.working),
116116
)
@@ -120,7 +120,7 @@ async def test_get_task_success(
120120

121121
mock_request_handler.on_get_task.assert_awaited_once()
122122
assert isinstance(response, a2a_pb2.Task)
123-
assert response.id == 'task-1'
123+
assert response.id == '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
124124

125125

126126
@pytest.mark.asyncio
@@ -169,7 +169,7 @@ async def test_send_streaming_message(
169169

170170
async def mock_stream():
171171
yield types.Task(
172-
id='task-1',
172+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
173173
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
174174
status=types.TaskStatus(state=types.TaskState.working),
175175
)
@@ -186,7 +186,7 @@ async def mock_stream():
186186

187187
assert len(results) == 1
188188
assert results[0].HasField('task')
189-
assert results[0].task.id == 'task-1'
189+
assert results[0].task.id == '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
190190

191191

192192
@pytest.mark.asyncio
@@ -332,7 +332,7 @@ def side_effect(request, context: ServerCallContext):
332332
context.activated_extensions.add('foo')
333333
context.activated_extensions.add('baz')
334334
return types.Task(
335-
id='task-1',
335+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
336336
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
337337
status=types.TaskStatus(state=types.TaskState.completed),
338338
)
@@ -397,7 +397,7 @@ async def side_effect(request, context: ServerCallContext):
397397
context.activated_extensions.add('foo')
398398
context.activated_extensions.add('baz')
399399
yield types.Task(
400-
id='task-1',
400+
id='1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7',
401401
context_id='e1bbdfd5-8818-4200-873f-8124135770fe',
402402
status=types.TaskStatus(state=types.TaskState.working),
403403
)

tests/server/tasks/test_database_push_notification_config_store.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ async def test_set_and_get_info_single_config(
170170
db_store_parameterized: DatabasePushNotificationConfigStore,
171171
):
172172
"""Test setting and retrieving a single configuration."""
173-
task_id = 'task-1'
173+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
174174
config = PushNotificationConfig(id='config-1', url='http://example.com')
175175

176176
await db_store_parameterized.set_info(task_id, config)
@@ -186,7 +186,7 @@ async def test_set_and_get_info_multiple_configs(
186186
):
187187
"""Test setting and retrieving multiple configurations for a single task."""
188188

189-
task_id = 'task-1'
189+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
190190
config1 = PushNotificationConfig(id='config-1', url='http://example.com/1')
191191
config2 = PushNotificationConfig(id='config-2', url='http://example.com/2')
192192

@@ -204,7 +204,7 @@ async def test_set_info_updates_existing_config(
204204
db_store_parameterized: DatabasePushNotificationConfigStore,
205205
):
206206
"""Test that setting an existing config ID updates the record."""
207-
task_id = 'task-1'
207+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
208208
config_id = 'config-1'
209209
initial_config = PushNotificationConfig(
210210
id=config_id, url='http://initial.url'
@@ -226,7 +226,7 @@ async def test_set_info_defaults_config_id_to_task_id(
226226
db_store_parameterized: DatabasePushNotificationConfigStore,
227227
):
228228
"""Test that config.id defaults to task_id if not provided."""
229-
task_id = 'task-1'
229+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
230230
config = PushNotificationConfig(url='http://example.com') # id is None
231231

232232
await db_store_parameterized.set_info(task_id, config)
@@ -252,7 +252,7 @@ async def test_delete_info_specific_config(
252252
db_store_parameterized: DatabasePushNotificationConfigStore,
253253
):
254254
"""Test deleting a single, specific configuration."""
255-
task_id = 'task-1'
255+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
256256
config1 = PushNotificationConfig(id='config-1', url='http://a.com')
257257
config2 = PushNotificationConfig(id='config-2', url='http://b.com')
258258

@@ -272,7 +272,7 @@ async def test_delete_info_all_for_task(
272272
):
273273
"""Test deleting all configurations for a task when config_id is None."""
274274

275-
task_id = 'task-1'
275+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
276276
config1 = PushNotificationConfig(id='config-1', url='http://a.com')
277277
config2 = PushNotificationConfig(id='config-2', url='http://b.com')
278278

@@ -291,7 +291,9 @@ async def test_delete_info_not_found(
291291
):
292292
"""Test that deleting a non-existent config does not raise an error."""
293293
# Should not raise
294-
await db_store_parameterized.delete_info('task-1', 'non-existent-config')
294+
await db_store_parameterized.delete_info(
295+
'1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7', 'non-existent-config'
296+
)
295297

296298

297299
@pytest.mark.asyncio
@@ -453,7 +455,7 @@ async def test_set_and_get_info_multiple_configs_no_key(
453455
)
454456
await store.initialize()
455457

456-
task_id = 'task-1'
458+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
457459
config1 = PushNotificationConfig(id='config-1', url='http://example.com/1')
458460
config2 = PushNotificationConfig(id='config-2', url='http://example.com/2')
459461

@@ -479,7 +481,7 @@ async def test_data_is_not_encrypted_in_db_if_no_key_is_set(
479481
)
480482
await store.initialize()
481483

482-
task_id = 'task-1'
484+
task_id = '1c3a35ab-e35c-49d8-a37b-7988f5a2ecb7'
483485
config = PushNotificationConfig(id='config-1', url='http://example.com/1')
484486
plain_json = config.model_dump_json()
485487

0 commit comments

Comments
 (0)