Merge remote-tracking branch 'upstream/main' into poc/agent-catalog

Signed-off-by: Shingo OKAWA <[email protected]>

Author: ognis1205

.github/PULL_REQUEST_TEMPLATE.md

@@ -5,6 +5,10 @@ Before submitting your PR, there are a few things you can do to make sure it goe
 
 - [ ] Follow the [`CONTRIBUTING` Guide](https://github.com/google-a2a/a2a-python/blob/main/CONTRIBUTING.md).
 - [ ] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification.
+  - Important Prefixes for [release-please](https://github.com/googleapis/release-please):
+    - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch.
+    - `feat:` represents a new feature, and correlates to a SemVer minor.
+    - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major.
 - [ ] Ensure the tests and linter pass (Run `nox -s format` from the repository root to format)
 - [ ] Appropriate docs were updated (if necessary)
 

.github/actions/spelling/allow.txt

@@ -1,6 +1,7 @@
 ACard
 AClient
 AError
+AFast
 ARequest
 ARun
 AServer
@@ -39,6 +40,7 @@ oauthoidc
 ognis
 opensource
 poc
+protoc
 pyversions
 socio
 sse

.github/linters/.jscpd.json

@@ -1,5 +1,5 @@
 {
-  "ignore": ["**/.github/**", "**/.git/**", "**/tests/**", "**/examples/**"],
+  "ignore": ["**/.github/**", "**/.git/**", "**/tests/**"],
   "threshold": 3,
   "reporters": ["html", "markdown"]
 }

.ruff.toml .github/linters/.ruff.toml.ruff.toml renamed to .github/linters/.ruff.toml

@@ -13,23 +13,22 @@ target-version = "py310" # Minimum Python version
 
 [lint]
 ignore = [
-    "COM812",
-    "FBT001",
-    "FBT002",
-    "D203",
-    "D213",
-    "ANN001",
-    "ANN201",
-    "ANN204",
-    "D100", # Ignore Missing docstring in public module (often desired at top level __init__.py)
-    "D102", # Ignore return type annotation in public method
-    "D104", # Ignore Missing docstring in public package (often desired at top level __init__.py)
-    "D107", # Ignore Missing docstring in __init__ (use class docstring)
-    "TD002", # Ignore Missing author in TODOs (often not required)
-    "TD003", # Ignore Missing issue link in TODOs (often not required/available)
-    "T201", # Ignore print presence
+    "COM812", # Trailing comma missing.
+    "FBT001", # Boolean positional arg in function definition
+    "FBT002", # Boolean default value in function definition
+    "D203",   # 1 blank line required before class docstring (Google: 0)
+    "D213",   # Multi-line docstring summary should start at the second line (Google: first line)
+    "D100",   # Ignore Missing docstring in public module (often desired at top level __init__.py)
+    "D104",   # Ignore Missing docstring in public package (often desired at top level __init__.py)
+    "D107",   # Ignore Missing docstring in __init__ (use class docstring)
+    "TD002",  # Ignore Missing author in TODOs (often not required)
+    "TD003",  # Ignore Missing issue link in TODOs (often not required/available)
+    "T201",   # Ignore print presence
     "RUF012", # Ignore Mutable class attributes should be annotated with `typing.ClassVar`
-    "RUF013", # Ignore implicit optional
+    "E501",   # Ignore line length (handled by Ruff's dynamic line length)
+    "ANN002",
+    "ANN003",
+    "ANN401",
 ]
 
 select = [
@@ -50,12 +49,14 @@ select = [
     "PTH",# flake8-use-pathlib (use pathlib instead of os.path where possible)
     "PL", # Pylint rules ported to Ruff (PLC, PLE, PLR, PLW)
     "PIE",# flake8-pie (misc code improvements, e.g., no-unnecessary-pass)
-    "RUF",# Ruff-specific rules (e.g., RUF001-003 ambiguous unicode)
+    "RUF",# Ruff-specific rules (e.g., RUF001-003 ambiguous unicode, RUF013 implicit optional)
     "RET",# flake8-return (consistency in return statements)
     "SLF",# flake8-self (check for private member access via `self`)
     "TID",# flake8-tidy-imports (relative imports, banned imports - configure if needed)
     "YTT",# flake8-boolean-trap (checks for boolean positional arguments, truthiness tests - Google Style §3.10)
     "TD", # flake8-todos (check TODO format - Google Style §3.7)
+    "TCH",# flake8-type-checking (helps manage TYPE_CHECKING blocks and imports)
+    "PYI",# flake8-pyi (best practices for .pyi stub files, some rules are useful for .py too)
 ]
 
 exclude = [
@@ -80,7 +81,7 @@ exclude = [
     "node_modules",
     "venv",
     "*/migrations/*",
-    "test_*",
+    "noxfile.py",
 ]
 
 [lint.isort]
@@ -98,6 +99,8 @@ lines-between-types = 1
 
 [lint.pydocstyle]
 convention = "google"
+ignore-decorators = ["typing.overload", "abc.abstractmethod"]
+ignore-var-parameters = true
 
 [lint.flake8-annotations]
 mypy-init-return = true
@@ -116,12 +119,27 @@ docstring-quotes = "double"
 inline-quotes = "single"
 
 [lint.per-file-ignores]
-"__init__.py" = ["F401"]  # Ignore unused imports in __init__.py
-"*_test.py" = ["D", "ANN"]  # Ignore docstring and annotation issues in test files
-"test_*.py" = ["D", "ANN"]  # Ignore docstring and annotation issues in test files
+"__init__.py" = ["F401", "D", "ANN"]  # Ignore unused imports in __init__.py
+"*_test.py" = [
+    "D",      # All pydocstyle rules
+    "ANN",    # Missing type annotation for function argument
+    "RUF013", # Implicit optional type in test function signatures
+    "S101",   # Use of `assert` detected (expected in tests)
+    "PLR2004",
+    "SLF001",
+]
+"test_*.py" = [
+    "D",
+    "ANN",
+    "RUF013",
+    "S101",
+    "PLR2004",
+    "SLF001",
+]
 "types.py" = ["D", "E501", "N815"]  # Ignore docstring and annotation issues in types.py
 
 [format]
+exclude = ["types.py"]
 docstring-code-format = true
 docstring-code-line-length = "dynamic" # Or set to 80
 quote-style = "single"

.github/workflows/linter.yaml

@@ -63,4 +63,5 @@ jobs:
           VALIDATE_TYPESCRIPT_STANDARD: false
           VALIDATE_GIT_COMMITLINT: false
           PYTHON_MYPY_CONFIG_FILE: .mypy.ini
-          FILTER_REGEX_INCLUDE: "^src/**"
+          FILTER_REGEX_INCLUDE: ".*src/**/*"
+          PYTHON_RUFF_CONFIG_FILE: .ruff.toml

.vscode/settings.json

@@ -7,8 +7,17 @@
     "editor.defaultFormatter": "charliermarsh.ruff",
     "editor.formatOnSave": true,
     "editor.codeActionsOnSave": {
-      "source.organizeImports": "always"
+      "source.organizeImports": "always",
+      "source.fixAll.ruff": "explicit"
     }
   },
-  "ruff.importStrategy": "fromEnvironment"
+  "ruff.importStrategy": "fromEnvironment",
+  "ruff.lint.args": [
+    "--config",
+    ".github/linters/.ruff.toml"
+  ],
+  "ruff.format.args": [
+    "--config",
+    ".github/linters/.ruff.toml"
+  ]
 }

buf.gen.yaml

@@ -0,0 +1,27 @@
+version: v2
+inputs:
+  - git_repo: https://github.com/google-a2a/A2A.git
+    ref: main
+    subdir: specification/grpc
+managed:
+  enabled: true
+# Python Generation
+# Using remote plugins. To use local plugins replace remote with local
+# pip install protobuf grpcio-tools
+# Optionally, install plugin to generate stubs for grpc services
+# pip install mypy-protobuf
+# Generate python protobuf code
+# - local: protoc-gen-python
+# - out: src/python
+# Generate gRPC stubs
+# - local: protoc-gen-grpc-python
+# - out: src/python
+plugins:
+  # Generate python protobuf related code
+  # Generates *_pb2.py files, one for each .proto
+  - remote: buf.build/protocolbuffers/python
+    out: src/a2a/grpc
+  # Generate python service code.
+  # Generates *_pb2_grpc.py
+  - remote: buf.build/grpc/python
+    out: src/a2a/grpc

noxfile.py

@@ -36,7 +36,7 @@
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def format(session):
+def format(session) -> None:
     """Format Python code using autoflake, pyupgrade, and ruff."""
     # Sort Spelling Allowlist
     spelling_allow_file = '.github/actions/spelling/allow.txt'
@@ -141,10 +141,14 @@ def format(session):
             'ruff',
             'check',
             '--fix-only',
+            '--config',
+            '.github/linters/.ruff.toml',
             *lint_paths_py,
         )
         session.run(
             'ruff',
             'format',
+            '--config',
+            '.github/linters/.ruff.toml',
             *lint_paths_py,
         )

pyproject.toml

@@ -8,6 +8,7 @@ authors = [{ name = "Google LLC", email = "[email protected]" }]
 requires-python = ">=3.10"
 keywords = ["A2A", "A2A SDK", "A2A Protocol", "Agent2Agent"]
 dependencies = [
+    "fastapi>=0.115.12",
     "httpx>=0.28.1",
     "httpx-sse>=0.4.0",
     "opentelemetry-api>=1.33.0",

src/a2a/auth/user.py

@@ -21,9 +21,11 @@ class UnauthenticatedUser(User):
     """A representation that no user has been authenticated in the request."""
 
     @property
-    def is_authenticated(self):
+    def is_authenticated(self) -> bool:
+        """Returns whether the current user is authenticated."""
         return False
 
     @property
     def user_name(self) -> str:
+        """Returns the user name of the current user."""
         return ''