Fix types

Author: holtskinner

src/a2a/server/request_handlers/default_request_handler.py

@@ -494,5 +494,5 @@ async def on_delete_task_push_notification_config(
             raise ServerError(error=TaskNotFoundError())
 
         await self._push_config_store.delete_info(
-            params.id, params.push_notification_configId
+            params.id, params.push_notification_config_id
         )

src/a2a/server/tasks/task_updater.py

@@ -118,7 +118,7 @@ async def add_artifact(  # noqa: PLR0913
                     metadata=metadata,
                 ),
                 append=append,
-                lastChunk=last_chunk,
+                last_chunk=last_chunk,
             )
         )
 
@@ -199,7 +199,7 @@ def new_agent_message(
             role=Role.agent,
             task_id=self.task_id,
             context_id=self.context_id,
-            messageId=str(uuid.uuid4()),
+            message_id=str(uuid.uuid4()),
             metadata=metadata,
             parts=parts,
         )

src/a2a/utils/proto_utils.py

@@ -436,7 +436,7 @@ class FromProto:
     @classmethod
     def message(cls, message: a2a_pb2.Message) -> types.Message:
         return types.Message(
-            messageId=message.message_id,
+            message_id=message.message_id,
             parts=[FromProto.part(p) for p in message.content],
             context_id=message.context_id,
             task_id=message.task_id,
@@ -534,7 +534,7 @@ def task_artifact_update_event(
             artifact=FromProto.artifact(event.artifact),
             metadata=FromProto.metadata(event.metadata),
             append=event.append,
-            lastChunk=event.last_chunk,
+            last_chunk=event.last_chunk,
         )
 
     @classmethod

tests/client/test_grpc_client.py

@@ -64,7 +64,7 @@ def sample_message_send_params() -> MessageSendParams:
     return MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg-1',
+            message_id='msg-1',
             parts=[Part(root=TextPart(text='Hello'))],
         )
     )
@@ -85,7 +85,7 @@ def sample_message() -> Message:
     """Provides a sample Message object."""
     return Message(
         role=Role.agent,
-        messageId='msg-response',
+        message_id='msg-response',
         parts=[Part(root=TextPart(text='Hi there'))],
     )
 

tests/server/agent_execution/test_simple_request_context_builder.py

@@ -32,7 +32,7 @@ def create_sample_message(
     reference_task_ids=None,
 ):
     return Message(
-        messageId=msg_id,
+        message_id=msg_id,
         role=role,
         parts=[Part(root=TextPart(text=content))],
         referenceTaskIds=reference_task_ids if reference_task_ids else [],
@@ -211,7 +211,7 @@ async def test_build_populate_true_reference_ids_empty_or_none(self):
         # To explicitly test None in Message, we'd have to bypass Pydantic default or modify helper.
         # For now, this covers the "no IDs to process" case.
         msg_with_no_refs = Message(
-            messageId='m2', role=Role.user, parts=[], referenceTaskIds=None
+            message_id='m2', role=Role.user, parts=[], referenceTaskIds=None
         )
         params_none_refs = MessageSendParams(message=msg_with_no_refs)
         request_context_none = await builder.build(

tests/server/apps/jsonrpc/test_serialization.py

@@ -163,7 +163,7 @@ def test_handle_unicode_characters(agent_card_with_api_key: AgentCard):
             'message': {
                 'role': 'user',
                 'parts': [{'kind': 'text', 'text': unicode_text}],
-                'messageId': 'msg-unicode',
+                'message_id': 'msg-unicode',
             }
         },
     }
@@ -172,7 +172,7 @@ def test_handle_unicode_characters(agent_card_with_api_key: AgentCard):
     handler.on_message_send.return_value = Message(
         role=Role.agent,
         parts=[Part(root=TextPart(text=f'Received: {unicode_text}'))],
-        messageId='response-unicode',
+        message_id='response-unicode',
     )
 
     response = client.post('/', json=unicode_payload)

tests/server/events/test_event_consumer.py

@@ -36,7 +36,7 @@
 MESSAGE_PAYLOAD: dict[str, Any] = {
     'role': 'agent',
     'parts': [{'text': 'test message'}],
-    'messageId': '111',
+    'message_id': '111',
 }
 
 
@@ -276,7 +276,7 @@ async def test_consume_all_continues_on_queue_empty_if_not_really_closed(
 ):
     """Test that QueueClosed with is_closed=False allows loop to continue via timeout."""
     payload = MESSAGE_PAYLOAD.copy()
-    payload['messageId'] = 'final_event_id'
+    payload['message_id'] = 'final_event_id'
     final_event = Message(**payload)
 
     # Setup dequeue_event behavior:

tests/server/events/test_event_queue.py

@@ -35,7 +35,7 @@
 MESSAGE_PAYLOAD: dict[str, Any] = {
     'role': 'agent',
     'parts': [{'text': 'test message'}],
-    'messageId': '111',
+    'message_id': '111',
 }
 
 

tests/server/request_handlers/test_default_request_handler.py

@@ -276,7 +276,7 @@ async def test_on_cancel_task_invalid_result_type():
     # Mock ResultAggregator to return a Message
     mock_result_aggregator_instance = AsyncMock(spec=ResultAggregator)
     mock_result_aggregator_instance.consume_all.return_value = Message(
-        messageId='unexpected_msg', role=Role.agent, parts=[]
+        message_id='unexpected_msg', role=Role.agent, parts=[]
     )
 
     request_handler = DefaultRequestHandler(
@@ -349,7 +349,7 @@ async def test_on_message_send_with_push_notification():
     params = MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg_push',
+            message_id='msg_push',
             parts=[],
             task_id=task_id,
             context_id=context_id,
@@ -435,7 +435,7 @@ async def test_on_message_send_with_push_notification_no_existing_Task():
         accepted_output_modes=['text/plain'],  # Added required field
     )
     params = MessageSendParams(
-        message=Message(role=Role.user, messageId='msg_push', parts=[]),
+        message=Message(role=Role.user, message_id='msg_push', parts=[]),
         configuration=message_config,
     )
 
@@ -498,7 +498,7 @@ async def test_on_message_send_no_result_from_aggregator():
         request_context_builder=mock_request_context_builder,
     )
     params = MessageSendParams(
-        message=Message(role=Role.user, messageId='msg_no_res', parts=[])
+        message=Message(role=Role.user, message_id='msg_no_res', parts=[])
     )
 
     mock_result_aggregator_instance = AsyncMock(spec=ResultAggregator)
@@ -548,7 +548,7 @@ async def test_on_message_send_task_id_mismatch():
         request_context_builder=mock_request_context_builder,
     )
     params = MessageSendParams(
-        message=Message(role=Role.user, messageId='msg_id_mismatch', parts=[])
+        message=Message(role=Role.user, message_id='msg_id_mismatch', parts=[])
     )
 
     mock_result_aggregator_instance = AsyncMock(spec=ResultAggregator)
@@ -598,7 +598,7 @@ async def test_on_message_send_interrupted_flow():
         request_context_builder=mock_request_context_builder,
     )
     params = MessageSendParams(
-        message=Message(role=Role.user, messageId='msg_interrupt', parts=[])
+        message=Message(role=Role.user, message_id='msg_interrupt', parts=[])
     )
 
     mock_result_aggregator_instance = AsyncMock(spec=ResultAggregator)
@@ -691,7 +691,7 @@ async def test_on_message_send_stream_with_push_notification():
     params = MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg_stream_push',
+            message_id='msg_stream_push',
             parts=[],
             task_id=task_id,
             context_id=context_id,
@@ -947,7 +947,7 @@ async def test_on_message_send_stream_task_id_mismatch():
     )
     params = MessageSendParams(
         message=Message(
-            role=Role.user, messageId='msg_stream_mismatch', parts=[]
+            role=Role.user, message_id='msg_stream_mismatch', parts=[]
         )
     )
 
@@ -1293,7 +1293,7 @@ async def test_on_message_send_stream():
     message_params = MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg-123',
+            message_id='msg-123',
             parts=[Part(root=TextPart(text='How are you?'))],
         ),
     )
@@ -1675,7 +1675,7 @@ async def test_on_message_send_task_in_terminal_state(terminal_state):
     params = MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg_terminal',
+            message_id='msg_terminal',
             parts=[],
             task_id=task_id,
         )
@@ -1719,7 +1719,7 @@ async def test_on_message_send_stream_task_in_terminal_state(terminal_state):
     params = MessageSendParams(
         message=Message(
             role=Role.user,
-            messageId='msg_terminal_stream',
+            message_id='msg_terminal_stream',
             parts=[],
             task_id=task_id,
         )

tests/server/request_handlers/test_jsonrpc_handler.py

@@ -76,7 +76,7 @@
 
 MINIMAL_TASK: dict[str, Any] = {
     'id': 'task_123',
-    'context_id': 'session-xyz',
+    'contextId': 'session-xyz',
     'status': {'state': 'submitted'},
     'kind': 'task',
 }
@@ -595,7 +595,7 @@ async def streaming_coro():
                 call(
                     'http://example.com',
                     json={
-                        'context_id': 'session-xyz',
+                        'contextId': 'session-xyz',
                         'id': 'task_123',
                         'kind': 'task',
                         'status': {'state': 'submitted'},
@@ -616,7 +616,7 @@ async def streaming_coro():
                                 ],
                             }
                         ],
-                        'context_id': 'session-xyz',
+                        'contextId': 'session-xyz',
                         'id': 'task_123',
                         'kind': 'task',
                         'status': {'state': 'submitted'},
@@ -637,7 +637,7 @@ async def streaming_coro():
                                 ],
                             }
                         ],
-                        'context_id': 'session-xyz',
+                        'contextId': 'session-xyz',
                         'id': 'task_123',
                         'kind': 'task',
                         'status': {'state': 'completed'},