Merge branch 'main' into doc/helper-utils

ahoblitz · web-flow · commit e1bd992a8bcd · 2025-09-04T14:55:03.000-04:00
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: 'uv'
+    directory: '/'
+    schedule:
+      interval: 'monthly'
+  - package-ecosystem: 'github-actions'
+    directory: '/'
+    schedule:
+      interval: 'monthly'
diff --git a/.github/workflows/conventional-commits.yml b/.github/workflows/conventional-commits.yml
@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: semantic-pull-request
-        uses: amannn/action-semantic-pull-request@v5.5.3
+        uses: amannn/action-semantic-pull-request@v6.1.1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
diff --git a/.github/workflows/linter.yaml b/.github/workflows/linter.yaml
@@ -12,7 +12,7 @@ jobs:
     if: github.repository == 'a2aproject/a2a-python'
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
 
       - name: Install uv
         uses: astral-sh/setup-uv@v5
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -39,7 +39,7 @@ jobs:
         python-version: ['3.10', '3.13']
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: Set up test environment variables
         run: |
           echo "POSTGRES_TEST_DSN=postgresql+asyncpg://a2a:a2a_password@localhost:5432/a2a_test" >> $GITHUB_ENV
diff --git a/.github/workflows/update-a2a-types.yml b/.github/workflows/update-a2a-types.yml
@@ -12,7 +12,7 @@ jobs:
       pull-requests: write
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
@@ -42,7 +42,7 @@ jobs:
           uv run scripts/grpc_gen_post_processor.py
           echo "Buf generate finished."
       - name: Create Pull Request with Updates
-        uses: peter-evans/create-pull-request@v6
+        uses: peter-evans/create-pull-request@v7
         with:
           token: ${{ secrets.A2A_BOT_PAT }}
           committer: a2a-bot <a2a-bot@google.com>
diff --git a/README.md b/README.md
@@ -4,110 +4,63 @@
 [![PyPI version](https://img.shields.io/pypi/v/a2a-sdk)](https://pypi.org/project/a2a-sdk/)
 ![PyPI - Python Version](https://img.shields.io/pypi/pyversions/a2a-sdk)
 [![PyPI - Downloads](https://img.shields.io/pypi/dw/a2a-sdk)](https://pypistats.org/packages/a2a-sdk)
+[![Python Unit Tests](https://github.com/a2aproject/a2a-python/actions/workflows/unit-tests.yml/badge.svg)](https://github.com/a2aproject/a2a-python/actions/workflows/unit-tests.yml)
+[![Ask DeepWiki](https://deepwiki.com/badge.svg)](https://deepwiki.com/a2aproject/a2a-python)
 
 <!-- markdownlint-disable no-inline-html -->
 
-<html>
-   <h2 align="center">
+<div align="center">
    <img src="https://raw.githubusercontent.com/a2aproject/A2A/refs/heads/main/docs/assets/a2a-logo-black.svg" width="256" alt="A2A Logo"/>
-   </h2>
-   <h3 align="center">A Python library that helps run agentic applications as A2AServers following the <a href="https://a2a-protocol.org">Agent2Agent (A2A) Protocol</a>.</h3>
-</html>
+   <h3>
+      A Python library for running agentic applications as A2A Servers, following the <a href="https://a2a-protocol.org">Agent2Agent (A2A) Protocol</a>.
+   </h3>
+</div>
 
 <!-- markdownlint-enable no-inline-html -->
 
-## Installation
+---
 
-You can install the A2A SDK using either `uv` or `pip`.
+## ✨ Features
 
-## Prerequisites
+- **A2A Protocol Compliant:** Build agentic applications that adhere to the Agent2Agent (A2A) Protocol.
+- **Extensible:** Easily add support for different communication protocols and database backends.
+- **Asynchronous:** Built on modern async Python for high performance.
+- **Optional Integrations:** Includes optional support for:
+  - HTTP servers ([FastAPI](https://fastapi.tiangolo.com/), [Starlette](https://www.starlette.io/))
+  - [gRPC](https://grpc.io/)
+  - [OpenTelemetry](https://opentelemetry.io/) for tracing
+  - SQL databases ([PostgreSQL](https://www.postgresql.org/), [MySQL](https://www.mysql.com/), [SQLite](https://sqlite.org/))
 
-- Python 3.10+
-- `uv` (optional, but recommended) or `pip`
-
-### Using `uv`
-
-When you're working within a uv project or a virtual environment managed by uv, the preferred way to add packages is using uv add.
-
-```bash
-uv add a2a-sdk
-```
-
-To include the optional HTTP server components (FastAPI, Starlette), install the `http-server` extra:
-
-```bash
-uv add a2a-sdk[http-server]
-```
-
-To install with gRPC support:
-
-```bash
-uv add "a2a-sdk[grpc]"
-```
-
-To install with OpenTelemetry tracing support:
-
-```bash
-uv add "a2a-sdk[telemetry]"
-```
-
-To install with database support:
-
-```bash
-# PostgreSQL support
-uv add "a2a-sdk[postgresql]"
-
-# MySQL support
-uv add "a2a-sdk[mysql]"
+---
 
-# SQLite support
-uv add "a2a-sdk[sqlite]"
+## 🚀 Getting Started
 
-# All database drivers
-uv add "a2a-sdk[sql]"
-```
+### Prerequisites
 
-### Using `pip`
-
-If you prefer to use pip, the standard Python package installer, you can install `a2a-sdk` as follows
-
-```bash
-pip install a2a-sdk
-```
-
-To include the optional HTTP server components (FastAPI, Starlette), install the `http-server` extra:
-
-```bash
-pip install a2a-sdk[http-server]
-```
-
-To install with gRPC support:
-
-```bash
-pip install "a2a-sdk[grpc]"
-```
-
-To install with OpenTelemetry tracing support:
+- Python 3.10+
+- `uv` (recommended) or `pip`
 
-```bash
-pip install "a2a-sdk[telemetry]"
-```
+### 🔧 Installation
 
-To install with database support:
+Install the core SDK and any desired extras using your preferred package manager.
 
-```bash
-# PostgreSQL support
-pip install "a2a-sdk[postgresql]"
+| Feature                  | `uv` Command                               | `pip` Command                                |
+| ------------------------ | ------------------------------------------ | -------------------------------------------- |
+| **Core SDK**             | `uv add a2a-sdk`                           | `pip install a2a-sdk`                        |
+| **HTTP Server**          | `uv add "a2a-sdk[http-server]"`            | `pip install "a2a-sdk[http-server]"`         |
+| **gRPC Support**         | `uv add "a2a-sdk[grpc]"`                   | `pip install "a2a-sdk[grpc]"`                |
+| **OpenTelemetry Tracing**| `uv add "a2a-sdk[telemetry]"`              | `pip install "a2a-sdk[telemetry]"`           |
 
-# MySQL support
-pip install "a2a-sdk[mysql]"
+#### Database Support
 
-# SQLite support
-pip install "a2a-sdk[sqlite]"
+Install the necessary drivers for your chosen SQL database.
 
-# All database drivers
-pip install "a2a-sdk[sql]"
-```
+| Database      | `uv` Command                       | `pip` Command                        |
+| ------------- | ---------------------------------- | ------------------------------------ |
+| **PostgreSQL**| `uv add "a2a-sdk[postgresql]"`     | `pip install "a2a-sdk[postgresql]"`  |
+| **MySQL**     | `uv add "a2a-sdk[mysql]"`          | `pip install "a2a-sdk[mysql]"`       |
+| **SQLite**    | `uv add "a2a-sdk[sqlite]"`         | `pip install "a2a-sdk[sqlite]"`      |
+| **All SQL Drivers** | `uv add "a2a-sdk[sql]"`      | `pip install "a2a-sdk[sql]"`         |
 
 ## Examples
 
@@ -130,12 +83,23 @@ pip install "a2a-sdk[sql]"
 
 3. You can validate your agent using the agent inspector. Follow the instructions at the [a2a-inspector](https://github.com/a2aproject/a2a-inspector) repo.
 
-You can also find more Python samples [here](https://github.com/a2aproject/a2a-samples/tree/main/samples/python) and JavaScript samples [here](https://github.com/a2aproject/a2a-samples/tree/main/samples/js).
+---
+
+## 🌐 More Examples
+
+You can find a variety of more detailed examples in the [a2a-samples](https://github.com/a2aproject/a2a-samples) repository:
+
+- **[Python Examples](https://github.com/a2aproject/a2a-samples/tree/main/samples/python)**
+- **[JavaScript Examples](https://github.com/a2aproject/a2a-samples/tree/main/samples/js)**
+
+---
+
+## 🤝 Contributing
 
-## License
+Contributions are welcome! Please see the [CONTRIBUTING.md](CONTRIBUTING.md) file for guidelines on how to get involved.
 
-This project is licensed under the terms of the [Apache 2.0 License](https://raw.githubusercontent.com/a2aproject/a2a-python/refs/heads/main/LICENSE).
+---
 
-## Contributing
+## 📄 License
 
-See [CONTRIBUTING.md](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md) for contribution guidelines.
+This project is licensed under the Apache 2.0 License. See the [LICENSE](LICENSE) file for more details.
diff --git a/src/a2a/server/request_handlers/default_request_handler.py b/src/a2a/server/request_handlers/default_request_handler.py
@@ -344,15 +344,6 @@ async def push_notification_callback() -> None:
                 blocking=blocking,
                 event_callback=push_notification_callback,
             )
-            if not result:
-                raise ServerError(error=InternalError())  # noqa: TRY301
-
-            if isinstance(result, Task):
-                self._validate_task_id_match(task_id, result.id)
-
-            await self._send_push_notification_if_needed(
-                task_id, result_aggregator
-            )
 
         except Exception:
             logger.exception('Agent execution failed')
@@ -367,6 +358,14 @@ async def push_notification_callback() -> None:
             else:
                 await self._cleanup_producer(producer_task, task_id)
 
+        if not result:
+            raise ServerError(error=InternalError())
+
+        if isinstance(result, Task):
+            self._validate_task_id_match(task_id, result.id)
+
+        await self._send_push_notification_if_needed(task_id, result_aggregator)
+
         return result
 
     async def on_message_send_stream(
diff --git a/src/a2a/server/request_handlers/jsonrpc_handler.py b/src/a2a/server/request_handlers/jsonrpc_handler.py
@@ -183,22 +183,26 @@ async def on_cancel_task(
             task = await self.request_handler.on_cancel_task(
                 request.params, context
             )
-            if task:
-                return prepare_response_object(
-                    request.id,
-                    task,
-                    (Task,),
-                    CancelTaskSuccessResponse,
-                    CancelTaskResponse,
-                )
-            raise ServerError(error=TaskNotFoundError())  # noqa: TRY301
         except ServerError as e:
             return CancelTaskResponse(
                 root=JSONRPCErrorResponse(
                     id=request.id, error=e.error if e.error else InternalError()
                 )
             )
 
+        if task:
+            return prepare_response_object(
+                request.id,
+                task,
+                (Task,),
+                CancelTaskSuccessResponse,
+                CancelTaskResponse,
+            )
+
+        return CancelTaskResponse(
+            root=JSONRPCErrorResponse(id=request.id, error=TaskNotFoundError())
+        )
+
     async def on_resubscribe_to_task(
         self,
         request: TaskResubscriptionRequest,
@@ -335,22 +339,26 @@ async def on_get_task(
             task = await self.request_handler.on_get_task(
                 request.params, context
             )
-            if task:
-                return prepare_response_object(
-                    request.id,
-                    task,
-                    (Task,),
-                    GetTaskSuccessResponse,
-                    GetTaskResponse,
-                )
-            raise ServerError(error=TaskNotFoundError())  # noqa: TRY301
         except ServerError as e:
             return GetTaskResponse(
                 root=JSONRPCErrorResponse(
                     id=request.id, error=e.error if e.error else InternalError()
                 )
             )
 
+        if task:
+            return prepare_response_object(
+                request.id,
+                task,
+                (Task,),
+                GetTaskSuccessResponse,
+                GetTaskResponse,
+            )
+
+        return GetTaskResponse(
+            root=JSONRPCErrorResponse(id=request.id, error=TaskNotFoundError())
+        )
+
     async def list_push_notification_config(
         self,
         request: ListTaskPushNotificationConfigRequest,
