Spelling/formatting

Author: holtskinner

.github/actions/spelling/allow.txt

@@ -36,10 +36,12 @@ langgraph
 lifecycles
 linting
 oauthoidc
+oidc
 opensource
 protoc
 pyi
 pyversions
+respx
 socio
 sse
 tagwords

src/a2a/client/__init__.py

@@ -2,8 +2,11 @@
 
 """Client-side components for interacting with an A2A agent."""
 
-from a2a.client.auth import (AuthInterceptor, CredentialService,
-                             InMemoryContextCredentialStore)
+from a2a.client.auth import (
+    AuthInterceptor,
+    CredentialService,
+    InMemoryContextCredentialStore,
+)
 from a2a.client.client import A2ACardResolver, A2AClient
 from a2a.client.errors import (
     A2AClientError,
@@ -14,17 +17,18 @@
 from a2a.client.helpers import create_text_message_object
 from a2a.client.middleware import ClientCallContext, ClientCallInterceptor
 
+
 __all__ = [
     'A2ACardResolver',
     'A2AClient',
     'A2AClientError',
     'A2AClientHTTPError',
     'A2AClientJSONError',
+    'A2AGrpcClient',
     'AuthInterceptor',
     'ClientCallContext',
     'ClientCallInterceptor',
     'CredentialService',
     'InMemoryContextCredentialStore',
-    'A2AGrpcClient',
     'create_text_message_object',
-]
+]

src/a2a/client/auth/__init__.py

@@ -3,8 +3,9 @@
 from .credentials import CredentialService, InMemoryContextCredentialStore
 from .interceptor import AuthInterceptor
 
+
 __all__ = [
+    'AuthInterceptor',
     'CredentialService',
     'InMemoryContextCredentialStore',
-    'AuthInterceptor',
-]
+]

src/a2a/client/auth/credentials.py

@@ -17,12 +17,10 @@ async def get_credentials(
         """
         Retrieves a credential (e.g., token) for a security scheme.
         """
-        pass
 
 
 class InMemoryContextCredentialStore(CredentialService):
-    """
-    A simple in-memory store for session-keyed credentials.
+    """A simple in-memory store for session-keyed credentials.
 
     This class uses the 'sessionId' from the ClientCallContext state to
     store and retrieve credentials...
@@ -48,4 +46,4 @@ async def set_credential(
         """Method to populate the store."""
         if session_id not in self._store:
             self._store[session_id] = {}
-        self._store[session_id][security_scheme_name] = credential
+        self._store[session_id][security_scheme_name] = credential

src/a2a/client/auth/interceptor.py

@@ -1,19 +1,26 @@
 # a2a/client/auth/interceptor.py
 
 import logging
+
 from typing import Any
 
 from a2a.client.auth.credentials import CredentialService
 from a2a.client.middleware import ClientCallContext, ClientCallInterceptor
-from a2a.types import (AgentCard, APIKeySecurityScheme, HTTPAuthSecurityScheme,
-                       In, OAuth2SecurityScheme, OpenIdConnectSecurityScheme)
+from a2a.types import (
+    APIKeySecurityScheme,
+    AgentCard,
+    HTTPAuthSecurityScheme,
+    In,
+    OAuth2SecurityScheme,
+    OpenIdConnectSecurityScheme,
+)
+
 
 logger = logging.getLogger(__name__)
 
 
 class AuthInterceptor(ClientCallInterceptor):
-    """
-    An interceptor that automatically adds authentication details to requests
+    """An interceptor that automatically adds authentication details to requests
     based on the agent's security schemes.
     """
 
@@ -28,39 +35,51 @@ async def intercept(
         agent_card: AgentCard | None,
         context: ClientCallContext | None,
     ) -> tuple[dict[str, Any], dict[str, Any]]:
-        if not agent_card or not agent_card.security or not agent_card.securitySchemes:
+        if (
+            not agent_card
+            or not agent_card.security
+            or not agent_card.securitySchemes
+        ):
             return request_payload, http_kwargs
 
         for requirement in agent_card.security:
-            for scheme_name in requirement: 
+            for scheme_name in requirement:
                 credential = await self._credential_service.get_credentials(
                     scheme_name, context
                 )
                 if credential and scheme_name in agent_card.securitySchemes:
                     scheme_def_union = agent_card.securitySchemes[scheme_name]
-                    if not scheme_def_union: 
+                    if not scheme_def_union:
                         continue
-                    scheme_def = scheme_def_union.root 
+                    scheme_def = scheme_def_union.root
 
                     headers = http_kwargs.get('headers', {})
 
                     is_bearer_scheme = False
-                    if isinstance(scheme_def, HTTPAuthSecurityScheme) and scheme_def.scheme.lower() == 'bearer':
-                        is_bearer_scheme = True
-                    elif isinstance(scheme_def, (OAuth2SecurityScheme, OpenIdConnectSecurityScheme)):
+                    if (
+                        isinstance(scheme_def, HTTPAuthSecurityScheme)
+                        and scheme_def.scheme.lower() == 'bearer'
+                    ) or isinstance(
+                        scheme_def,
+                        (OAuth2SecurityScheme, OpenIdConnectSecurityScheme),
+                    ):
                         is_bearer_scheme = True
 
                     if is_bearer_scheme:
-                        headers['Authorization'] = f"Bearer {credential}"
-                        logger.debug(f"Added Bearer token for scheme '{scheme_name}' (type: {scheme_def.type}).")
+                        headers['Authorization'] = f'Bearer {credential}'
+                        logger.debug(
+                            f"Added Bearer token for scheme '{scheme_name}' (type: {scheme_def.type})."
+                        )
                         http_kwargs['headers'] = headers
                         return request_payload, http_kwargs
-                    elif isinstance(scheme_def, APIKeySecurityScheme):
-                        if scheme_def.in_ == In.header: 
+                    if isinstance(scheme_def, APIKeySecurityScheme):
+                        if scheme_def.in_ == In.header:
                             headers[scheme_def.name] = credential
-                            logger.debug(f"Added API Key Header for scheme '{scheme_name}'.")
+                            logger.debug(
+                                f"Added API Key Header for scheme '{scheme_name}'."
+                            )
                             http_kwargs['headers'] = headers
                             return request_payload, http_kwargs
                         # Note: API keys in query or cookie are not handled here.
-        
-        return request_payload, http_kwargs
+
+        return request_payload, http_kwargs

src/a2a/client/client.py

@@ -1,25 +1,35 @@
 import json
 import logging
+
 from collections.abc import AsyncGenerator
 from typing import Any
 from uuid import uuid4
 
 import httpx
+
 from httpx_sse import SSEError, aconnect_sse
 from pydantic import ValidationError
 
 from a2a.client.errors import A2AClientHTTPError, A2AClientJSONError
 from a2a.client.middleware import ClientCallContext, ClientCallInterceptor
-from a2a.types import (AgentCard, CancelTaskRequest, CancelTaskResponse,
-                       GetTaskPushNotificationConfigRequest,
-                       GetTaskPushNotificationConfigResponse, GetTaskRequest,
-                       GetTaskResponse, SendMessageRequest,
-                       SendMessageResponse, SendStreamingMessageRequest,
-                       SendStreamingMessageResponse,
-                       SetTaskPushNotificationConfigRequest,
-                       SetTaskPushNotificationConfigResponse)
+from a2a.types import (
+    AgentCard,
+    CancelTaskRequest,
+    CancelTaskResponse,
+    GetTaskPushNotificationConfigRequest,
+    GetTaskPushNotificationConfigResponse,
+    GetTaskRequest,
+    GetTaskResponse,
+    SendMessageRequest,
+    SendMessageResponse,
+    SendStreamingMessageRequest,
+    SendStreamingMessageResponse,
+    SetTaskPushNotificationConfigRequest,
+    SetTaskPushNotificationConfigResponse,
+)
 from a2a.utils.telemetry import SpanKind, trace_class
 
+
 logger = logging.getLogger(__name__)
 
 
@@ -157,15 +167,18 @@ async def _apply_interceptors(
         final_request_payload = request_payload
 
         for interceptor in self.interceptors:
-            final_request_payload, final_http_kwargs = await interceptor.intercept(
+            (
+                final_request_payload,
+                final_http_kwargs,
+            ) = await interceptor.intercept(
                 method_name,
                 final_request_payload,
                 final_http_kwargs,
                 self.agent_card,
                 context,
             )
         return final_request_payload, final_http_kwargs
-    
+
     @staticmethod
     async def get_client_from_agent_card_url(
         httpx_client: httpx.AsyncClient,
@@ -224,10 +237,13 @@ async def send_message(
         """
         if not request.id:
             request.id = str(uuid4())
-        
+
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'message/send', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'message/send',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
         response_data = await self._send_request(payload, modified_kwargs)
         return SendMessageResponse(response_data)
@@ -261,9 +277,12 @@ async def send_message_streaming(
 
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'message/stream', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'message/stream',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
-        
+
         modified_kwargs.setdefault('timeout', None)
 
         async with aconnect_sse(
@@ -345,10 +364,13 @@ async def get_task(
         """
         if not request.id:
             request.id = str(uuid4())
-        
+
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'tasks/get', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'tasks/get',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
         response_data = await self._send_request(payload, modified_kwargs)
         return GetTaskResponse(response_data)
@@ -386,7 +408,10 @@ async def cancel_task(
 
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'tasks/cancel', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'tasks/cancel',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
         response_data = await self._send_request(payload, modified_kwargs)
         return CancelTaskResponse(response_data)
@@ -417,7 +442,10 @@ async def set_task_callback(
 
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'tasks/pushNotificationConfig/set', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'tasks/pushNotificationConfig/set',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
         response_data = await self._send_request(payload, modified_kwargs)
         return SetTaskPushNotificationConfigResponse(response_data)
@@ -448,7 +476,10 @@ async def get_task_callback(
 
         # Apply interceptors before sending
         payload, modified_kwargs = await self._apply_interceptors(
-            'tasks/pushNotificationConfig/get', request.model_dump(mode='json', exclude_none=True), http_kwargs, context
+            'tasks/pushNotificationConfig/get',
+            request.model_dump(mode='json', exclude_none=True),
+            http_kwargs,
+            context,
         )
         response_data = await self._send_request(payload, modified_kwargs)
         return GetTaskPushNotificationConfigResponse(response_data)

src/a2a/client/middleware.py

@@ -1,23 +1,23 @@
 from abc import ABC, abstractmethod
-from typing import Any, MutableMapping
+from collections.abc import MutableMapping
+from typing import Any
 
 from pydantic import BaseModel, Field
 
 from a2a.types import AgentCard
 
 
 class ClientCallContext(BaseModel):
-    """
-    A context passed with each client call, allowing for call-specific
+    """A context passed with each client call, allowing for call-specific
     configuration and data passing, such as authentication details or
     request deadlines.
     """
+
     state: MutableMapping[str, Any] = Field(default_factory=dict)
 
 
 class ClientCallInterceptor(ABC):
-    """
-    An abstract base class for client-side call interceptors.
+    """An abstract base class for client-side call interceptors.
 
     Interceptors can inspect and modify requests before they are sent,
     which is ideal for concerns like authentication, logging, or tracing.
@@ -29,8 +29,8 @@ async def intercept(
         method_name: str,
         request_payload: dict[str, Any],
         http_kwargs: dict[str, Any],
-        agent_card: "AgentCard | None",
-        context: "ClientCallContext | None",
+        agent_card: 'AgentCard | None',
+        context: 'ClientCallContext | None',
     ) -> tuple[dict[str, Any], dict[str, Any]]:
         """
         Intercepts a client call before the request is sent.
@@ -46,4 +46,3 @@ async def intercept(
             A tuple containing the (potentially modified) request_payload
             and http_kwargs.
         """
-        pass