Formatting/linting

Author: holtskinner

src/a2a/client/client.py

@@ -137,7 +137,7 @@ async def get_agent_card(
 
 @dataclasses.dataclass
 class ClientConfig:
-    """Configuration class for the A2A Client Factory"""
+    """Configuration class for the A2AClient Factory."""
 
     streaming: bool = True
     """Whether client supports streaming"""
@@ -165,7 +165,7 @@ class ClientConfig:
     """Whether to use client transport preferences over server preferences.
        Recommended to use server preferences in most situations."""
 
-    accepted_outputModes: list[str] = dataclasses.field(default_factory=list)
+    accepted_output_modes: list[str] = dataclasses.field(default_factory=list)
     """The set of accepted output modes for the client."""
 
     push_notification_configs: list[PushNotificationConfig] = dataclasses.field(
@@ -187,9 +187,13 @@ class ClientConfig:
 class Client(ABC):
     def __init__(
         self,
-        consumers: list[Consumer] = [],
-        middleware: list[ClientCallInterceptor] = [],
+        consumers: list[Consumer] | None = None,
+        middleware: list[ClientCallInterceptor] | None = None,
     ):
+        if middleware is None:
+            middleware = []
+        if consumers is None:
+            consumers = []
         self._consumers = consumers or []
         self._middleware = middleware or []
 
@@ -261,19 +265,21 @@ async def get_card(
     ) -> AgentCard:
         pass
 
-    async def add_event_consumer(self, consumer: Consumer):
-        """Attaches additional consumers to the `Client`"""
+    async def add_event_consumer(self, consumer: Consumer) -> None:
+        """Attaches additional consumers to the `Client`."""
         self._consumers.append(consumer)
 
-    async def add_request_middleware(self, middleware: ClientCallInterceptor):
-        """Attaches additional middleware to the `Client`"""
+    async def add_request_middleware(
+        self, middleware: ClientCallInterceptor
+    ) -> None:
+        """Attaches additional middleware to the `Client`."""
         self._middleware.append(middleware)
 
     async def consume(
         self,
         event: tuple[Task, UpdateEvent] | Message | None,
         card: AgentCard,
-    ):
+    ) -> None:
         """Processes the event via all the registered `Consumer`s."""
         if not event:
             return

src/a2a/client/client_factory.py

@@ -48,8 +48,10 @@ class ClientFactory:
     def __init__(
         self,
         config: ClientConfig,
-        consumers: list[Consumer] = [],
+        consumers: list[Consumer] | None = None,
     ):
+        if consumers is None:
+            consumers = []
         self._config = config
         self._consumers = consumers
         self._registry: dict[str, ClientProducer] = {}
@@ -62,7 +64,7 @@ def __init__(
         if Transports.GRPC in self._config.supported_transports:
             self._registry[Transports.GRPC] = NewGrpcClient
 
-    def register(self, label: str, generator: ClientProducer):
+    def register(self, label: str, generator: ClientProducer) -> None:
         """Register a new client producer for a given transport label."""
         self._registry[label] = generator
 
@@ -117,7 +119,9 @@ def create(
         )
 
 
-def minimal_agent_card(url: str, transports: list[str] = []) -> AgentCard:
+def minimal_agent_card(
+    url: str, transports: list[str] | None = None
+) -> AgentCard:
     """Generates a minimal card to simplify bootstrapping client creation.
 
     This minimal card is not viable itself to interact with the remote agent.
@@ -126,6 +130,8 @@ def minimal_agent_card(url: str, transports: list[str] = []) -> AgentCard:
     correct agent card. This pattern is necessary for gRPC based card access
     as typically these servers won't expose a well known path card.
     """
+    if transports is None:
+        transports = []
     return AgentCard(
         url=url,
         preferred_transport=transports[0] if transports else None,

src/a2a/client/client_task_manager.py

@@ -25,7 +25,7 @@ class ClientTaskManager:
 
     def __init__(
         self,
-    ):
+    ) -> None:
         """Initializes the `ClientTaskManager`."""
         self._current_task: Task | None = None
         self._task_id: str | None = None
@@ -132,7 +132,7 @@ async def process(self, event: Event) -> Event:
         return event
 
     async def _save_task(self, task: Task) -> None:
-        """Saves the given task to the `_current_task` and updated `_task_id` and `_context_id`
+        """Saves the given task to the `_current_task` and updated `_task_id` and `_context_id`.
 
         Args:
             task: The `Task` object to save.

src/a2a/client/grpc_client.py

@@ -27,8 +27,8 @@
     AgentCard,
     GetTaskPushNotificationConfigParams,
     Message,
-    MessageSendParams,
     MessageSendConfiguration,
+    MessageSendParams,
     Task,
     TaskArtifactUpdateEvent,
     TaskIdParams,
@@ -335,47 +335,43 @@ async def get_task(
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
-        response = await self._transport_client.get_task(
+        return await self._transport_client.get_task(
             request,
             context=context,
         )
-        return response
 
     async def cancel_task(
         self,
         request: TaskIdParams,
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
-        response = await self._transport_client.cancel_task(
+        return await self._transport_client.cancel_task(
             request,
             context=context,
         )
-        return response
 
     async def set_task_callback(
         self,
         request: TaskPushNotificationConfig,
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
-        response = await self._transport_client.set_task_callback(
+        return await self._transport_client.set_task_callback(
             request,
             context=context,
         )
-        return response
 
     async def get_task_callback(
         self,
         request: GetTaskPushNotificationConfigParams,
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
-        response = await self._transport_client.get_task_callback(
+        return await self._transport_client.get_task_callback(
             request,
             context=context,
         )
-        return response
 
     async def resubscribe(
         self,

src/a2a/client/jsonrpc_client.py

@@ -437,7 +437,7 @@ async def resubscribe(
         http_kwargs: dict[str, Any] | None = None,
         context: ClientCallContext | None = None,
     ) -> AsyncGenerator[SendStreamingMessageResponse]:
-        """Reconnects to get task updates
+        """Reconnects to get task updates.
 
         This method uses Server-Sent Events (SSE) to receive a stream of updates from the agent.
 

src/a2a/client/rest_client.py

@@ -455,7 +455,7 @@ async def resubscribe(
     ) -> AsyncGenerator[
         Task | TaskStatusUpdateEvent | TaskArtifactUpdateEvent | Message
     ]:
-        """Reconnects to get task updates
+        """Reconnects to get task updates.
 
         This method uses Server-Sent Events (SSE) to receive a stream of updates from the agent.
 
@@ -645,51 +645,47 @@ async def get_task(
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
-        response = await self._transport_client.get_task(
+        return await self._transport_client.get_task(
             request,
             http_kwargs=self.get_http_args(context),
             context=context,
         )
-        return response
 
     async def cancel_task(
         self,
         request: TaskIdParams,
         *,
         context: ClientCallContext | None = None,
     ) -> Task:
-        response = await self._transport_client.cancel_task(
+        return await self._transport_client.cancel_task(
             request,
             http_kwargs=self.get_http_args(context),
             context=context,
         )
-        return response
 
     async def set_task_callback(
         self,
         request: TaskPushNotificationConfig,
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
-        response = await self._transport_client.set_task_callback(
+        return await self._transport_client.set_task_callback(
             request,
             http_kwargs=self.get_http_args(context),
             context=context,
         )
-        return response
 
     async def get_task_callback(
         self,
         request: GetTaskPushNotificationConfigParams,
         *,
         context: ClientCallContext | None = None,
     ) -> TaskPushNotificationConfig:
-        response = await self._transport_client.get_task_callback(
+        return await self._transport_client.get_task_callback(
             request,
             http_kwargs=self.get_http_args(context),
             context=context,
         )
-        return response
 
     async def resubscribe(
         self,

src/a2a/server/request_handlers/rest_handler.py

@@ -253,7 +253,7 @@ async def set_push_notification(
                 found.
         """
         try:
-            task_id = request.path_params['id']
+            _ = request.path_params['id']
             body = await request.body()
             params = a2a_pb2.TaskPushNotificationConfig()
             Parse(body, params)