Skip to content

Conversation

@rajeshvelicheti
Copy link
Contributor

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rajeshvelicheti rajeshvelicheti requested a review from a team as a code owner June 9, 2025 17:45
@rajeshvelicheti
Copy link
Contributor Author

@holtskinner I see there is an action on a2a repo (spec changes) to trigger the generation on a2a-python. Could you help with a similar action for grpc generation. The script in this will fix the imports post generation.

@holtskinner
Copy link
Member

I see there is an action on a2a repo (spec changes) to trigger the generation on a2a-python. Could you help with a similar action for grpc generation. The script in this will fix the imports post generation.

Yes, we can do that, I just need the specific script to run which generates the grpc py files. Is it the steps outlined here? https://github.com/google-a2a/A2A/tree/main/specification/grpc#protocol-buffer-definitions

@pstephengoogle pstephengoogle merged commit d537285 into main Jun 9, 2025
6 checks passed
@pstephengoogle pstephengoogle deleted the buf_post_processing branch June 9, 2025 19:06
@rajeshvelicheti
Copy link
Contributor Author

I see there is an action on a2a repo (spec changes) to trigger the generation on a2a-python. Could you help with a similar action for grpc generation. The script in this will fix the imports post generation.

Yes, we can do that, I just need the specific script to run which generates the grpc py files. Is it the steps outlined here? https://github.com/google-a2a/A2A/tree/main/specification/grpc#protocol-buffer-definitions

@holtskinner these are the commands

buf generate
uv run scripts/grpc_gen_post_processor.py

The first will generate the code in src/a2a/grpc and the second will fix the imports on source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants