Skip to content

Conversation

@kthota-g
Copy link
Contributor

@kthota-g kthota-g commented Jun 18, 2025

BEGIN_COMMIT_OVERRIDE
refactor!: Removes push_notifier interface from the SDK and introduces push_notification_config_store and push_notification_sender for supporting push notifications.

feat: Adds support for more than one push_notification_config per task.

feat: Adds support for List and Delete push notification configurations.


Following is an example for the changes required with new version:

Previously:

from a2a.server.tasks import InMemoryPushNotifier
...
...
httpx_client = httpx.AsyncClient()
request_handler = DefaultRequestHandler(
    agent_executor=CurrencyAgentExecutor(),
    task_store=InMemoryTaskStore(),
    push_notifier=InMemoryPushNotifier(httpx_client),
)
...
...

Now:

from a2a.server.tasks import InMemoryPushNotificationConfigStore, BasePushNotificationSender
...
...
httpx_client = httpx.AsyncClient()
push_notification_config_store = InMemoryPushNotificationConfigStore()
push_notification_sender = BasePushNotificationSender(httpx_client,
                        config_store=push_notification_config_store)
        
request_handler = DefaultRequestHandler(
    agent_executor=CurrencyAgentExecutor(),
    task_store=InMemoryTaskStore(),
    push_config_store=push_notification_config_store,
    push_sender=push_notification_sender
)
...
...

Release-As: 0.2.11

END_COMMIT_OVERRIDE

@kthota-g kthota-g requested a review from a team as a code owner June 18, 2025 00:07
@kthota-g kthota-g requested a review from zeroasterisk June 18, 2025 00:07
@kthota-g kthota-g changed the title refactor!: Push notification changes refactor!: Push notification changes [DO NOT MERGE] Jun 18, 2025
@kthota-g kthota-g requested review from swapydapy and removed request for zeroasterisk June 18, 2025 00:22
@holtskinner
Copy link
Member

@kthota-g Can you add this to the PR description with the version this should be for?

Release-As: 0.2.9

@kthota-g
Copy link
Contributor Author

@kthota-g Can you add this to the PR description with the version this should be for?

Release-As: 0.2.9

sg. There are additional interface changes required to merge along with this PR. I will tag the release once the PR for other changes are in.

Support for list and delete push notification config.

Removes the push_notifier from the SDK.

This will be merged into push_notif_refactoring branch
(#212) and then merged into
main along with refactoring changes.

---------

Co-authored-by: Holt Skinner <[email protected]>
@kthota-g kthota-g requested a review from a team as a code owner June 23, 2025 20:12
@kthota-g
Copy link
Contributor Author

@swapydapy can you review this one more time? The changes to support multiple configs are complete and have updated the description with changes required for migration.

@kthota-g kthota-g merged commit f1b576e into main Jul 1, 2025
8 checks passed
@kthota-g kthota-g deleted the kthota/push_notif_refactoring branch July 1, 2025 17:29
@kthota-g kthota-g changed the title refactor!: Push notification changes [DO NOT MERGE] refactor!: Push notification changes Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants