fix: comsume_all not catch asyncio.TimeoutError in python 3.10 #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dongruixiao
changed the title
holtskinner
approved these changes
Jun 20, 2025
holtskinner
pushed a commit
that referenced
this pull request
Jun 24, 2025
#216) Starting from 3.11, `asyncio.TimeoutError` is a built-in alias https://docs.python.org/3.11/library/asyncio-exceptions.html
holtskinner
pushed a commit
that referenced
this pull request
Jun 30, 2025
#216) Starting from 3.11, `asyncio.TimeoutError` is a built-in alias https://docs.python.org/3.11/library/asyncio-exceptions.html
holtskinner
added a commit
that referenced
this pull request
Jun 30, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.10](v0.2.8...v0.2.10) (2025-06-30) ### ⚠ BREAKING CHANGES * Update to A2A Spec Version [0.2.5](https://github.com/a2aproject/A2A/releases/tag/v0.2.5) ([#197](#197)) ### Features * Add `append` and `last_chunk` to `add_artifact` method on `TaskUpdater` ([#186](#186)) ([8c6560f](8c6560f)) * add a2a routes to existing app ([#188](#188)) ([32fecc7](32fecc7)) * Add middleware to the client SDK ([#171](#171)) ([efaabd3](efaabd3)) * Add more task state management methods to TaskUpdater ([#208](#208)) ([2b3bf6d](2b3bf6d)) * raise error for tasks in terminal states ([#215](#215)) ([a0bf13b](a0bf13b)) ### Bug Fixes * `consume_all` doesn't catch `asyncio.TimeoutError` in python 3.10 ([#216](#216)) ([39307f1](39307f1)) * Append metadata and context id when processing TaskStatusUpdateE… ([#238](#238)) ([e106020](e106020)) * Fix reference to `grpc.aio.ServicerContext` ([#237](#237)) ([0c1987b](0c1987b)) * Fixes Short Circuit clause for context ID ([#236](#236)) ([a5509e6](a5509e6)) * Resolve `APIKeySecurityScheme` parsing failed ([#226](#226)) ([aa63b98](aa63b98)) * send notifications on message not streaming ([#219](#219)) ([91539d6](91539d6)), closes [#218](#218) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Holt Skinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 3.11,
asyncio.TimeoutErroris a built-in aliashttps://docs.python.org/3.11/library/asyncio-exceptions.html
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.nox -s formatfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕