-
Notifications
You must be signed in to change notification settings - Fork 342
format: update vscode settings regarding formatting #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: update vscode settings regarding formatting #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Paulchen5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to standardize the development environment for VS Code users by introducing recommended extensions and enforcing consistent code formatting rules. This helps ensure a unified code style across the project and improves developer experience by automating common formatting tasks.
Highlights
- VS Code Extension Recommendation: I've added a new
.vscode/extensions.jsonfile to recommend thecharliermarsh.ruffextension. This helps ensure developers use a consistent linter and formatter for Python code within the workspace. - Standardized Formatting Settings: I've updated
.vscode/settings.jsonto enforce consistent code style. Specifically, I've setfiles.insertFinalNewline: true,files.trimFinalNewlines: false, andfiles.trimTrailingWhitespace: false. Additionally, I've addededitor.rulers: [80]to provide a visual guide for line length. - Minor Setting Reformatting: I've also made a minor readability improvement to the
python.testing.pytestArgssetting in.vscode/settings.json, reformatting it to a multi-line array.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces new VS Code settings to enhance code formatting and consistency, and recommends the ruff extension. A suggestion was made to add comments explaining the purpose of the new settings.
69d6014 to
4991073
Compare
|
Looks like your intended changes aren't present, can you re-do them? |
# Description The proposed fix, if the team does want push notifications to be supported in a non-streaming setup Fixes a2aproject#218
# Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Follow the [`CONTRIBUTING` Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests and linter pass (Run `nox -s format` from the repository root to format) - [x] Appropriate docs were updated (if necessary) Fixes N/A 🦕 This PR runs `nox -s format` to fix previously missed formatting issues. Signed-off-by: Shingo OKAWA <[email protected]>
075365b to
6cb7b2b
Compare
Description
add the following settings:
files.insertFinalNewline: truefiles.trimFinalNewlines: falsefiles.trimTrailingWhitespace: falseeditor.rulers: [80]