Skip to content

Conversation

@ognis1205
Copy link
Contributor

@ognis1205 ognis1205 commented Jul 9, 2025

Description

Refactored tests/client/test_auth_middleware.py and added test cases to improve coverage for credentials.py and interceptor.py.

  • src/a2a/client/auth/credentials.py: 94% -> 100%
  • src/a2a/client/auth/interceptor.py: 71% -> 94%

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes N/A 🦕

@ognis1205 ognis1205 requested a review from a team as a code owner July 9, 2025 19:40
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ognis1205, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test suite for the client's authentication middleware. It introduces new test cases and refactors existing ones to ensure robust coverage of credential handling and security scheme application, directly addressing the stated goal of improving code coverage for credentials.py (94% -> 100%) and interceptor.py (71% -> 98%).

Highlights

  • Test Refactoring: Consolidated and streamlined authentication tests using helper functions and a parametrized test structure (AuthTestCase), significantly reducing code duplication and improving maintainability. This includes new helper functions like build_success_response, build_send_message_request, and send_message.
  • Expanded Authentication Coverage: Added comprehensive test cases for AuthInterceptor to cover various security schemes (API Key, OAuth2, OIDC, Bearer) and edge cases, such as scenarios with no agent card, unsupported schemes, or missing scheme definitions.
  • Improved Credential Store Testing: Enhanced the InMemoryContextCredentialStore tests to ensure correct storage, retrieval, and overwriting of credentials based on session IDs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request improves test coverage and refactors the authentication middleware tests. There are a couple of areas for improvement: one is a minor readability enhancement in a test case definition, and the other is a more significant issue where a test doesn't correctly verify its intended scenario.

…auth_middleware.py to improve coverage

Signed-off-by: Shingo OKAWA <[email protected]>
…re.py to improve coverage

Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
@ognis1205 ognis1205 force-pushed the chore/improve-coverage-client branch from f0e1612 to a0418d2 Compare July 10, 2025 15:38
@ognis1205
Copy link
Contributor Author

Thanks for the approval!

I believe this is ready to be merged. I’m planning to improve test coverage for the remaining modules incrementally, so it would be great if this PR could be merged to keep changes small and focused. Let me know if anything else is needed!

@holtskinner holtskinner merged commit 3776721 into a2aproject:main Jul 14, 2025
5 checks passed
@ognis1205 ognis1205 deleted the chore/improve-coverage-client branch July 14, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants