fix: drift in BaseAgentExecutor and uses it in examples#3
Closed
codefromthecrypt wants to merge 2 commits intoa2aproject:mainfrom
Closed
fix: drift in BaseAgentExecutor and uses it in examples#3codefromthecrypt wants to merge 2 commits intoa2aproject:mainfrom
codefromthecrypt wants to merge 2 commits intoa2aproject:mainfrom
Conversation
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
Author
|
@holtskinner this has your change in #2, but has some lint fail unrelated. do you want to correct that in main? or should I add a commit to do that here? |
Member
|
I'll fix the lint issues in main. Don't worry about them here.
|
Contributor
|
BaseAgentExecutor is a leftover class from previous iterations, this class will be removed. |
Author
|
Thanks for the tips |
|
|
||
| async def cancel(self, context: RequestContext, event_queue: EventQueue): | ||
| # Ideally: kill any ongoing tasks. | ||
| raise ServerError(error=UnsupportedOperationError()) |
Author
There was a problem hiding this comment.
@kthota-g is this the correct way to handle UnsupportedOperationError vs the event_queue?
Contributor
There was a problem hiding this comment.
yes, the latest version would handle throwing exceptions from agent executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes drift in BaseAgentExecutor and uses it in examples. Ideally, this can centralize how cancel is to be marked unimplemented in a consistent way.