Skip to content

Conversation

@mindpower
Copy link
Contributor

@mindpower mindpower commented Jul 11, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mindpower mindpower requested a review from a team as a code owner July 11, 2025 22:52
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@mindpower mindpower changed the title Adding sample A2A eval using Vertex AI Eval framework test: adding sample A2A eval colab using Vertex AI Eval framework Jul 11, 2025
@mindpower mindpower changed the title test: adding sample A2A eval colab using Vertex AI Eval framework test: adding sample A2A eval colab using Vertex AI eval framework Jul 11, 2025
Copy link

@chitra-venkatesh chitra-venkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@chitra-venkatesh chitra-venkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mindpower mindpower merged commit 9d12c58 into main Jul 11, 2025
8 checks passed
@mindpower mindpower deleted the jbu/eval branch July 11, 2025 23:51
@holtskinner
Copy link
Member

holtskinner commented Jul 14, 2025

Hi, I removed this commit from the repo and moved the notebook to a2a-samples since notebooks in commit history can significantly increase the size of cloned repos.

Here is the notebook in a2a-samples
https://github.com/a2aproject/a2a-samples/blob/main/notebooks/a2a_evaluation.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants