-
Notifications
You must be signed in to change notification settings - Fork 353
fix(grpc): Fix missing extensions from protobuf #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @agilyol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the protobuf utility functions where message extensions were not being correctly extracted and passed during the conversion of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the missing extensions field when converting a protobuf Message to a types.Message. This is a good fix for deserialization.
However, the fix appears to be incomplete. The extensions field is also missing in the serialization direction, from types.Message to a2a_pb2.Message in the ToProto.message method. Additionally, both types.Artifact and a2a_pb2.Artifact define an extensions field, but the conversions are missing in both ToProto.artifact and FromProto.artifact methods. It would be beneficial to address these missing conversions for consistency and completeness.
I've added a minor suggestion to make the current change more concise.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.3.8](v0.3.7...v0.3.8) (2025-10-06) ### Bug Fixes * Add `__str__` and `__repr__` methods to `ServerError` ([#489](#489)) ([2c152c0](2c152c0)) * **grpc:** Fix missing extensions from protobuf ([#476](#476)) ([8dbc78a](8dbc78a)) * **rest:** send `historyLength=0` (avoid falsy omission) ([#480](#480)) ([ed28b59](ed28b59)), closes [#479](#479) ### Documentation * `a2a-sdk[all]` installation command in Readme ([#485](#485)) ([6ac9a7c](6ac9a7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕