Skip to content

Conversation

@agilyol
Copy link
Contributor

@agilyol agilyol commented Sep 24, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@agilyol agilyol requested a review from a team as a code owner September 24, 2025 00:58
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @agilyol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the protobuf utility functions where message extensions were not being correctly extracted and passed during the conversion of a2a_pb2.Message objects. The change ensures that the extensions field is properly handled, preventing data loss and improving the accuracy of message processing within the system.

Highlights

  • Protobuf Message Handling: Corrected an issue where extensions from protobuf messages were not being properly included when converting a2a_pb2.Message to types.Message. This ensures that all relevant message data, including extensions, is correctly processed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing extensions field when converting a protobuf Message to a types.Message. This is a good fix for deserialization.

However, the fix appears to be incomplete. The extensions field is also missing in the serialization direction, from types.Message to a2a_pb2.Message in the ToProto.message method. Additionally, both types.Artifact and a2a_pb2.Artifact define an extensions field, but the conversions are missing in both ToProto.artifact and FromProto.artifact methods. It would be beneficial to address these missing conversions for consistency and completeness.

I've added a minor suggestion to make the current change more concise.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner holtskinner changed the title fix: Fix missing extensions from protobuf fix(grpc): Fix missing extensions from protobuf Sep 24, 2025
@holtskinner holtskinner enabled auto-merge (squash) September 29, 2025 14:47
@holtskinner holtskinner merged commit 8dbc78a into a2aproject:main Sep 29, 2025
6 checks passed
holtskinner pushed a commit that referenced this pull request Oct 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.3.8](v0.3.7...v0.3.8)
(2025-10-06)


### Bug Fixes

* Add `__str__` and `__repr__` methods to `ServerError`
([#489](#489))
([2c152c0](2c152c0))
* **grpc:** Fix missing extensions from protobuf
([#476](#476))
([8dbc78a](8dbc78a))
* **rest:** send `historyLength=0` (avoid falsy omission)
([#480](#480))
([ed28b59](ed28b59)),
closes [#479](#479)


### Documentation

* `a2a-sdk[all]` installation command in Readme
([#485](#485))
([6ac9a7c](6ac9a7c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants