fix(rest): send historyLength=0 (avoid falsy omission)

[TadakiAsechi]

What
Ensure history_length=0 results in ?historyLength=0 being sent by the REST client.

Why
0 was treated as falsy → the param was omitted → servers returned the full history.

How
Replace truthy check with explicit is not None.

Ref

• Permalink:

  a2a-python/src/a2a/client/transports/rest.py

  Line 217 in 4a4b4a9

  if request.history_length

Fixes #479

[gemini-code-assist]

Summary of Changes

Hello @TadakiAsechi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the REST client's parameter handling. Previously, when a user explicitly requested a history_length of 0, the client's logic inadvertently omitted this parameter from the outgoing request because 0 was treated as a falsy value. This resulted in the server defaulting to returning the complete history, contrary to the client's intent. The change ensures that history_length=0 is always sent, guaranteeing that the server receives and processes the request as intended, thereby preventing the unintended retrieval of full history.

Highlights

• Bug Fix: Addresses an issue where history_length=0 was not correctly sent as a query parameter to the REST client, leading to servers returning the full history instead of an empty one.
• Conditional Logic Update: The conditional check for request.history_length was updated from a truthy check (if request.history_length) to an explicit is not None check (if request.history_length is not None).
• Parameter Handling: Ensures that history_length=0 is now properly included in the URL as ?historyLength=0, allowing the server to correctly interpret the request for zero history.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where history_length=0 was being treated as a falsy value, causing the historyLength query parameter to be omitted from REST requests. The change from a truthy check to if request.history_length is not None is the right solution. I've added one minor suggestion to improve code readability.