DeskTop: Ensure File > Copy To... always copies

Regressed in 3dca09f which unified the File > Copy To... and drag/drop
code paths. Need to not check for move vs. copy when the menu item is
used.

Fixes #853

Author: inexorabletash

desktop/main.s

@@ -864,7 +864,7 @@ check_double_click:
     END_IF
 
         ;; Copy/Move
-        jsr     DoCopySelection
+        jsr     DoCopyOrMoveSelection
         jmp     _PerformPostDropUpdates
 .endproc ; _IconClick
 
@@ -9900,22 +9900,28 @@ FinishOperation:
 ;;; File > Copy To...
 ;;; Drag / Drop (to anything but Trash)
 ;;; Caller sets `path_buf4` (destination)
-.proc DoCopySelection
-        copy    #0, operation_flags ; bit7=0 = copy/delete
-        copy    #$00, copy_delete_flags ; bit7=0 = copy
-
+.proc DoCopyOrMoveSelection
         lda     selected_window_id
         beq     :+              ; dragging volume always copies
         jsr     GetWindowPath
         jsr     CheckMoveOrCopy
-:       sta     move_flag
+:       .byte   OPC_BIT_abs     ; skip next 2-byte instruction
+
+ep_always_copy:
+        lda     #0
+
+        sta     move_flag
+
+        copy    #0, operation_flags ; bit7=0 = copy/delete
+        copy    #$00, copy_delete_flags ; bit7=0 = copy
 
         tsx
         stx     stack_stash
         jsr     PrepCallbacksForEnumeration
         jsr     OpenCopyProgressDialog
         jmp     OperationOnSelection
-.endproc ; DoCopySelection
+.endproc ; DoCopyOrMoveSelection
+DoCopySelection := DoCopyOrMoveSelection::ep_always_copy
 
 ;;; File > Delete
 ;;; Drag / Drop to Trash (except volumes)
@@ -12322,6 +12328,7 @@ ret:    return  #$FF
 
 .endscope ; operations
 
+        DoCopyOrMoveSelection := operations::DoCopyOrMoveSelection
         DoCopySelection := operations::DoCopySelection
         DoDeleteSelection := operations::DoDeleteSelection
         DoCopyToRAM := operations::DoCopyToRAM

res/notes/testplan.md

@@ -488,6 +488,7 @@
 
 * Ensure the startup volume has a name that would be case-adjusted by DeskTop, e.g. `/HD` but that shows as "Hd". Launch DeskTop. Open the startup volume. Apple Menu > Control Panels. Drag a DA file to the startup volume window. Verify that the file is moved, not copied.
 
+* Launch DeskTop. Use File > Copy To... to copy a file. Verify that the file is indeed copied, not moved.
 * Launch DeskTop. Drag a file icon to a same-volume window so it is moved, not copied. Use File > Copy To... to copy a file. Verify that the file is indeed copied, not moved.
 
 # TODO: Rewrite this A -> Vol's icon, B -> Vol's window, C -> Folder's icon, D -> Folder's window