Skip to content

Commit 7b0d27b

Browse files
committed
[gdb/testsuite] Fix gdb.arch/i386-pkru.exp for native-gdbserver
With test-case gdb.arch/i386-pkru.exp and target board native-gdbserver we run into: ... FAIL: gdb.arch/i386-pkru.exp: variable after reading pkru ... This looks similar to the the problem for which there's already an xfail, so fix this by extending the xfail matching. Tested on x86_64-linux. Also tested on openSUSE Tumbleweed, where all tests in the test-case pass.
1 parent 86091ea commit 7b0d27b

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

gdb/testsuite/gdb.arch/i386-pkru.exp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ gdb_test "info register pkru" ".*pkru.*$val1.*" "read pkru register"
8080
set val2 0x44444444
8181
gdb_test "print /x \$pkru = $val2" "= $val2" "set pkru value"
8282

83-
set xval $val2
8483
gdb_test_multiple "info register pkru" "read value after setting value" {
8584
-re -wrap ".*pkru.*$val2.*" {
8685
pass $gdb_test_name
@@ -91,11 +90,21 @@ gdb_test_multiple "info register pkru" "read value after setting value" {
9190
} else {
9291
fail $gdb_test_name
9392
}
94-
set xval $val1
9593
}
9694
}
9795

9896
gdb_breakpoint [ gdb_get_line_number "break here 2" ]
9997
gdb_continue_to_breakpoint "break here 2" ".*break here 2.*"
10098

101-
gdb_test "print /x rd_value" "= $xval" "variable after reading pkru"
99+
gdb_test_multiple "print /x rd_value" "variable after reading pkru" {
100+
-re -wrap "= $val2" {
101+
pass $gdb_test_name
102+
}
103+
-re -wrap "= $val1" {
104+
if { $have_xfail } {
105+
xfail $gdb_test_name
106+
} else {
107+
fail $gdb_test_name
108+
}
109+
}
110+
}

0 commit comments

Comments
 (0)