Re: Sanity check read_section_stabs_debugging_info

amodra · amodra · commit d56e433a7914 · 2023-03-16T11:11:44.000+10:30
* rddbg.c (read_section_stabs_debugging_info): Don't segfault on
	zero size string section.
diff --git a/binutils/rddbg.c b/binutils/rddbg.c
@@ -147,7 +147,8 @@ read_section_stabs_debugging_info (bfd *abfd, asymbol **syms, long symcount,
 	    }
 	  /* Zero terminate the strings table, just in case.  */
 	  strsize = bfd_section_size (strsec);
-	  strings [strsize - 1] = 0;
+	  if (strsize != 0)
+	    strings [strsize - 1] = 0;
 	  if (shandle == NULL)
 	    {
 	      shandle = start_stab (dhandle, abfd, true, syms, symcount);

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,8 @@ read_section_stabs_debugging_info (bfd abfd, asymbol *syms, long symcount,`
`147`	`147`	`}`
`148`	`148`	`/* Zero terminate the strings table, just in case. */`
`149`	`149`	`strsize = bfd_section_size (strsec);`
`150`		`- strings [strsize - 1] = 0;`
	`150`	`+ if (strsize != 0)`
	`151`	`+ strings [strsize - 1] = 0;`
`151`	`152`	`if (shandle == NULL)`
`152`	`153`	`{`
`153`	`154`	`shandle = start_stab (dhandle, abfd, true, syms, symcount);`