Skip to content

Commit fe0adb5

Browse files
committed
sim: build: delete Make-common.in logic
Now that all (other than ppc) build in the top-level, this logic is unused, so punt it all.
1 parent b5075fb commit fe0adb5

File tree

6 files changed

+3
-286
lines changed

6 files changed

+3
-286
lines changed

sim/Makefile.in

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1658,8 +1658,6 @@ SDL_LIBS = @SDL_LIBS@
16581658
SED = @SED@
16591659
SET_MAKE = @SET_MAKE@
16601660
SHELL = @SHELL@
1661-
SIM_COMMON_BUILD_FALSE = @SIM_COMMON_BUILD_FALSE@
1662-
SIM_COMMON_BUILD_TRUE = @SIM_COMMON_BUILD_TRUE@
16631661
SIM_ENABLED_ARCHES = @SIM_ENABLED_ARCHES@
16641662
SIM_FRV_TRAPDUMP_FLAGS = @SIM_FRV_TRAPDUMP_FLAGS@
16651663
SIM_HW_CFLAGS = @SIM_HW_CFLAGS@
@@ -1731,8 +1729,6 @@ program_transform_name = @program_transform_name@
17311729
psdir = @psdir@
17321730
sbindir = @sbindir@
17331731
sharedstatedir = @sharedstatedir@
1734-
sim_bitsize = @sim_bitsize@
1735-
sim_float = @sim_float@
17361732
srcdir = @srcdir@
17371733
subdirs = @subdirs@
17381734
sysconfdir = @sysconfdir@

sim/README-HACKING

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -17,54 +17,11 @@ The common directory contains:
1717

1818
- common documentation files (e.g. run.1, and maybe in time .texi files)
1919
- common source files (e.g. run.c)
20-
- common Makefile fragment and configury (e.g. Make-common.in, aclocal.m4).
20+
- common Makefile fragment and configury (e.g. common/local.mk)
2121

2222
In addition "common" contains portions of the system call support
2323
(e.g. callback.c, target-newlib-*.c).
2424

25-
Common Makefile Support
26-
=======================
27-
28-
A common configuration framework is available for simulators that want
29-
to use it. The common framework exists to remove a lot of duplication
30-
in configure.ac and Makefile.in, and it also provides a foundation for
31-
enhancing the simulators uniformly (e.g. the more they share in common
32-
the easier a feature added to one is added to all).
33-
34-
The Makefile.in of a simulator using the common framework should look like:
35-
36-
--- snip ---
37-
# Makefile for blah ...
38-
# Copyright blah ...
39-
40-
## COMMON_PRE_CONFIG_FRAG
41-
42-
# These variables are given default values in COMMON_PRE_CONFIG_FRAG.
43-
# We override the ones we need to here.
44-
# Not all of these need to be mentioned, only the necessary ones.
45-
# In fact it is better to *not* mention ones if the value is the default.
46-
47-
# List of flags to always pass to $(CC).
48-
SIM_EXTRA_CFLAGS =
49-
# Dependency of `clean' to clean any extra files.
50-
SIM_EXTRA_CLEAN =
51-
52-
## COMMON_POST_CONFIG_FRAG
53-
54-
... target specific rules ...
55-
--- snip ---
56-
57-
COMMON_{PRE,POST}_CONFIG_FRAG are markers for configure to tell it
58-
where to insert the two pieces of common/Make-common.in.
59-
The resulting Makefile is created by doing autoconf substitions on
60-
both the target's Makefile.in and Make-common.in, and inserting
61-
the two pieces of Make-common.in into the target's Makefile.in at
62-
COMMON_{PRE,POST}_CONFIG_FRAG.
63-
64-
Note that SIM_EXTRA_{INSTALL,CLEAN} could be removed and "::" targets
65-
could be used instead. However, it's not clear yet whether "::" targets
66-
are portable enough.
67-
6825
TAGS support
6926
============
7027

sim/common/Make-common.in

Lines changed: 0 additions & 210 deletions
This file was deleted.

sim/common/local.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
## along with this program. If not, see <http://www.gnu.org/licenses/>.
1717

1818
## Parts of the common/ sim code that have been unified.
19-
## Most still lives in common/Make-common.in.
2019

2120
AM_CPPFLAGS += \
2221
-I$(srcdir)/%D% \

sim/configure

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -657,8 +657,6 @@ SIM_MIPS_FPU_BITSIZE
657657
SIM_MIPS_BITSIZE
658658
SIM_MIPS_SUBTARGET
659659
SIM_FRV_TRAPDUMP_FLAGS
660-
sim_float
661-
sim_bitsize
662660
IGEN_FLAGS_SMP
663661
SIM_INLINE
664662
SIM_HW_SOCKSER
@@ -836,8 +834,6 @@ AS_FOR_TARGET_AARCH64
836834
LD_FOR_TARGET
837835
AS_FOR_TARGET
838836
CC_FOR_TARGET
839-
SIM_COMMON_BUILD_FALSE
840-
SIM_COMMON_BUILD_TRUE
841837
SIM_ENABLED_ARCHES
842838
SIM_PRIMARY_TARGET
843839
AM_BACKSLASH
@@ -12448,7 +12444,7 @@ else
1244812444
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
1244912445
lt_status=$lt_dlunknown
1245012446
cat > conftest.$ac_ext <<_LT_EOF
12451-
#line 12451 "configure"
12447+
#line 12447 "configure"
1245212448
#include "confdefs.h"
1245312449

1245412450
#if HAVE_DLFCN_H
@@ -12554,7 +12550,7 @@ else
1255412550
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
1255512551
lt_status=$lt_dlunknown
1255612552
cat > conftest.$ac_ext <<_LT_EOF
12557-
#line 12557 "configure"
12553+
#line 12553 "configure"
1255812554
#include "confdefs.h"
1255912555

1256012556
#if HAVE_DLFCN_H
@@ -14268,11 +14264,6 @@ SIM_PRIMARY_TARGET=
1426814264
SIM_ENABLED_ARCHES=
1426914265

1427014266

14271-
SIM_COMMON_BUILD_TRUE=
14272-
SIM_COMMON_BUILD_FALSE='#'
14273-
14274-
14275-
1427614267
ENABLE_SIM=no
1427714268

1427814269

@@ -16171,9 +16162,6 @@ $as_echo "${WARN_CFLAGS} ${WERROR_CFLAGS}" >&6; }
1617116162
fi
1617216163

1617316164

16174-
16175-
16176-
1617716165
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether sim frv should dump cpu state on unknown traps" >&5
1617816166
$as_echo_n "checking whether sim frv should dump cpu state on unknown traps... " >&6; }
1617916167
# Check whether --enable-sim-frv-trapdump was given.

sim/configure.ac

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ dnl List of enabled arch backends.
5252
SIM_ENABLED_ARCHES=
5353
AC_SUBST(SIM_ENABLED_ARCHES)
5454

55-
dnl Used by common/Make-common.in to see which configure script created it.
56-
SIM_COMMON_BUILD_TRUE=
57-
SIM_COMMON_BUILD_FALSE='#'
58-
AC_SUBST(SIM_COMMON_BUILD_TRUE)
59-
AC_SUBST(SIM_COMMON_BUILD_FALSE)
60-
6155
ENABLE_SIM=no
6256
dnl Build a particular arch subdir.
6357
dnl arg[1] is the arch subdir name.
@@ -166,13 +160,6 @@ SIM_AC_OPTION_STDIO
166160
SIM_AC_OPTION_TRACE
167161
SIM_AC_OPTION_WARNINGS
168162

169-
dnl These are unfortunate. They are conditionally called by other sim macros
170-
dnl but always used by common/Make-common.in. So we have to subst here even
171-
dnl when the rest of the code is in the respective macros. Once we merge the
172-
dnl respective SIM_AC_OPTION_xxx call above, we can drop these.
173-
AC_SUBST(sim_bitsize)
174-
AC_SUBST(sim_float)
175-
176163
dnl Some arches have unique configure flags.
177164
m4_include([frv/acinclude.m4])
178165
m4_include([mips/acinclude.m4])

0 commit comments

Comments
 (0)