src/event-functions.php (1)

349-390: Complete the array key fixes for backward compatibility

Additional array key inconsistencies in the deprecated function:

-$opening_li = $date['id'] === $event_date_id ? '<li class="active" style="text-decoration: underline;">' : '<li>';
+$opening_li = ( isset( $date['id'] ) && $date['id'] === $event_date_id ) ? '<li class="active" style="text-decoration: underline;">' : '<li>';

 // Check if start and end times are on the same day.
-$same_day = wp_date( 'Y-m-d', $date['start_date'], $timezone ) === wp_date( 'Y-m-d', $date['end_date'], $timezone );
+$same_day = wp_date( 'Y-m-d', $date['datetime_start'], $timezone ) === wp_date( 'Y-m-d', $date['datetime_end'], $timezone );

 // Get start and end times.
-$time_start = ( $hide_start_time ) ? '' : wp_date( get_option( 'time_format' ), $date['start_date'], $timezone );
-$time_end   = ( $hide_end_time ) ? '' : wp_date( get_option( 'time_format' ), $date['end_date'], $timezone );
+$time_start = ( $hide_start_time ) ? '' : wp_date( get_option( 'time_format' ), $date['datetime_start'], $timezone );
+$time_end   = ( $hide_end_time ) ? '' : wp_date( get_option( 'time_format' ), $date['datetime_end'], $timezone );

 // Start the output string.
-$single_date_output = wp_date( get_option( 'date_format' ), $date['start_date'], $timezone );
+$single_date_output = wp_date( get_option( 'date_format' ), $date['datetime_start'], $timezone );

 // Return early if we only want the date.
 if ( $date_only ) {
-    $end_date         = wp_date( get_option( 'date_format' ), $date['end_date'], $timezone );
+    $end_date         = wp_date( get_option( 'date_format' ), $date['datetime_end'], $timezone );

     $single_date_output .= sprintf(
         ' %s &ndash; %s %s',
         $time_start,
-        wp_date( get_option( 'date_format' ), $date['end_date'], $timezone ),
+        wp_date( get_option( 'date_format' ), $date['datetime_end'], $timezone ),
         $time_end
     );

src/classes/class-se-event-post-type.php (1)

540-633: Remove or clarify the developer comment.

Line 626 contains a comment // what is this? that appears to be a developer note. This should be removed or replaced with a meaningful comment explaining the comparison logic.

-					'compare' => '>=', // what is this?
+					'compare' => '>=', // Show events that haven't ended yet

src/classes/class-date-display-formatter.php (1)

393-398: Handle null date IDs properly in HTML output.

When $date['id'] is null, this results in an empty ID attribute. The ID attribute should be omitted entirely when null.

-// If we dont have an id on date, set as null.
-if ( ! isset( $date['id'] ) ) {
-    $date['id'] = null;
-}
-$item_class       = array( 'se-event-date-list-item', $date['id'] === $this->event_date_id ? 'se-event-date-list-item__active' : '' );
-$existing_output .= sprintf( '<li id="se-event-date-list-item-%s" class="%s">%s</li>', $date['id'], implode( ' ', $item_class ), $this->render_single_date( $date ) );
+$date_id = isset( $date['id'] ) ? $date['id'] : null;
+$item_class = array( 'se-event-date-list-item' );
+if ( $date_id === $this->event_date_id ) {
+    $item_class[] = 'se-event-date-list-item__active';
+}
+$id_attr = $date_id ? sprintf( ' id="se-event-date-list-item-%s"', esc_attr( $date_id ) ) : '';
+$existing_output .= sprintf( '<li%s class="%s">%s</li>', $id_attr, esc_attr( implode( ' ', $item_class ) ), $this->render_single_date( $date ) );

src/event-functions.php (5)

191-196: Review the future date filtering logic

The current logic filters dates where both start AND end are in the future. This would exclude events that have already started but haven't ended yet. Typically, "future events" include ongoing events.

 $event_dates = array_filter(
     $event_dates,
     function ( $date ) use ( $now ) {
-        return $date['start_date'] > $now && $date['end_date'] > $now;
+        return $date['end_date'] > $now;
     }
 );

---

663-711: Improve validation and fix meta key names

The function has validation issues:

1. Only validates start_date but not end_date
2. Uses incorrect meta key names (should be prefixed with se_event_date_)

 // Validate the event dates, start date should be a timestamp and end date should be a timestamp.
 if ( ! is_numeric( $event_dates['start_date'] ) ) {
     return null;
 }
+if ( ! is_numeric( $event_dates['end_date'] ) ) {
+    return null;
+}

 // Update the post meta for the event date.
 update_post_meta( $event_date_id, 'se_event_date_start', esc_attr( $event_dates['start_date'] ) );
 update_post_meta( $event_date_id, 'se_event_date_end', esc_attr( $event_dates['end_date'] ) );
-update_post_meta( $event_date_id, 'se_event_all_day', boolval( $event_dates['all_day'] ) );
-update_post_meta( $event_date_id, 'se_event_hide_from_calendar', boolval( $event_dates['hide_from_calendar'] ) );
-update_post_meta( $event_date_id, 'se_event_hide_from_feed', boolval( $event_dates['hide_from_feed'] ) );
+update_post_meta( $event_date_id, 'se_event_date_all_day', boolval( $event_dates['all_day'] ) );
+update_post_meta( $event_date_id, 'se_event_date_hide_from_calendar', boolval( $event_dates['hide_from_calendar'] ) );
+update_post_meta( $event_date_id, 'se_event_date_hide_from_feed', boolval( $event_dates['hide_from_feed'] ) );

---

746-764: Fix inconsistent meta key usage.

The function uses inconsistent meta key names that don't match the registered meta keys in the post type class:

 $dates = array_map(
     function ( $date_id ) {
         $start_date         = get_post_meta( $date_id, 'se_event_date_start', true );
         $end_date           = get_post_meta( $date_id, 'se_event_date_end', true );
-        $all_day            = get_post_meta( $date_id, 'se_event_all_day', true );
-        $hide_from_calendar = get_post_meta( $date_id, 'se_event_hide_from_calendar', true );
-        $hide_from_feed     = get_post_meta( $date_id, 'se_event_hide_from_feed', true );
+        $all_day            = get_post_meta( $date_id, 'se_event_date_all_day', true );
+        $hide_from_calendar = get_post_meta( $date_id, 'se_event_date_hide_from_calendar', true );
+        $hide_from_feed     = get_post_meta( $date_id, 'se_event_date_hide_from_feed', true );

---

788-795: Remove redundant setTimestamp call

The timestamp is already set on line 790. The second call on line 795 is redundant.

 try {
     $date_time_object = new DateTime( 'now', new DateTimeZone( $timezone ) );
+    $date_time_object->setTimestamp( $timestamp );
 } catch ( Exception $e ) {
     $date_time_object = new DateTime();
+    $date_time_object->setTimestamp( $timestamp );
     // todo handle exception
 }

-return $date_time_object->setTimestamp( $timestamp );
+return $date_time_object;

---

803-808: Add validation for settings array

The get_option function can return false if the option doesn't exist. Add validation before using array_key_exists.

 function se_event_treat_each_date_as_own_event(): bool {
     $settings = get_option( 'se_options' );
-    return is_array( $settings )
-        && array_key_exists( 'treat_each_date_as_own_event', $settings )
-        && 'on' === $settings['treat_each_date_as_own_event'];
+    return is_array( $settings ) 
+        && array_key_exists( 'treat_each_date_as_own_event', $settings )
+        && 'on' === $settings['treat_each_date_as_own_event'];
 }

src/blocks/event-info/components/DateTimeGroup.js (2)

134-136: Use optional chaining for cleaner code.

The conditional checks can be simplified using optional chaining.

Apply this diff to use optional chaining:

-if (dateManagerInstance && dateManagerInstance.upsertDate) {
-    dateManagerInstance.upsertDate(newEventDateTime);
-}
+dateManagerInstance?.upsertDate?.(newEventDateTime);

This same pattern applies to lines 338-340, 357-359, and 376-378.

Also applies to: 338-340, 357-359, 376-378

---

109-112: Consider extracting the time buffer as a constant.

The 1-hour buffer (3600 seconds) is hardcoded in multiple places. Consider extracting it as a constant for better maintainability.

Add a constant at the top of the file:

+const TIME_BUFFER_SECONDS = 3600; // 1 hour buffer between start and end times
+
 const DateTimeGroupNew = ({

Then use it in the calculations:

-newEventDateTime.end_date = String(
-    parseInt(newEventDateTime.start_date) +
-    3600
-);
+newEventDateTime.end_date = String(
+    parseInt(newEventDateTime.start_date) +
+    TIME_BUFFER_SECONDS
+);

Also applies to: 123-125

src/classes/class-se-block-variations.php (2)

124-124: Fix incomplete comment.

The comment is incomplete and should be fixed.

-// Return back the
+// Return the parent posts with updated dates

---

134-139: Optimize timezone handling.

The timezone fallback and DateTimeZone object creation can be improved.

-// Get the event timezone.
-$timezone = get_post_meta( $parent->ID, 'se_event_timezone', true );
-// use the timezone or default to the site timezone.
-$timezone = $timezone ? $timezone : get_option( 'timezone_string' );
-
-// Get the date im this format 2025-07-01 13:14:09
-$start_date     = wp_date( 'Y-m-d H:i:s', $start_date_ts, new \DateTimeZone( $timezone ) );
-$start_date_gmt = wp_date( 'Y-m-d H:i:s', $start_date_ts, new \DateTimeZone( 'UTC' ) );
+// Get the event timezone with fallback to site timezone
+$timezone = get_post_meta( $parent->ID, 'se_event_timezone', true ) ?: get_option( 'timezone_string' );
+
+// Create timezone objects once
+$tz_obj = new \DateTimeZone( $timezone );
+$utc_obj = new \DateTimeZone( 'UTC' );
+
+// Get the date in this format: 2025-07-01 13:14:09
+$start_date     = wp_date( 'Y-m-d H:i:s', $start_date_ts, $tz_obj );
+$start_date_gmt = wp_date( 'Y-m-d H:i:s', $start_date_ts, $utc_obj );

src/classes/class-date-display-formatter.php (1)

492-492: Fix typo in method documentation.

There's a typo in the docblock.

-* Join a string  with differing separators a the then
+* Join a string with differing separators at the end

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: chrisbellboy
PR: a8cteam51/simple-events#13
File: src/classes/class-se-blocks.php:316-316
Timestamp: 2025-06-10T16:47:40.589Z
Learning: In the Simple Events plugin, the external link label meta field `se_event_external_link_label` has a default value of "Tickets" set at the meta registration level. If an empty string reaches the `se_event_external_link_text` filter, it represents an intentional user choice (e.g., to show only an icon without text), so no fallback default should be applied in the filter.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: chrisbellboy
PR: a8cteam51/simple-events#13
File: src/classes/class-se-blocks.php:316-316
Timestamp: 2025-06-10T16:47:40.589Z
Learning: In the Simple Events plugin, the external link label meta field `se_event_external_link_label` has a default value of "Tickets" set at the meta registration level. If an empty string reaches the `se_event_external_link_text` filter, it represents an intentional user choice (e.g., to show only an icon without text), so no fallback default should be applied in the filter.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

src/classes/class-se-migrate-events.php (3)

6-6: Remove unused import statement.

The use function Crontrol\Event\get; import is not used anywhere in this class and should be removed.

-use function Crontrol\Event\get;

---

256-256: Remove unused parameter from closure.

The $methods parameter in the closure is not used and should be removed to address the static analysis warning.

 return array_filter(
   self::VERSION_UPGRADES,
-  function ( $methods, $min_version ) use ( $version ) {
+  function ( $min_version ) use ( $version ) {
     return version_compare( $version, $min_version, '<' );
   },
-  ARRAY_FILTER_USE_BOTH
+  ARRAY_FILTER_USE_KEY
 );

---

285-285: Remove unused loop variable.

The $key variable in the foreach loop is not used and should be removed.

-foreach ( $dates as $key => $date ) {
+foreach ( $dates as $date ) {

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.956Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

src/classes/class-se-block-variations.php (4)

105-105: Remove the filter after use to prevent affecting other queries.

The modify_event_posts filter is added but never removed, which could cause it to affect other queries unintentionally.

---

221-221: Remove the filter after use to prevent affecting other queries.

Similar to the modify_event_posts filter, the filter_unique_parents_where filter is added but never removed, which could cause it to affect other queries unintentionally.

---

256-259: Escape $meta_key before injecting into SQL

Although $meta_key is always 'se_event_date_start' or 'se_event_date_end', it's best practice to harden this variable against injection. In filter_unique_parents_where() you can either wrap the assignment in esc_sql() or move the meta‐key check into a prepared statement.

Also applies to: 287-287

---

282-303: Consider performance implications of the complex subquery.

The SQL subquery is well-structured and appears correct for ensuring unique parents, but it involves multiple JOINs and subqueries that could be expensive on large datasets.

src/classes/class-se-blocks.php (2)

984-984: Escape $meta_key before injecting into SQL

Same SQL injection concern as in SE_Block_Variations::filter_unique_parents_where().

Also applies to: 1013-1013

---

988-1033: Optimize complex SQL subquery for performance

This SQL subquery with multiple joins and aggregation functions could be a performance bottleneck on large datasets. Consider adding database indexes or implementing caching.

src/classes/class-se-block-variations.php (1)

124-124: Fix incomplete comment.

The comment appears to be incomplete.

-		// Return back the
+		// Return the parent posts with updated dates

src/classes/class-se-blocks.php (1)

796-806: Consider validating the dynamically selected function exists.

While the switch statement covers all expected cases, it would be safer to verify the function exists before calling it.

 		// Based on the feed type, set the get_date_function
 		switch ( $attributes['feedType'] ?? 'default' ) {
 			case 'upcoming':
 				$get_date_function = 'se_event_get_future_dates';
 				break;
 			case 'past':
 				$get_date_function = 'se_event_get_past_dates';
 				break;
 			default:
 				$get_date_function = 'se_event_get_formatted_dates';
 				break;
 		}
+
+		// Ensure the function exists
+		if ( ! function_exists( $get_date_function ) ) {
+			$get_date_function = 'se_event_get_formatted_dates';
+		}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

src/classes/class-se-block-variations.php (3)

307-326: Monitor and optimize the performance of this complex subquery.

The nested JOINs and meta lookups could impact performance on large datasets.

Consider these optimizations:

• Add composite index on wp_postmeta(meta_key, meta_value) for the date lookups
• Implement caching of filtered parent IDs using transients for high-traffic feeds
• Monitor query execution time in production and adjust as needed

---

218-224: Implement filter cleanup to prevent affecting other queries.

The filters added here are never removed, which could unintentionally affect subsequent queries. This was flagged in previous reviews and remains unaddressed.

Consider implementing a cleanup mechanism:

// Store the filters that need cleanup
private $active_filters = [];

// In set_event_query_args, track filters
$this->active_filters[] = ['posts_where', [$this, 'filter_unique_parents_where'], 10];
add_filter('posts_where', [$this, 'filter_unique_parents_where'], 10, 2);

// Add a cleanup method
public function cleanup_filters() {
    foreach ($this->active_filters as $filter) {
        remove_filter($filter[0], $filter[1], $filter[2]);
    }
    $this->active_filters = [];
}

// Hook cleanup to appropriate action
add_action('loop_end', [$this, 'cleanup_filters']);

---

283-283: Apply SQL escaping for defense in depth.

While $meta_key is derived from controlled values, it's best practice to escape it.

-		$meta_key   = 'desc' === $feed_order ? 'se_event_date_end' : 'se_event_date_start';
+		$meta_key   = esc_sql( 'desc' === $feed_order ? 'se_event_date_end' : 'se_event_date_start' );

src/variations/query-loop-events/block.js (1)

110-129: Remove redundant case clause.

The case 'default': is unnecessary since the default: clause returns the same result.

Apply this diff to remove the redundant case:

-		case 'default':
		default:
			return [
				{ label: 'Oldest to Newest', value: 'asc' },
				{ label: 'Newest to Oldest', value: 'desc' },
			];

src/classes/class-se-block-variations.php (3)

121-121: Fix incomplete comment.

The comment appears to be cut off.

-		// Return back the
+		// Return the parent events instead of event dates

---

162-162: Remove trailing # character.

There's a stray # character at the end of the line.

-		$feed_order = $request->get_param( 'order' );#
+		$feed_order = $request->get_param( 'order' );

---

273-273: Remove commented debug code.

-		// adump( $query->query_vars['unique_parents'] );
-

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

src/classes/class-se-block-variations.php (3)

213-225: Remove filters after use to prevent side effects.

The filters are added but never removed, which can unintentionally affect other queries throughout the request lifecycle.

Consider implementing a cleanup mechanism or using a more targeted approach:

// add the arg to denote unique parents.
$args['unique_parents'] = true;
$args['feed_order']     = $feed_order; // Store feed order for use in the WHERE filter

// Ensure we only get the correct event date for each parent.
add_filter( 'posts_where', array( $this, 'filter_unique_parents_where' ), 10, 2 );

// Add a filter to modify the posts results.
add_filter( 'the_posts', array( $this, 'modify_event_posts' ), 10, 2 );

// Add a custom order by.
add_filter( 'posts_orderby', array( $this, 'fix_editor_sort_order' ), 10, 2 );

+// TODO: Remove these filters after the query is processed to prevent affecting other queries
+// Consider implementing a cleanup mechanism in the modify_event_posts method

---

281-281: Inconsistent case handling for feed order comparison.

Line 281 doesn't use strtolower() while line 313 does, creating inconsistency in how feed order is compared.

-$meta_key   = 'desc' === $feed_order ? 'se_event_date_end' : 'se_event_date_start';
+$meta_key   = 'desc' === strtolower( $feed_order ) ? 'se_event_date_end' : 'se_event_date_start';

---

304-329: Escape meta_key and optimize complex subquery.

The subquery logic is sound but has security and performance concerns.

Security: Escape the $meta_key variable:

-$meta_key   = 'desc' === strtolower( $feed_order ) ? 'se_event_date_end' : 'se_event_date_start';
+$meta_key   = esc_sql( 'desc' === strtolower( $feed_order ) ? 'se_event_date_end' : 'se_event_date_start' );

Performance: The complex subquery with multiple JOINs could be expensive on large datasets. Consider:

• Adding database indexes on meta_key and meta_value columns
• Implementing caching for the filtered parent IDs
• Monitoring query performance in production environments

#!/bin/bash
# Check for other uses of meta_key in SQL queries for consistency
rg -A 3 -B 3 "meta_key.*=.*\\\$" --type php

src/classes/class-se-block-variations.php (1)

107-149: Verify timezone handling and add error handling.

The method correctly transforms event date posts to their parent events with proper timezone conversion. However, consider adding error handling for cases where the parent post or meta data might not exist.

public function modify_event_posts( $posts, $query ) {
	// Check if this is our events query
	if ( ! isset( $query->query_vars['sub-type'] ) || self::QUERY_LOOP_EVENTS !== $query->query_vars['sub-type'] ) {
		return $posts;
	}

	// Return back the
	return array_map(
		function ( $post ) {
			$parent = get_post( $post->post_parent );
+			if ( ! $parent ) {
+				return $post; // Fallback to original post if parent not found
+			}

			// Get the start date from the event.
			$start_date_ts = get_post_meta( $post->ID, 'se_event_date_start', true );
+			if ( ! $start_date_ts ) {
+				return $parent; // Return parent without date modification if no start date
+			}

			// Get the event timezone.
			$timezone = get_post_meta( $parent->ID, 'se_event_timezone', true );
			// use the timezone or default to the site timezone.
			$timezone = $timezone ? $timezone : wp_timezone_string();

			// Get the date im this format 2025-07-01 13:14:09
			$start_date     = wp_date( 'Y-m-d H:i:s', $start_date_ts, new \DateTimeZone( $timezone ) );
			$start_date_gmt = wp_date( 'Y-m-d H:i:s', $start_date_ts, new \DateTimeZone( 'UTC' ) );

			// update the parent posts post date
			$parent->post_date         = $start_date;
			$parent->post_date_gmt     = $start_date_gmt;
			$parent->post_modified     = $start_date;
			$parent->post_modified_gmt = $start_date_gmt;
			$parent->event_date_id     = $post->ID;

			return $parent;
		},
		$posts
	);
}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

src/classes/class-se-event-dates.php (1)

59-59: Consider adding permission check for GET endpoint.

The GET endpoint currently allows anyone to fetch event dates. Consider checking if the event is published or if the user has appropriate capabilities.

src/classes/class-se-blocks.php (1)

988-1051: Eliminate code duplication between classes.

These static methods duplicate the functionality of instance methods in SE_Block_Variations. This violates the DRY principle and creates maintenance burden.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.

Learnt from: gin0115
PR: a8cteam51/simple-events#21
File: src/event-functions.php:544-547
Timestamp: 2025-07-07T09:19:18.986Z
Learning: The `se_event_get_calendar_link` function in `src/event-functions.php` contains legacy code, which explains why it may have redundant or suboptimal implementation patterns.

Learnt from: gin0115
PR: a8cteam51/simple-events#17
File: src/blocks/event-info/index.js:82-98
Timestamp: 2025-06-17T12:10:45.329Z
Learning: In src/blocks/event-info/index.js, when all event dates are in the past, the fallback logic intentionally takes the latest start date and latest end date independently (even from different events) to handle overlapping events correctly. This approach captures the full scope of recent event activity rather than constraining to a single event's date range.