fix: batch overlay render meshes

just did it for trace before, now it works for everything.
this relies on the mesh being passed by-reference. if it's not, then it will spam new meshes for each vertex after the batch count.... but it won't crash!

Author: ThisAMJ

src/Features/Demo/GhostRenderer.cpp

@@ -137,7 +137,7 @@ void GhostRenderer::UpdateAnimatedVerts() {
 }
 
 
-void GhostRenderer::Draw(MeshId mesh) {
+void GhostRenderer::Draw(MeshId &mesh) {
 	if (ghost == nullptr) return;
 
 	//update verts before drawing

src/Features/Demo/GhostRenderer.hpp

@@ -21,7 +21,7 @@ class GhostRenderer {
 public:
 	GhostRenderer();
 	void SetGhost(GhostEntity *ghost);
-	void Draw(MeshId mesh);
+	void Draw(MeshId &mesh);
 	void StartGesture(int id);
 	float GetHeight();
 };

src/Features/OverlayRender.cpp

@@ -143,22 +143,28 @@ MeshId OverlayRender::createMesh(RenderCallback solid, RenderCallback wireframe)
 	return id;
 }
 
-void OverlayRender::addTriangle(MeshId mesh, Vector a, Vector b, Vector c, bool cull_back) {
+void OverlayRender::addTriangle(MeshId &mesh, Vector a, Vector b, Vector c, bool cull_back) {
+	if (g_meshes[mesh].num_points_in_pos >= 8192) {
+		mesh = OverlayRender::createMesh(g_meshes[mesh].solid, g_meshes[mesh].wireframe);
+	}
 	auto &vs = g_meshes[mesh].tri_verts;
 	vs.insert(vs.end(), { a, b, c });
 	if (!cull_back) vs.insert(vs.end(), { a, c, b });
 	g_meshes[mesh].pos += (a + b + c) / 3.0;
 	g_meshes[mesh].num_points_in_pos += 1;
 }
 
-void OverlayRender::addLine(MeshId mesh, Vector a, Vector b) {
+void OverlayRender::addLine(MeshId &mesh, Vector a, Vector b) {
+	if (g_meshes[mesh].num_points_in_pos >= 8192) {
+		mesh = OverlayRender::createMesh(g_meshes[mesh].solid, g_meshes[mesh].wireframe);
+	}
 	auto &vs = g_meshes[mesh].line_verts;
 	vs.insert(vs.end(), { a, b });
 	g_meshes[mesh].pos += (a + b) / 2.0;
 	g_meshes[mesh].num_points_in_pos += 1;
 }
 
-void OverlayRender::addQuad(MeshId mesh, Vector a, Vector b, Vector c, Vector d, bool cull_back) {
+void OverlayRender::addQuad(MeshId &mesh, Vector a, Vector b, Vector c, Vector d, bool cull_back) {
 	OverlayRender::addTriangle(mesh, a, b, c, cull_back);
 	OverlayRender::addTriangle(mesh, a, c, d, cull_back);
 }

src/Features/OverlayRender.hpp

@@ -37,9 +37,9 @@ namespace OverlayRender {
 	MeshId createMesh(RenderCallback solid, RenderCallback wireframe);
 
 	// Primitives that can be drawn during a mesh
-	void addTriangle(MeshId mesh, Vector a, Vector b, Vector c, bool cull_back = false);
-	void addLine(MeshId mesh, Vector a, Vector b);
-	void addQuad(MeshId mesh, Vector a, Vector b, Vector c, Vector d, bool cull_back = false);
+	void addTriangle(MeshId &mesh, Vector a, Vector b, Vector c, bool cull_back = false);
+	void addLine(MeshId &mesh, Vector a, Vector b);
+	void addQuad(MeshId &mesh, Vector a, Vector b, Vector c, Vector d, bool cull_back = false);
 
 	enum class TextAlign {
 		BOTTOM,    // the bottom center of the text block

src/Features/PlayerTrace.cpp

@@ -56,21 +56,6 @@ Vector g_playerTraceTeleportLocation;
 int g_playerTraceTeleportSlot;
 bool g_playerTraceNeedsTeleport = false;
 
-enum MeshType {
-	GROUNDED = 0,
-	UNDER300,
-	AIRLOCKED,
-	MAX_TURN,
-	OVER300
-};
-static const Color mesh_colors[5] = {
-	{ 255, 0,   0   }, // red:    grounded
-	{ 255, 255, 255 }, // white:  speed < 300
-	{ 150, 75,  0   }, // brown:  speedlocked
-	{ 255, 220, 0   }, // yellow: can't turn further
-	{ 0,   255, 0   }  // green:  speed > 300
-};
-
 static int tickInternalToUser(int tick, const Trace &trace) {
 	if (tick == -1) return -1;
 	switch (sar_trace_draw_time.GetInt()) {
@@ -282,14 +267,11 @@ void PlayerTrace::DrawInWorld() const {
 			Vector closest_pos;
 			float closest_vel;
 
-			int mesh_size[5] = {0, 0, 0, 0, 0};
-			MeshId meshes[5] = {
-				OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[MeshType::GROUNDED ], draw_through_walls)),
-				OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[MeshType::UNDER300 ], draw_through_walls)),
-				OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[MeshType::AIRLOCKED], draw_through_walls)),
-				OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[MeshType::MAX_TURN ], draw_through_walls)),
-				OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[MeshType::OVER300  ], draw_through_walls))
-			};
+			MeshId mesh_airlocked = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant({ 150, 75,  0   }, draw_through_walls));
+			MeshId mesh_max_turn  = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant({ 255, 220, 0   }, draw_through_walls));
+			MeshId mesh_under300  = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant({ 255, 255, 255 }, draw_through_walls));
+			MeshId mesh_over300   = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant({ 0,   255, 0   }, draw_through_walls));
+			MeshId mesh_grounded  = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant({ 255, 0,   0   }, draw_through_walls));
 
 			Vector pos = trace.positions[slot][0];
 			float speed = trace.velocities[slot][0].Length2D();
@@ -348,21 +330,20 @@ void PlayerTrace::DrawInWorld() const {
 				// Don't draw a line when going through a portal or 0 length line
 				float pos_delta = (pos - new_pos).Length();
 				if (pos_delta < 127 && pos_delta > 0.001) {
+					// Colors:
+					// red: grounded
+					// brown: speedlocked
+					// yellow: can't turn further
+					// green: speed>300
 					Vector vel = trace.velocities[slot][i];
-					MeshType meshType = groundframes > 1 ? GROUNDED :
-					                    speed < 300      ? UNDER300 :
-					                    fabsf(vel.x) >= 150 && fabsf(vel.y) >= 150 ? AIRLOCKED :
-					                    fabsf(vel.x) >= 60  && fabsf(vel.y) >= 60  ? MAX_TURN :
-					                    OVER300;
-					MeshId mesh = meshes[meshType];
+					MeshId &mesh =
+						groundframes > 1 ? mesh_grounded :
+						speed < 300      ? mesh_under300 :
+						fabsf(vel.x) >= 150 && fabsf(vel.y) >= 150 ? mesh_airlocked :
+						fabsf(vel.x) >= 60  && fabsf(vel.y) >= 60  ? mesh_max_turn :
+						mesh_over300;
 
 					OverlayRender::addLine(mesh, pos, new_pos);
-
-					mesh_size[meshType]++;
-					if (mesh_size[meshType] >= 8192) { // batches of 8192 to avoid crash by overflowing the vertex buffer
-						meshes[meshType] = OverlayRender::createMesh(RenderCallback::none, RenderCallback::constant(mesh_colors[meshType], draw_through_walls));
-						mesh_size[meshType] = 0;
-					}
 				}
 				if (pos_delta > 0.001) pos = new_pos;
 			}