[functional] Move indexed variant of Stream.forEach to Stream,forEachIndexed

Author: aNNiMON

modules/main/src/main/java/com/annimon/ownlang/modules/functional/StreamValue.java

@@ -30,6 +30,7 @@ private void init() {
 
         set("reduce", wrapTerminal(new functional_reduce()));
         set("forEach", wrapTerminal(new functional_forEach()));
+        set("forEachIndexed", wrapTerminal(new functional_forEachIndexed()));
         set("toArray", args -> container);
         set("joining", container::joinToString);
         set("count", args -> NumberValue.of(container.size()));

modules/main/src/main/java/com/annimon/ownlang/modules/functional/functional_forEach.java

@@ -15,17 +15,16 @@ public Value execute(Value[] args) {
     }
 
     static Value forEach(Value container, Function consumer) {
-        final int argsCount = consumer.getArgsCount();
         return switch (container.type()) {
-            case Types.STRING -> forEachString((StringValue) container, argsCount, consumer);
-            case Types.ARRAY -> forEachArray((ArrayValue) container, argsCount, consumer);
+            case Types.STRING -> forEachString((StringValue) container, consumer);
+            case Types.ARRAY -> forEachArray((ArrayValue) container, consumer);
             case Types.MAP -> forEachMap((MapValue) container, consumer);
             default -> throw new TypeException("Cannot iterate " + Types.typeToString(container.type()));
         };
     }
 
-    static StringValue forEachString(StringValue string, int argsCount, Function consumer) {
-        if (argsCount == 2) {
+    static StringValue forEachString(StringValue string, Function consumer) {
+        if (consumer.getArgsCount() == 2) {
             for (char ch : string.asString().toCharArray()) {
                 consumer.execute(new StringValue(String.valueOf(ch)), NumberValue.of(ch));
             }
@@ -37,16 +36,9 @@ static StringValue forEachString(StringValue string, int argsCount, Function con
         return string;
     }
 
-    static ArrayValue forEachArray(ArrayValue array, int argsCount, Function consumer) {
-        if (argsCount == 2) {
-            int index = 0;
-            for (Value element : array) {
-                consumer.execute(element, NumberValue.of(index++));
-            }
-        } else {
-            for (Value element : array) {
-                consumer.execute(element);
-            }
+    static ArrayValue forEachArray(ArrayValue array, Function consumer) {
+        for (Value element : array) {
+            consumer.execute(element);
         }
         return array;
     }

modules/main/src/main/java/com/annimon/ownlang/modules/functional/functional_forEachIndexed.java

@@ -0,0 +1,31 @@
+package com.annimon.ownlang.modules.functional;
+
+import com.annimon.ownlang.exceptions.TypeException;
+import com.annimon.ownlang.lib.*;
+
+public final class functional_forEachIndexed implements Function {
+
+    @Override
+    public Value execute(Value[] args) {
+        Arguments.check(2, args.length);
+        final Value container = args[0];
+        final Function consumer = ValueUtils.consumeFunction(args[1], 1);
+        return forEachIndexed(container, consumer);
+    }
+
+    static Value forEachIndexed(Value container, Function consumer) {
+        if (container.type() == Types.ARRAY) {
+            return forEachIndexedArray((ArrayValue) container, consumer);
+        }
+        // Only used in Streams -> no Map implementation
+        throw new TypeException("Cannot iterate " + Types.typeToString(container.type()));
+    }
+
+    static ArrayValue forEachIndexedArray(ArrayValue array, Function consumer) {
+        int index = 0;
+        for (Value element : array) {
+            consumer.execute(element, NumberValue.of(index++));
+        }
+        return array;
+    }
+}

ownlang-parser/src/test/resources/modules/functional/foreach.own

@@ -1,21 +1,13 @@
 use std, functional
 
-def testArrayForeach1Arg() {
+def testArrayForeachArg() {
   sum = 0
   foreach([1, 2, 3], def(v) {
     sum += v
   })
   assertEquals(6, sum)
 }
 
-def testArrayForeach2Args() {
-  sum = 0
-  foreach([1, 2, 3], def(v, index) {
-    sum += v * index
-  })
-  assertEquals(1 * 0 + 2 * 1 + 3 * 2, sum)
-}
-
 def testStringForeach1Arg() {
   sum = 0
   foreach("abcd", def(s) {

ownlang-parser/src/test/resources/modules/functional/stream.own

@@ -79,6 +79,28 @@ def testSorted() {
   assertEquals([-2,3,4,-5,6,6,-8], stream(data).sorted(def(a,b) = abs(a) - abs(b)).toArray())
 }
 
+def testForEachArrayIndexed() {
+  data = [1, 2, 3]
+  sum = 0
+  stream(data)
+    .forEachIndexed(def(v, index) {
+      sum += (v * index)
+    })
+  assertEquals(1 * 0 + 2 * 1 + 3 * 2, sum)
+}
+
+def testForEachMapIndexed() {
+  data = {"a": "1", "b": 2}
+  result = ""
+  stream(data)
+    .sorted()
+    .forEachIndexed(def(entry, index) {
+      extract(key, value) = entry
+      result += "" + key + value + index
+    })
+  assertEquals("a10b21", result)
+}
+
 def reverse(container) {
   size = length(container)
   result = newarray(size)