minor symfony#13829 [Process] prefix should not be escaped (pyrech)

fabpot · fabpot · commit 0b1f17206c94 · 2015-03-27T16:19:08.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- [Process] prefix should not be escaped | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#12826 | License | MIT | Doc PR | - The phpdoc of `ProcessBuilder#setPrefix` says: ``` Adds an unescaped prefix to the command string. ``` But in the current implementation, the prefix is merged with arguments array and then is escaped which seems wrong. Commits ------- 67f65c9 Update phpdoc of ProcessBuilder#setPrefix()
diff --git a/src/Symfony/Component/Process/ProcessBuilder.php b/src/Symfony/Component/Process/ProcessBuilder.php
@@ -67,7 +67,7 @@ public function add($argument)
     }
 
     /**
-     * Adds an unescaped prefix to the command string.
+     * Adds a prefix to the command string.
      *
      * The prefix is preserved when resetting arguments.
      *

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function add($argument)`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`/**`
`70`		`- * Adds an unescaped prefix to the command string.`
	`70`	`+ * Adds a prefix to the command string.`
`71`	`71`	`*`
`72`	`72`	`* The prefix is preserved when resetting arguments.`
`73`	`73`	`*`