Skip to content

Commit 15551f2

Browse files
committed
minor symfony#12840 [2.3] More cs fixes (GrahamCampbell)
This PR was squashed before being merged into the 2.3 branch (closes symfony#12840). Discussion ---------- [2.3] More cs fixes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A ##### This pull request fixes some more cs issues in symfony 2.3. I should be done with cs fixes to the 2.3 branch now. Sorry I missed these in my last pull. Commits ------- b034b08 [2.3] More cs fixes
2 parents cef9972 + b034b08 commit 15551f2

File tree

8 files changed

+26
-27
lines changed

8 files changed

+26
-27
lines changed

src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ public function testHandleClosureValidationGroups()
361361
$object = $this->getMock('\stdClass');
362362
$options = array('validation_groups' => function (FormInterface $form) {
363363
return array('group1', 'group2');
364-
},);
364+
});
365365
$form = $this->getBuilder('name', '\stdClass', $options)
366366
->setData($object)
367367
->getForm();

src/Symfony/Component/Intl/ResourceBundle/CurrencyBundle.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function getCurrencySymbol($currency, $displayLocale = null)
5252
try {
5353
return $this->getSymbol($currency, $displayLocale);
5454
} catch (MissingResourceException $e) {
55-
return null;
55+
return;
5656
}
5757
}
5858

@@ -64,7 +64,7 @@ public function getCurrencyName($currency, $displayLocale = null)
6464
try {
6565
return $this->getName($currency, $displayLocale);
6666
} catch (MissingResourceException $e) {
67-
return null;
67+
return;
6868
}
6969
}
7070

@@ -76,7 +76,7 @@ public function getCurrencyNames($displayLocale = null)
7676
try {
7777
return $this->getNames($displayLocale);
7878
} catch (MissingResourceException $e) {
79-
return null;
79+
return;
8080
}
8181
}
8282

@@ -88,7 +88,7 @@ public function getFractionDigits($currency)
8888
try {
8989
return parent::getFractionDigits($currency);
9090
} catch (MissingResourceException $e) {
91-
return null;
91+
return;
9292
}
9393
}
9494

@@ -100,7 +100,7 @@ public function getRoundingIncrement($currency)
100100
try {
101101
return parent::getRoundingIncrement($currency);
102102
} catch (MissingResourceException $e) {
103-
return null;
103+
return;
104104
}
105105
}
106106

@@ -112,7 +112,7 @@ public function getLocales()
112112
try {
113113
return $this->localeProvider->getLocales();
114114
} catch (MissingResourceException $e) {
115-
return null;
115+
return;
116116
}
117117
}
118118
}

src/Symfony/Component/Intl/ResourceBundle/LanguageBundle.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function getLanguageName($language, $region = null, $displayLocale = null
6868
try {
6969
return $this->getName($language, $displayLocale);
7070
} catch (MissingResourceException $e) {
71-
return null;
71+
return;
7272
}
7373
}
7474

@@ -80,7 +80,7 @@ public function getLanguageNames($displayLocale = null)
8080
try {
8181
return $this->getNames($displayLocale);
8282
} catch (MissingResourceException $e) {
83-
return null;
83+
return;
8484
}
8585
}
8686

@@ -92,7 +92,7 @@ public function getScriptName($script, $language = null, $displayLocale = null)
9292
try {
9393
return $this->scriptProvider->getName($script, $displayLocale);
9494
} catch (MissingResourceException $e) {
95-
return null;
95+
return;
9696
}
9797
}
9898

@@ -104,7 +104,7 @@ public function getScriptNames($displayLocale = null)
104104
try {
105105
return $this->scriptProvider->getNames($displayLocale);
106106
} catch (MissingResourceException $e) {
107-
return null;
107+
return;
108108
}
109109
}
110110

@@ -116,7 +116,7 @@ public function getLocales()
116116
try {
117117
return $this->localeProvider->getLocales();
118118
} catch (MissingResourceException $e) {
119-
return null;
119+
return;
120120
}
121121
}
122122
}

src/Symfony/Component/Intl/ResourceBundle/LocaleBundle.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function getLocales()
3131
try {
3232
return parent::getLocales();
3333
} catch (MissingResourceException $e) {
34-
return null;
34+
return;
3535
}
3636
}
3737

@@ -43,7 +43,7 @@ public function getLocaleName($locale, $displayLocale = null)
4343
try {
4444
return $this->getName($locale, $displayLocale);
4545
} catch (MissingResourceException $e) {
46-
return null;
46+
return;
4747
}
4848
}
4949

@@ -55,7 +55,7 @@ public function getLocaleNames($displayLocale = null)
5555
try {
5656
return $this->getNames($displayLocale);
5757
} catch (MissingResourceException $e) {
58-
return null;
58+
return;
5959
}
6060
}
6161
}

src/Symfony/Component/Intl/ResourceBundle/RegionBundle.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function getCountryName($country, $displayLocale = null)
5252
try {
5353
return $this->getName($country, $displayLocale);
5454
} catch (MissingResourceException $e) {
55-
return null;
55+
return;
5656
}
5757
}
5858

@@ -64,7 +64,7 @@ public function getCountryNames($displayLocale = null)
6464
try {
6565
return $this->getNames($displayLocale);
6666
} catch (MissingResourceException $e) {
67-
return null;
67+
return;
6868
}
6969
}
7070

@@ -76,7 +76,7 @@ public function getLocales()
7676
try {
7777
return $this->localeProvider->getLocales();
7878
} catch (MissingResourceException $e) {
79-
return null;
79+
return;
8080
}
8181
}
8282
}

src/Symfony/Component/Intl/Resources/bin/update-data.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@
7676
? $urlVersion
7777
: $maxVersion;
7878

79-
8079
echo " $urlVersion\n";
8180
}
8281

src/Symfony/Component/Stopwatch/Tests/StopwatchTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ public function testIsNotStartedEvent()
5656

5757
$events = new \ReflectionProperty('Symfony\Component\Stopwatch\Section', 'events');
5858
$events->setAccessible(true);
59-
$events->setValue(
60-
end($section),
61-
array(
62-
'foo' => $this->getMockBuilder('Symfony\Component\Stopwatch\StopwatchEvent')
63-
->setConstructorArgs(array(microtime(true) * 1000))
64-
->getMock())
65-
);
59+
60+
$stopwatchMockEvent = $this->getMockBuilder('Symfony\Component\Stopwatch\StopwatchEvent')
61+
->setConstructorArgs(array(microtime(true) * 1000))
62+
->getMock()
63+
;
64+
65+
$events->setValue(end($section), array('foo' => $stopwatchMockEvent));
6666

6767
$this->assertFalse($stopwatch->isStarted('foo'));
6868
}

src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public function testValidChoiceCallbackClosure()
8989
{
9090
$constraint = new Choice(array('callback' => function () {
9191
return array('foo', 'bar');
92-
}, ));
92+
}));
9393

9494
$this->validator->validate('bar', $constraint);
9595

0 commit comments

Comments
 (0)