Skip to content

Commit 1cc1d8d

Browse files
committed
minor symfony#13716 [Console] make an assertion more precise in testGetOptionDefaults (nanocom)
This PR was merged into the 2.3 branch. Discussion ---------- [Console] make an assertion more precise in testGetOptionDefaults | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | License | MIT Minor fix, the default values expected in the test were not exactly the same as what is actually returned. Commits ------- 06a42e1 [Console] fix assertion in testGetOptionDefaults
2 parents 31bfc95 + 06a42e1 commit 1cc1d8d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Symfony/Component/Console/Tests/Input/InputDefinitionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,15 +341,15 @@ public function testGetOptionDefaults()
341341
new InputOption('foo7', null, InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY, '', array(1, 2)),
342342
));
343343
$defaults = array(
344-
'foo1' => null,
344+
'foo1' => false,
345345
'foo2' => null,
346346
'foo3' => 'default',
347347
'foo4' => null,
348348
'foo5' => 'default',
349349
'foo6' => array(),
350350
'foo7' => array(1, 2),
351351
);
352-
$this->assertEquals($defaults, $definition->getOptionDefaults(), '->getOptionDefaults() returns the default values for all options');
352+
$this->assertSame($defaults, $definition->getOptionDefaults(), '->getOptionDefaults() returns the default values for all options');
353353
}
354354

355355
public function testGetSynopsis()

0 commit comments

Comments
 (0)