[2.3] [HttpFoundation] [MimeTypeGuesser]

phansys · phansys · commit 1e4a8d55cbcb · 2015-01-24T20:09:16.000-03:00
Updated exception message in MimeTypeGuesser when no guessers available (issue symfony#12857). | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#12857 | License | MIT | Doc PR | none
diff --git a/src/Symfony/Component/HttpFoundation/File/MimeType/MimeTypeGuesser.php b/src/Symfony/Component/HttpFoundation/File/MimeType/MimeTypeGuesser.php
@@ -120,7 +120,11 @@ public function guess($path)
         }
 
         if (!$this->guessers) {
-            throw new \LogicException('Unable to guess the mime type as no guessers are available (Did you enable the php_fileinfo extension?)');
+            $msg = 'Unable to guess the mime type as no guessers are available';
+            if (!FileinfoMimeTypeGuesser::isSupported()) {
+                $msg .= ' (Did you enable the php_fileinfo extension?)';
+            }
+            throw new \LogicException($msg);
         }
 
         foreach ($this->guessers as $guesser) {

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,11 @@ public function guess($path)`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`if (!$this->guessers) {`
`123`		`- throw new \LogicException('Unable to guess the mime type as no guessers are available (Did you enable the php_fileinfo extension?)');`
	`123`	`+ $msg = 'Unable to guess the mime type as no guessers are available';`
	`124`	`+ if (!FileinfoMimeTypeGuesser::isSupported()) {`
	`125`	`+ $msg .= ' (Did you enable the php_fileinfo extension?)';`
	`126`	`+ }`
	`127`	`+ throw new \LogicException($msg);`
`124`	`128`	`}`
`125`	`129`
`126`	`130`	`foreach ($this->guessers as $guesser) {`