bug symfony#24285 [DI] Dont use JSON_BIGINT_AS_STRING (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 2e608f791c15 · 2017-09-22T12:00:22.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Dont use JSON_BIGINT_AS_STRING | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ye | Fixed tickets | - | License | MIT | Doc PR | - Because it's incompatible with stringy keys, for unknown reason, see https://3v4l.org/IHSqv Commits ------- 830f286 [DI] Dont use JSON_BIGINT_AS_STRING
diff --git a/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php b/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php
@@ -119,7 +119,7 @@ public function getEnv($prefix, $name, \Closure $getEnv)
         }
 
         if ('json' === $prefix) {
-            $env = json_decode($env, true, JSON_BIGINT_AS_STRING);
+            $env = json_decode($env, true);
 
             if (JSON_ERROR_NONE !== json_last_error()) {
                 throw new RuntimeException(sprintf('Invalid JSON in env var "%s": '.json_last_error_msg(), $name));

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public function getEnv($prefix, $name, \Closure $getEnv)`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`if ('json' === $prefix) {`
`122`		`- $env = json_decode($env, true, JSON_BIGINT_AS_STRING);`
	`122`	`+ $env = json_decode($env, true);`
`123`	`123`
`124`	`124`	`if (JSON_ERROR_NONE !== json_last_error()) {`
`125`	`125`	`throw new RuntimeException(sprintf('Invalid JSON in env var "%s": '.json_last_error_msg(), $name));`