Fix errors not rethrown even if not handled by console.error listeners

Author: chalasr

src/Symfony/Component/Console/Application.php

@@ -129,7 +129,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null
         }
 
         if (null !== $e) {
-            if (!$this->catchExceptions) {
+            if (!$this->catchExceptions || !$x instanceof \Exception) {
                 throw $x;
             }
 

src/Symfony/Component/Console/Tests/ApplicationTest.php

@@ -1170,6 +1170,29 @@ protected function getDispatcher($skipCommand = false)
 
         return $dispatcher;
     }
+
+    /**
+     * @requires PHP 7
+     */
+    public function testErrorIsRethrownIfNotHandledByConsoleErrorEventWithCatchingEnabled()
+    {
+        $application = new Application();
+        $application->setAutoExit(false);
+        $application->setDispatcher(new EventDispatcher());
+
+        $application->register('dym')->setCode(function (InputInterface $input, OutputInterface $output) {
+            new \UnknownClass();
+        });
+
+        $tester = new ApplicationTester($application);
+
+        try {
+            $tester->run(array('command' => 'dym'));
+            $this->fail('->run() should rethrow PHP errors if not handled via ConsoleErrorEvent.');
+        } catch (\Error $e) {
+            $this->assertSame($e->getMessage(), 'Class \'UnknownClass\' not found');
+        }
+    }
 }
 
 class CustomApplication extends Application