bug symfony#25121 [FrameworkBundle] Fix AssetsInstallCommand (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 7a70077bec4a · 2017-11-23T12:30:09.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix AssetsInstallCommand | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#25106 | License | MIT | Doc PR | - Fixes a deprecation notice on 3.4, and a failure on 4.0. Commits ------- a84efa7 [FrameworkBundle] Fix AssetsInstallCommand
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -262,6 +262,7 @@ private function absoluteSymlinkWithFallback($originDir, $targetDir)
     private function symlink($originDir, $targetDir, $relative = false)
     {
         if ($relative) {
+            $this->filesystem->mkdir(dirname($targetDir));
             $originDir = $this->filesystem->makePathRelative($originDir, realpath(dirname($targetDir)));
         }
         $this->filesystem->symlink($originDir, $targetDir);

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,7 @@ private function absoluteSymlinkWithFallback($originDir, $targetDir)`
`262`	`262`	`private function symlink($originDir, $targetDir, $relative = false)`
`263`	`263`	`{`
`264`	`264`	`if ($relative) {`
	`265`	`+ $this->filesystem->mkdir(dirname($targetDir));`
`265`	`266`	`$originDir = $this->filesystem->makePathRelative($originDir, realpath(dirname($targetDir)));`
`266`	`267`	`}`
`267`	`268`	`$this->filesystem->symlink($originDir, $targetDir);`