bug symfony#16053 [Console] use PHP_OS instead of php_uname('s') (xabbuh)

fabpot · fabpot · commit 8879a5fa9a20 · 2015-10-02T14:47:06.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [Console] use PHP_OS instead of php_uname('s') | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#15058 | License | MIT | Doc PR | The php_uname() function may be disabled for security reasons. Commits ------- 40e0dc8 use PHP_OS instead of php_uname('s')
diff --git a/src/Symfony/Component/Console/Output/ConsoleOutput.php b/src/Symfony/Component/Console/Output/ConsoleOutput.php
@@ -125,7 +125,7 @@ protected function hasStderrSupport()
      */
     private function isRunningOS400()
     {
-        return 'OS400' === php_uname('s');
+        return 'OS400' === PHP_OS;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ protected function hasStderrSupport()`
`125`	`125`	`*/`
`126`	`126`	`private function isRunningOS400()`
`127`	`127`	`{`
`128`		`- return 'OS400' === php_uname('s');`
	`128`	`+ return 'OS400' === PHP_OS;`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`/**`