bug symfony#25337 Remove Exclusive Lock That Breaks NFS Caching (brianfreytag)

nicolas-grekas · nicolas-grekas · commit 931fe35e4dd0 · 2017-12-06T11:09:02.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- Remove Exclusive Lock That Breaks NFS Caching | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#25336 | License | MIT | Doc PR | n/a symfony#24960 introduced an issue with NFS mounts that do not support exclusive locks. This reverts that change. FYI @kalessil Commits ------- a7ac100 Remove LOCK_EX That Breaks Cache Usage on NFS
diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -423,7 +423,7 @@ public function setClassCache(array $classes)
      */
     public function setAnnotatedClassCache(array $annotatedClasses)
     {
-        file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)), LOCK_EX);
+        file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ public function setClassCache(array $classes)`
`423`	`423`	`*/`
`424`	`424`	`public function setAnnotatedClassCache(array $annotatedClasses)`
`425`	`425`	`{`
`426`		`- file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)), LOCK_EX);`
	`426`	`+ file_put_contents(($this->warmupDir ?: $this->getCacheDir()).'/annotations.map', sprintf('<?php return %s;', var_export($annotatedClasses, true)));`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`/**`