bug symfony#13997 [2.3+][Form][DoctrineBridge] Improved loading of entities and documents (guilhermeblanco)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3+][Form][DoctrineBridge] Improved loading of entities and documents

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#13961
| License       | MIT

Commits
-------

529d99c Fixed MongoODM entity loader. Improved loading behavior of entities and documents by reusing entity loader.

Author: fabpot

src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php

@@ -218,10 +218,8 @@ public function getChoicesForValues(array $values)
         if (!$this->loaded) {
             // Optimize performance in case we have an entity loader and
             // a single-field identifier
-            if ($this->idAsValue) {
-                $unorderedEntities = $this->entityLoader
-                    ? $this->entityLoader->getEntitiesByIds($this->idField, $values)
-                    : $this->em->getRepository($this->class)->findBy(array($this->idField => $values));
+            if ($this->idAsValue && $this->entityLoader) {
+                $unorderedEntities = $this->entityLoader->getEntitiesByIds($this->idField, $values);
                 $entitiesByValue = array();
                 $entities = array();
 

src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php

@@ -66,9 +66,11 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
         $type = $this;
 
         $loader = function (Options $options) use ($type) {
-            if (null !== $options['query_builder']) {
-                return $type->getLoader($options['em'], $options['query_builder'], $options['class']);
-            }
+            $queryBuilder = (null !== $options['query_builder'])
+                ? $options['query_builder']
+                : $options['em']->getRepository($options['class'])->createQueryBuilder('e');
+
+            return $type->getLoader($options['em'], $queryBuilder, $options['class']);
         };
 
         $choiceList = function (Options $options) use (&$choiceListCache, $propertyAccessor) {