Skip to content

Commit 9fcad38

Browse files
committed
minor symfony#15187 Enhance hhvm test skip message (nicolas-grekas)
This PR was merged into the 2.3 branch. Discussion ---------- Enhance hhvm test skip message | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Reading our blog about hhvm (http://symfony.com/blog/symfony-2-3-achieves-100-hhvm-compatibility) I'd like to improve the only single test skip in our code base that exists for hhvm. HHVM does not trigger strict notices. This is a missing feature of the HHVM parser (facebook/hhvm#5583). But this does not affect in any way the behavior of any PHP app. Strict notices are only for the dev stage. There is some FUD-friendliness in the article and in the comments (no offence @javiereguiluz ☮): 100% hhvm compat is 100% honest. We did not skip any single tests because of errors, issues nor bugs. And the single missing "feature" of hhvm is this one: strict notices. Kudos to hhvm for what they did: parity is close enough so that the delta can be handled in exactly the same way as we handle deltas between PHP versions. Commits ------- 5f4015c Enhance hhvm test skip message
2 parents 7c36f0b + 5f4015c commit 9fcad38

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ protected function tearDown()
4040
public function testCompileTimeError()
4141
{
4242
if (defined('HHVM_VERSION')) {
43-
$this->markTestSkipped('HHVM behaves differently in this test case.');
43+
$this->markTestSkipped('HHVM does not trigger strict notices.');
4444
}
4545

4646
// the ContextErrorException must not be loaded to test the workaround

0 commit comments

Comments
 (0)