[VarDumper] HtmlDumper: fix collapsing nodes with depth <= maxDepth

ogizanagi · ogizanagi · commit a1863c3b7c29 · 2017-10-29T21:21:57.000+01:00
diff --git a/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php b/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
@@ -383,8 +383,9 @@ function xpathString(str) {
                 x += elt.parentNode.getAttribute('data-depth')/1;
             }
             elt.setAttribute('data-depth', x);
-            if (elt.className ? 'sf-dump-expanded' !== elt.className : (x > options.maxDepth)) {
-                elt.className = 'sf-dump-expanded';
+            var className = elt.className;
+            elt.className = 'sf-dump-expanded';
+            if (className ? 'sf-dump-expanded' !== className : (x > options.maxDepth)) {
                 toggle(a);
             }
         } else if (/\bsf-dump-ref\b/.test(elt.className) && (a = elt.getAttribute('href'))) {

Original file line number	Diff line number	Diff line change
`@@ -383,8 +383,9 @@ function xpathString(str) {`
`383`	`383`	`x += elt.parentNode.getAttribute('data-depth')/1;`
`384`	`384`	`}`
`385`	`385`	`elt.setAttribute('data-depth', x);`
`386`		`- if (elt.className ? 'sf-dump-expanded' !== elt.className : (x > options.maxDepth)) {`
`387`		`- elt.className = 'sf-dump-expanded';`
	`386`	`+ var className = elt.className;`
	`387`	`+ elt.className = 'sf-dump-expanded';`
	`388`	`+ if (className ? 'sf-dump-expanded' !== className : (x > options.maxDepth)) {`
`388`	`389`	`toggle(a);`
`389`	`390`	`}`
`390`	`391`	`} else if (/\bsf-dump-ref\b/.test(elt.className) && (a = elt.getAttribute('href'))) {`