Skip to content

Commit b327a7c

Browse files
committed
Merge branch '3.3' into 3.4
* 3.3: Fixing a bug where non-existent classes would cause issues [SecurityBundle] hotfix: update phpdocs on logout url [FrameworkBundle] Do not load property_access.xml if the component isn't installed Fixed a few spelling mistakes in Luxembourgish translation
2 parents 856f21a + 7031b61 commit b327a7c

File tree

4 files changed

+34
-15
lines changed

4 files changed

+34
-15
lines changed

src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,18 @@ public function filterToServiceTypes($serviceId)
241241
return false;
242242
}
243243

244-
// see if the class exists (only need to trigger autoload once)
245-
return class_exists($serviceId) || interface_exists($serviceId, false);
244+
// if the id has a \, assume it is a class
245+
if (false !== strpos($serviceId, '\\')) {
246+
return true;
247+
}
248+
249+
try {
250+
$r = new \ReflectionClass($serviceId);
251+
252+
return true;
253+
} catch (\ReflectionException $e) {
254+
// the service id is not a valid class/interface
255+
return false;
256+
}
246257
}
247258
}

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,6 @@ public function load(array $configs, ContainerBuilder $container)
159159
}
160160
}
161161

162-
// Property access is used by both the Form and the Validator component
163-
$loader->load('property_access.xml');
164-
165-
$container->getDefinition('property_accessor')->setPrivate(true);
166-
167162
// Load Cache configuration first as it is used by other components
168163
$loader->load('cache.xml');
169164

@@ -287,7 +282,7 @@ public function load(array $configs, ContainerBuilder $container)
287282
$this->registerDebugConfiguration($config['php_errors'], $container, $loader);
288283
$this->registerRouterConfiguration($config['router'], $container, $loader);
289284
$this->registerAnnotationsConfiguration($config['annotations'], $container, $loader);
290-
$this->registerPropertyAccessConfiguration($config['property_access'], $container);
285+
$this->registerPropertyAccessConfiguration($config['property_access'], $container, $loader);
291286

292287
if ($this->isConfigEnabled($container, $config['serializer'])) {
293288
$this->registerSerializerConfiguration($config['serializer'], $container, $loader);
@@ -1377,8 +1372,16 @@ private function registerAnnotationsConfiguration(array $config, ContainerBuilde
13771372
}
13781373
}
13791374

1380-
private function registerPropertyAccessConfiguration(array $config, ContainerBuilder $container)
1375+
private function registerPropertyAccessConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
13811376
{
1377+
if (!class_exists('Symfony\Component\PropertyAccess\PropertyAccessor')) {
1378+
return;
1379+
}
1380+
1381+
$loader->load('property_access.xml');
1382+
1383+
$container->getDefinition('property_accessor')->setPrivate(true);
1384+
13821385
$container
13831386
->getDefinition('property_accessor')
13841387
->replaceArgument(0, $config['magic_call'])
@@ -1416,6 +1419,11 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
14161419

14171420
$chainLoader = $container->getDefinition('serializer.mapping.chain_loader');
14181421

1422+
if (!class_exists('Symfony\Component\PropertyAccess\PropertyAccessor')) {
1423+
$container->removeAlias('serializer.property_accessor');
1424+
$container->removeDefinition('serializer.normalizer.object');
1425+
}
1426+
14191427
$serializerLoaders = array();
14201428
if (isset($config['enable_annotations']) && $config['enable_annotations']) {
14211429
if (!$this->annotationsConfigEnabled) {

src/Symfony/Bundle/SecurityBundle/DataCollector/SecurityDataCollector.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,9 @@ public function getToken()
305305
}
306306

307307
/**
308-
* Get the provider key (i.e. the name of the active firewall).
308+
* Get the logout URL.
309309
*
310-
* @return string The provider key
310+
* @return string The logout URL
311311
*/
312312
public function getLogoutUrl()
313313
{

src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140
</trans-unit>
141141
<trans-unit id="38">
142142
<source>This value is not a valid language.</source>
143-
<target>Dëse Wäert aentsprécht kenger gëlteger Sprooch.</target>
143+
<target>Dëse Wäert entsprécht kenger gëlteger Sprooch.</target>
144144
</trans-unit>
145145
<trans-unit id="39">
146146
<source>This value is not a valid locale.</source>
@@ -180,7 +180,7 @@
180180
</trans-unit>
181181
<trans-unit id="48">
182182
<source>This value should have exactly {{ limit }} character.|This value should have exactly {{ limit }} characters.</source>
183-
<target>Dëse Wäert sollt exactly {{ limit }} Buschtaf hunn.|Dëse Wäert sollt exakt {{ limit }} Buschtawen hunn.</target>
183+
<target>Dëse Wäert sollt exakt {{ limit }} Buschtaf hunn.|Dëse Wäert sollt exakt {{ limit }} Buschtawen hunn.</target>
184184
</trans-unit>
185185
<trans-unit id="49">
186186
<source>The file was only partially uploaded.</source>
@@ -192,7 +192,7 @@
192192
</trans-unit>
193193
<trans-unit id="51">
194194
<source>No temporary folder was configured in php.ini.</source>
195-
<target>Et gouf keen temporären Dossier an der php.ini konfiguréiert.</target>
195+
<target>Et gouf keen temporären Dossier an der php.ini konfiguréiert oder den temporären Dossier existéiert net.</target>
196196
</trans-unit>
197197
<trans-unit id="52">
198198
<source>Cannot write temporary file to disk.</source>
@@ -304,7 +304,7 @@
304304
</trans-unit>
305305
<trans-unit id="79">
306306
<source>The host could not be resolved.</source>
307-
<target>Den Domain-Numm konnt net opgeléist ginn.</target>
307+
<target>Den Host-Numm konnt net opgeléist ginn.</target>
308308
</trans-unit>
309309
<trans-unit id="80">
310310
<source>This value does not match the expected {{ charset }} charset.</source>

0 commit comments

Comments
 (0)