Skip to content

Commit d512654

Browse files
committed
Test that named arguments are prioritized over typehinted
1 parent bf7eeef commit d512654

File tree

3 files changed

+36
-0
lines changed

3 files changed

+36
-0
lines changed

src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
3333
use Symfony\Component\DependencyInjection\Loader\ClosureLoader;
3434
use Symfony\Component\DependencyInjection\Reference;
35+
use Symfony\Component\DependencyInjection\Tests\Fixtures\SimilarArgumentsDummy;
3536
use Symfony\Component\DependencyInjection\TypedReference;
3637
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
3738
use Symfony\Component\DependencyInjection\ParameterBag\EnvPlaceholderParameterBag;
@@ -1270,6 +1271,30 @@ public function testParameterWithMixedCase()
12701271

12711272
$this->assertSame('bar', $container->get('foo')->foo);
12721273
}
1274+
1275+
public function testArgumentsHaveHigherPriorityThanBindings()
1276+
{
1277+
$container = new ContainerBuilder();
1278+
$container->register('class.via.bindings', CaseSensitiveClass::class)->setArguments(array(
1279+
'via-bindings',
1280+
));
1281+
$container->register('class.via.argument', CaseSensitiveClass::class)->setArguments(array(
1282+
'via-argument',
1283+
));
1284+
$container->register('foo', SimilarArgumentsDummy::class)->setPublic(true)->setBindings(array(
1285+
CaseSensitiveClass::class => new Reference('class.via.bindings'),
1286+
'$token' => '1234',
1287+
))->setArguments(array(
1288+
'$class1' => new Reference('class.via.argument'),
1289+
));
1290+
1291+
$this->assertSame(array('service_container', 'class.via.bindings', 'class.via.argument', 'foo', 'Psr\Container\ContainerInterface', 'Symfony\Component\DependencyInjection\ContainerInterface'), $container->getServiceIds());
1292+
1293+
$container->compile();
1294+
1295+
$this->assertSame('via-argument', $container->get('foo')->class1->identifier);
1296+
$this->assertSame('via-bindings', $container->get('foo')->class2->identifier);
1297+
}
12731298
}
12741299

12751300
class FooClass

src/Symfony/Component/DependencyInjection/Tests/Fixtures/CaseSensitiveClass.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,10 @@
1313

1414
class CaseSensitiveClass
1515
{
16+
public $identifier;
17+
18+
public function __construct($identifier = null)
19+
{
20+
$this->identifier = $identifier;
21+
}
1622
}

src/Symfony/Component/DependencyInjection/Tests/Fixtures/SimilarArgumentsDummy.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@
1313

1414
class SimilarArgumentsDummy
1515
{
16+
public $class1;
17+
public $class2;
18+
1619
public function __construct(CaseSensitiveClass $class1, string $token, CaseSensitiveClass $class2)
1720
{
21+
$this->class1 = $class1;
22+
$this->class2 = $class2;
1823
}
1924
}

0 commit comments

Comments
 (0)