bug symfony#13365 [HttpFoundation] Make use of isEmpty() method (xelaris)

fabpot · fabpot · commit de48c2ed5d0b · 2015-01-12T17:40:49.000+01:00
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes symfony#13365). Discussion ---------- [HttpFoundation] Make use of isEmpty() method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- fc51d54 [HttpFoundation] Make use of isEmpty() method
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -207,7 +207,7 @@ public function prepare(Request $request)
     {
         $headers = $this->headers;
 
-        if ($this->isInformational() || in_array($this->statusCode, array(204, 304))) {
+        if ($this->isInformational() || $this->isEmpty()) {
             $this->setContent(null);
             $headers->remove('Content-Type');
             $headers->remove('Content-Length');

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ public function prepare(Request $request)`
`207`	`207`	`{`
`208`	`208`	`$headers = $this->headers;`
`209`	`209`
`210`		`- if ($this->isInformational() \|\| in_array($this->statusCode, array(204, 304))) {`
	`210`	`+ if ($this->isInformational() \|\| $this->isEmpty()) {`
`211`	`211`	`$this->setContent(null);`
`212`	`212`	`$headers->remove('Content-Type');`
`213`	`213`	`$headers->remove('Content-Length');`