[DomCrawler] Fix return type Crawler:: discoverNamespace()

VolCh · VolCh · commit e39e8c239bb6 · 2017-11-15T16:17:34.000+02:00
Based on 3.x behavior
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1110,7 +1110,7 @@ private function createDOMXPath(\DOMDocument $document, array $prefixes = array(
     /**
      * @throws \InvalidArgumentException
      */
-    private function discoverNamespace(\DOMXPath $domxpath, string $prefix): string
+    private function discoverNamespace(\DOMXPath $domxpath, string $prefix): ?string
     {
         if (isset($this->namespaces[$prefix])) {
             return $this->namespaces[$prefix];
@@ -1122,6 +1122,8 @@ private function discoverNamespace(\DOMXPath $domxpath, string $prefix): string
         if ($node = $namespaces->item(0)) {
             return $node->nodeValue;
         }
+
+        return null;
     }
 
     private function findNamespacePrefixes(string $xpath): array

Original file line number	Diff line number	Diff line change
`@@ -1110,7 +1110,7 @@ private function createDOMXPath(\DOMDocument $document, array $prefixes = array(`
`1110`	`1110`	`/**`
`1111`	`1111`	`* @throws \InvalidArgumentException`
`1112`	`1112`	`*/`
`1113`		`- private function discoverNamespace(\DOMXPath $domxpath, string $prefix): string`
	`1113`	`+ private function discoverNamespace(\DOMXPath $domxpath, string $prefix): ?string`
`1114`	`1114`	`{`
`1115`	`1115`	`if (isset($this->namespaces[$prefix])) {`
`1116`	`1116`	`return $this->namespaces[$prefix];`
`@@ -1122,6 +1122,8 @@ private function discoverNamespace(\DOMXPath $domxpath, string $prefix): string`
`1122`	`1122`	`if ($node = $namespaces->item(0)) {`
`1123`	`1123`	`return $node->nodeValue;`
`1124`	`1124`	`}`
	`1125`	`+`
	`1126`	`+ return null;`
`1125`	`1127`	`}`
`1126`	`1128`
`1127`	`1129`	`private function findNamespacePrefixes(string $xpath): array`