bug symfony#24802 [TwigBridge] [Bootstrap 4] Fix hidden errors (ostrolucky)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] [Bootstrap 4] Fix hidden errors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#24801
| License       | MIT
| Doc PR        | -

Fixes displaying errors for:

- Symfony\Component\Form\Extension\Core\Type\BirthdayType
- Symfony\Component\Form\Extension\Core\Type\CheckboxType
- Symfony\Component\Form\Extension\Core\Type\DateIntervalType
- Symfony\Component\Form\Extension\Core\Type\DateTimeType
- Symfony\Component\Form\Extension\Core\Type\DateType
- Symfony\Component\Form\Extension\Core\Type\FileType
- Symfony\Component\Form\Extension\Core\Type\RadioType
- Symfony\Component\Form\Extension\Core\Type\TimeType

<table>
<tr><th>Layout</th><th>Before</th><th>After</th></tr>
<tr><td>vertical</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405939-1b4c92c8-c16f-11e7-9b21-8af296aa8d94.png" width="400" alt="less validation errors shown in vertical bs4 layout" /></td>
<td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405935-008a3d8c-c16f-11e7-8155-2a51ab55ae9a.png" width="400" alt="more validation errors shown in vertical bs4 layout"  /></td>
</tr>
<tr><td>horizontal</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405984-213b432c-c170-11e7-832a-d94c7f7ddf07.png" width="400" alt="less validation errors shown in bs4 horizontal layout" /></td>
<td valign="top"><img src="https://user-images.githubusercontent.com/496233/32406022-bd25bf92-c170-11e7-893d-f071225f8273.png" width="400" alt="more validation errors shown"  /></td>
</tr>
</table>

Commits
-------

5810983 Fix displaying errors for bootstrap 4

Author: fabpot

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig

@@ -2,6 +2,54 @@
 
 {# Widgets #}
 
+{% block money_widget -%}
+    {% if not valid %}
+        {% set group_class = ' form-control is-invalid' %}
+        {% set valid = true %}
+    {% endif %}
+    {{- parent() -}}
+{%- endblock money_widget %}
+
+{% block datetime_widget -%}
+    {%- if widget != 'single_text' and not valid -%}
+        {% set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) -%}
+        {% set valid = true %}
+    {%- endif -%}
+    {{- parent() -}}
+{%- endblock datetime_widget %}
+
+{% block date_widget -%}
+    {%- if widget != 'single_text' and not valid -%}
+        {% set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) -%}
+        {% set valid = true %}
+    {%- endif -%}
+    {{- parent() -}}
+{%- endblock date_widget %}
+
+{% block time_widget -%}
+    {%- if widget != 'single_text' and not valid -%}
+        {% set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) -%}
+        {% set valid = true %}
+    {%- endif -%}
+    {{- parent() -}}
+{%- endblock time_widget %}
+
+{% block dateinterval_widget -%}
+    {%- if widget != 'single_text' and not valid -%}
+        {% set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) -%}
+        {% set valid = true %}
+    {%- endif -%}
+    {{- parent() -}}
+{%- endblock dateinterval_widget %}
+
+{% block percent_widget -%}
+    <div class="input-group{{ not valid ? ' form-control is-invalid' }}">
+        {% set valid = true %}
+        {{- block('form_widget_simple') -}}
+        <span class="input-group-addon">%</span>
+    </div>
+{%- endblock percent_widget %}
+
 {% block form_widget_simple -%}
     {% if type is not defined or type != 'hidden' %}
         {%- set attr = attr|merge({class: (attr.class|default('') ~ ' form-control' ~ (type|default('') == 'file' ? '-file' : ''))|trim}) -%}
@@ -11,7 +59,7 @@
 
 {%- block widget_attributes -%}
     {%- if not valid %}
-        {% set attr = attr|merge({class: (attr.class|default('') ~ ' is-invalid')|trim}) %}
+        {% set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) %}
     {% endif -%}
     {{ parent() }}
 {%- endblock widget_attributes -%}
@@ -27,7 +75,7 @@
     {% if 'checkbox-inline' in parent_label_class %}
         {{- form_label(form, null, { widget: parent() }) -}}
     {% else -%}
-        <div class="form-check">
+        <div class="form-check{{ not valid ? ' form-control is-invalid' }}">
             {{- form_label(form, null, { widget: parent() }) -}}
         </div>
     {%- endif -%}
@@ -39,7 +87,7 @@
     {%- if 'radio-inline' in parent_label_class -%}
         {{- form_label(form, null, { widget: parent() }) -}}
     {%- else -%}
-        <div class="form-check">
+        <div class="form-check{{ not valid ? ' form-control is-invalid' }}">
             {{- form_label(form, null, { widget: parent() }) -}}
         </div>
     {%- endif -%}
@@ -55,6 +103,9 @@
             }) -}}
         {% endfor -%}
     {%- else -%}
+        {%- if not valid -%}
+            {%- set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) %}
+        {%- endif -%}
         <div {{ block('widget_container_attributes') }}>
             {%- for child in form %}
                 {{- form_widget(child, {

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_base_layout.html.twig

@@ -8,7 +8,7 @@
 {%- endblock textarea_widget %}
 
 {% block money_widget -%}
-    <div class="input-group">
+    <div class="input-group{{ group_class|default('') }}">
         {%- set append = money_pattern starts with '{{' -%}
         {%- if not append -%}
             <span class="input-group-addon">{{ money_pattern|replace({ '{{ widget }}':''}) }}</span>