bug symfony#13991 [Dependency Injection] Improve PhpDumper Performance for huge Containers (BattleRattle)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes symfony#13991).

Discussion
----------

[Dependency Injection] Improve PhpDumper Performance for huge Containers

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT

After making public services private, the dumping of the DIC takes much longer. This is due to the reference lookup method. Using the visited lookup as reference speeds up the whole dump (in our case by a factor of ~40).

Some stats from our DIC:
before: 32 sec. for dumping
after: 0.9 sec.

Commits
-------

2cc5011 use visited lookup with reference to gain performance

Author: fabpot

src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php

@@ -1151,7 +1151,7 @@ private function getDefinitionsFromArguments(array $arguments)
      *
      * @return bool
      */
-    private function hasReference($id, array $arguments, $deep = false, $visited = array())
+    private function hasReference($id, array $arguments, $deep = false, &$visited = array())
     {
         foreach ($arguments as $argument) {
             if (is_array($argument)) {