minor symfony#24486 [DI] Remove colon from env placeholders (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Remove colon from env placeholders

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | snc/SncRedisBundle#356
| License       | MIT
| Doc PR        | -

These colons in placeholders make them less neutral. Let's remove them.

Commits
-------

dca930f [DI] Remove colon from env placeholders

Author: fabpot

src/Symfony/Component/DependencyInjection/ParameterBag/EnvPlaceholderParameterBag.php

@@ -48,7 +48,7 @@ public function get($name)
             }
 
             $uniqueName = md5($name.uniqid(mt_rand(), true));
-            $placeholder = sprintf('env_%s_%s', $env, $uniqueName);
+            $placeholder = sprintf('env_%s_%s', str_replace(':', '_', $env), $uniqueName);
             $this->envPlaceholders[$env][$placeholder] = $placeholder;
 
             return $placeholder;