Skip to content

Commit eb632f3

Browse files
committed
minor symfony#13727 CS fixes (keradus)
This PR was squashed before being merged into the 2.3 branch (closes symfony#13727). Discussion ---------- CS fixes | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | ? | Fixed tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 7fd6ba0 CS fixes
2 parents d3f049d + 7fd6ba0 commit eb632f3

File tree

7 files changed

+24
-23
lines changed

7 files changed

+24
-23
lines changed

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
226226
'memcached' => 'Symfony\Component\HttpKernel\Profiler\MemcachedProfilerStorage',
227227
'redis' => 'Symfony\Component\HttpKernel\Profiler\RedisProfilerStorage',
228228
);
229-
list($class, ) = explode(':', $config['dsn'], 2);
229+
list($class) = explode(':', $config['dsn'], 2);
230230
if (!isset($supported[$class])) {
231231
throw new \LogicException(sprintf('Driver "%s" is not supported for the profiler.', $class));
232232
}

src/Symfony/Component/DomCrawler/Crawler.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ class Crawler extends \SplObjectStorage
3535
/**
3636
* Constructor.
3737
*
38-
* @param mixed $node A Node to use as the base for the crawling
38+
* @param mixed $node A Node to use as the base for the crawling
3939
* @param string $currentUri The current URI
40-
* @param string $baseHref The base href value
40+
* @param string $baseHref The base href value
41+
*
4142
* @api
4243
*/
4344
public function __construct($node = null, $currentUri = null, $baseHref = null)

src/Symfony/Component/Form/FormEvents.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212

1313
/**
1414
* To learn more about how form events work check the documentation
15-
* entry at {@link http://symfony.com/doc/any/components/form/form_events.html}
15+
* entry at {@link http://symfony.com/doc/any/components/form/form_events.html}.
1616
*
1717
* To learn how to dynamically modify forms using events check the cookbook
18-
* entry at {@link http://symfony.com/doc/any/cookbook/form/dynamic_form_modification.html}
18+
* entry at {@link http://symfony.com/doc/any/cookbook/form/dynamic_form_modification.html}.
1919
*
2020
* @author Bernhard Schussek <[email protected]>
2121
*/

src/Symfony/Component/Security/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function authenticate(TokenInterface $token)
6060
throw new BadCredentialsException('No pre-authenticated principal found in request.');
6161
}
6262

63-
$user = $this->userProvider->loadUserByUsername($user);
63+
$user = $this->userProvider->loadUserByUsername($user);
6464

6565
$this->userChecker->checkPostAuth($user);
6666

src/Symfony/Component/Security/Tests/Acl/Voter/AclVoterTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
2727
*/
2828
public function testSupportsAttribute($attribute, $supported)
2929
{
30-
list($voter, , $permissionMap, ,) = $this->getVoter(true, false);
30+
list($voter, , $permissionMap) = $this->getVoter(true, false);
3131

3232
$permissionMap
3333
->expects($this->once())
@@ -44,7 +44,7 @@ public function testSupportsAttribute($attribute, $supported)
4444
*/
4545
public function testSupportsAttributeNonString($attribute)
4646
{
47-
list($voter, , , , ,) = $this->getVoter(true, false);
47+
list($voter) = $this->getVoter(true, false);
4848

4949
$this->assertFalse($voter->supportsAttribute($attribute));
5050
}
@@ -72,7 +72,7 @@ public function getSupportsAttributeNonStringTests()
7272
*/
7373
public function testSupportsClass($class)
7474
{
75-
list($voter, , , ,) = $this->getVoter();
75+
list($voter) = $this->getVoter();
7676

7777
$this->assertTrue($voter->supportsClass($class));
7878
}
@@ -88,7 +88,7 @@ public function getSupportsClassTests()
8888

8989
public function testVote()
9090
{
91-
list($voter, , $permissionMap, ,) = $this->getVoter();
91+
list($voter, , $permissionMap) = $this->getVoter();
9292
$permissionMap
9393
->expects($this->atLeastOnce())
9494
->method('getMasks')
@@ -103,7 +103,7 @@ public function testVote()
103103
*/
104104
public function testVoteWhenNoObjectIsPassed($allowIfObjectIdentityUnavailable)
105105
{
106-
list($voter, , $permissionMap, ,) = $this->getVoter($allowIfObjectIdentityUnavailable);
106+
list($voter, , $permissionMap) = $this->getVoter($allowIfObjectIdentityUnavailable);
107107
$permissionMap
108108
->expects($this->once())
109109
->method('getMasks')
@@ -124,7 +124,7 @@ public function testVoteWhenNoObjectIsPassed($allowIfObjectIdentityUnavailable)
124124
*/
125125
public function testVoteWhenOidStrategyReturnsNull($allowIfUnavailable)
126126
{
127-
list($voter, , $permissionMap, $oidStrategy,) = $this->getVoter($allowIfUnavailable);
127+
list($voter, , $permissionMap, $oidStrategy) = $this->getVoter($allowIfUnavailable);
128128
$permissionMap
129129
->expects($this->once())
130130
->method('getMasks')

src/Symfony/Component/Security/Tests/Http/Firewall/RememberMeListenerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class RememberMeListenerTest extends \PHPUnit_Framework_TestCase
1919
{
2020
public function testOnCoreSecurityDoesNotTryToPopulateNonEmptySecurityContext()
2121
{
22-
list($listener, $context, $service, ,) = $this->getListener();
22+
list($listener, $context, $service) = $this->getListener();
2323

2424
$context
2525
->expects($this->once())
@@ -37,7 +37,7 @@ public function testOnCoreSecurityDoesNotTryToPopulateNonEmptySecurityContext()
3737

3838
public function testOnCoreSecurityDoesNothingWhenNoCookieIsSet()
3939
{
40-
list($listener, $context, $service, ,) = $this->getListener();
40+
list($listener, $context, $service) = $this->getListener();
4141

4242
$context
4343
->expects($this->once())
@@ -63,7 +63,7 @@ public function testOnCoreSecurityDoesNothingWhenNoCookieIsSet()
6363

6464
public function testOnCoreSecurityIgnoresAuthenticationExceptionThrownByAuthenticationManagerImplementation()
6565
{
66-
list($listener, $context, $service, $manager,) = $this->getListener();
66+
list($listener, $context, $service, $manager) = $this->getListener();
6767

6868
$context
6969
->expects($this->once())
@@ -101,7 +101,7 @@ public function testOnCoreSecurityIgnoresAuthenticationExceptionThrownByAuthenti
101101

102102
public function testOnCoreSecurity()
103103
{
104-
list($listener, $context, $service, $manager,) = $this->getListener();
104+
list($listener, $context, $service, $manager) = $this->getListener();
105105

106106
$context
107107
->expects($this->once())

src/Symfony/Component/Validator/Mapping/Loader/AbstractLoader.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ protected function addNamespaceAlias($alias, $namespace)
5858
/**
5959
* Creates a new constraint instance for the given constraint name.
6060
*
61-
* @param string $name The constraint name. Either a constraint relative
62-
* to the default constraint namespace, or a fully
63-
* qualified class name. Alternatively, the constraint
64-
* may be preceded by a namespace alias and a colon.
65-
* The namespace alias must have been defined using
66-
* {@link addNamespaceAlias()}.
67-
* @param mixed $options The constraint options
61+
* @param string $name The constraint name. Either a constraint relative
62+
* to the default constraint namespace, or a fully
63+
* qualified class name. Alternatively, the constraint
64+
* may be preceded by a namespace alias and a colon.
65+
* The namespace alias must have been defined using
66+
* {@link addNamespaceAlias()}.
67+
* @param mixed $options The constraint options
6868
*
6969
* @return Constraint
7070
*

0 commit comments

Comments
 (0)