minor symfony#14211 [DependencyInjection] Removed useless strtolower call (dosten)

fabpot · fabpot · commit f690cefee179 · 2015-04-04T20:52:16.000+02:00
This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Removed useless strtolower call | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The `setDefinition` method already lowercase the id, so it's not necessary to lowercase it twice. Commits ------- f62b050 Removed useless strtolower call
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -770,7 +770,7 @@ public function getAlias($id)
      */
     public function register($id, $class = null)
     {
-        return $this->setDefinition(strtolower($id), new Definition($class));
+        return $this->setDefinition($id, new Definition($class));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -770,7 +770,7 @@ public function getAlias($id)`
`770`	`770`	`*/`
`771`	`771`	`public function register($id, $class = null)`
`772`	`772`	`{`
`773`		`- return $this->setDefinition(strtolower($id), new Definition($class));`
	`773`	`+ return $this->setDefinition($id, new Definition($class));`
`774`	`774`	`}`
`775`	`775`
`776`	`776`	`/**`