Skip to content

Commit fd9459c

Browse files
committed
minor symfony#22630 Filesystem: annotate the one network test with a "network" group. (orlitzky)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes symfony#22630). Discussion ---------- Filesystem: annotate the one network test with a "network" group. This is one tiny commit that lets us avoid hitting the network while running the test suite. We've packaged symfony-filesystem in Gentoo, and our users can run the test suite when they install it. However, network access is forbidden during the test phase (it causes spurious failures, privacy issues, etc.). By marking the one network test with `@group network`, we are able to skip it with `--exclude-group network`. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- fd0dd57 Filesystem: annotate the one network test with a "network" group.
2 parents 0c4e549 + fd0dd57 commit fd9459c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/Symfony/Component/Filesystem/Tests/FilesystemTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,9 @@ public function testCopyCreatesTargetDirectoryIfItDoesNotExist()
156156
$this->assertEquals('SOURCE FILE', file_get_contents($targetFilePath));
157157
}
158158

159+
/**
160+
* @group network
161+
*/
159162
public function testCopyForOriginUrlsAndExistingLocalFileDefaultsToCopy()
160163
{
161164
$sourceFilePath = 'http://symfony.com/images/common/logo/logo_symfony_header.png';

0 commit comments

Comments
 (0)